Request 6374 (superseded)

gstreamer-plugins-bad-codecs.changes Changed

gstreamer-plugins-bad-codecs.spec Changed

_service:download_files:gst-plugins-bad-1.28.2.tar.xz/ChangeLog -> _service:download_files:gst-plugins-bad-1.28.3.tar.xz/ChangeLog Changed

@@ -1,3 +1,594 @@
+=== release 1.28.3 ===
+
+2026-05-11 18:28:12 +0100  Tim-Philipp Müller <tim@centricular.com>
+
+	* gst-plugins-bad.doap:
+	* meson.build:
+	  Release 1.28.3
+
+2026-04-27 16:45:04 +0300  Sebastian Dröge <sebastian@centricular.com>
+
+	* gst/mxf/mxfvanc.c:
+	  mxfdemux: Fix parsing of multiple VANC packets per edit unit
+	  Only the first packet was parsed before.
+	  Also fix a couple of bounds checks and add missing bounds checks.
+	  Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11592>
+
+2026-04-27 16:42:20 +0300  Sebastian Dröge <sebastian@centricular.com>
+
+	* gst/mxf/mxfvanc.c:
+	  mxfmux: Fix size calculations when writing VANC packets
+	  Fixes https://gitlab.freedesktop.org/gstreamer/gstreamer/-/work_items/5044
+	  Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11592>
+
+2026-04-15 15:19:12 +0300  Sebastian Dröge <sebastian@centricular.com>
+
+	* gst/mxf/mxfdemux.c:
+	  mxfdemux: Fix reverse temporal offsets array upper bounds check
+	  Fixes https://gitlab.freedesktop.org/gstreamer/gstreamer/-/work_items/5041
+	  Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11589>
+
+2026-04-15 11:35:47 +0300  Sebastian Dröge <sebastian@centricular.com>
+
+	* gst-libs/gst/codecparsers/gsth266parser.c:
+	  h266parser: Avoid out-of-bounds write when parsing PPS tile slices
+	  Thanks to Tian Shuo for reporting and suggesting the fix.
+	  Fixes https://gitlab.freedesktop.org/gstreamer/gstreamer/-/work_items/5035
+	  Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11588>
+
+2026-04-09 21:34:23 +0300  Sebastian Dröge <sebastian@centricular.com>
+
+	* ext/resindvd/gstpesfilter.c:
+	* gst/mpegdemux/gstpesfilter.c:
+	  mpegdemux: Add missing bounds checking to PES header parsing
+	  And also add missing advancing of the data pointer in various places, which
+	  would've caused all following header field parsing to read the wrong data.
+	  Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11587>
+
+2026-04-09 15:34:09 +0300  Sebastian Dröge <sebastian@centricular.com>
+
+	* gst/mpegdemux/gstmpegdemux.c:
+	  mpegdemux: Adding missing bounds checks when scanning for timestamps
+	  Also make the already existing checks a bit more explicit and avoid integer
+	  overflows with length calculations by using a bigger integer type.
+	  Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11587>
+
+2026-04-09 15:31:10 +0300  Sebastian Dröge <sebastian@centricular.com>
+
+	* ext/resindvd/gstpesfilter.c:
+	* gst/mpegdemux/gstpesfilter.c:
+	  mpegdemux: First check for enough data and then read the DTS and not the other way around
+	  Fixes https://gitlab.freedesktop.org/gstreamer/gstreamer/-/work_items/5026
+	  Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11587>
+
+2026-04-28 15:58:32 +0900  Dennis Han <jshan@live.co.kr>
+
+	* ext/qt6d3d11/gstqt6d3d11videoitem.cpp:
+	  qt6d3d11: fix null check in SetForceAspectRatio()
+	  The null-check branch incorrectly attempted to call
+	  setForceAspectRatio() on a null item pointer.
+	  Return early when item is null and call the setter otherwise.
+	  Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11575>
+
+2026-05-08 18:05:19 +0300  Sebastian Dröge <sebastian@centricular.com>
+
+	* sys/androidmedia/gstamc.c:
+	  androidmedia: Free element name after use for logging
+	  Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11573>
+
+2026-05-07 16:49:08 +0100  Arthur Chan <arthur.chan@adalogics.com>
+
+	* gst-libs/gst/codecparsers/gsth266parser.c:
+	  h266parser: Add missing freeing function for H266 SEI message
+	  Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11571>
+
+2026-04-07 18:41:35 +0530  Nirbheek Chauhan <nirbheek@centricular.com>
+
+	* gst/closedcaption/misc.h:
+	  closedcaption: Fix invalid ISO varargs syntax
+	  When there are no var args, there's a trailing comma. MSVC has been
+	  suppressing that trailing comma, but in /std:c11 mode it (correctly)
+	  does not suppress it.
+	  Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11563>
+
+2026-04-07 13:09:24 +0100  Nirbheek Chauhan <nirbheek@centricular.com>
+
+	* meson.build:
+	  meson: Require C std gnu11 or c11
+	  When using gcc or clang, gnu11 will be used, and when using MSVC c11
+	  will be used which will pass /std:c11. This provides us with the
+	  `restrict` keyword on all supported platforms.
+	  We can do this now because we require Visual Studio 2019.
+	  This feature was added in Meson 1.3
+	  Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11563>
+
+2026-05-06 16:05:40 +0300  Sebastian Dröge <sebastian@centricular.com>
+
+	* sys/decklink/gstdecklink.cpp:
+	* sys/decklink/gstdecklinkvideosink.cpp:
+	  decklink: Fix various refcount issues and related leaks
+	  Also initializes refcount with 1 again in GStreamerVideoOutputCallback for
+	  consistency, which was changed in https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11006
+	  Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11558>
+
+2026-04-10 17:35:41 +0300  Sebastian Dröge <sebastian@centricular.com>
+
+	* sys/aja/gstajasink.cpp:
+	  ajasink: Correctly set reference source
+	  It's SetFramePulseReference() does something different and what we want is
+	  SetReference() just like in the source element.
+	  Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11309>
+
+2026-03-31 12:57:19 +0530  Nirbheek Chauhan <nirbheek@centricular.com>
+
+	* sys/androidmedia/gstamc.c:
+	  amc: Log the caps for registered codecs
+	  Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11551>
+
+2026-01-17 00:40:11 +0530  Nirbheek Chauhan <nirbheek@centricular.com>
+
+	* sys/androidmedia/gstamc.c:
+	  amc: Reduce verbosity of INFO logging during init
+	  We log too much during init to INFO, and Android Studio just drops all
+	  those messages because they're too many.
+	  Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11551>
+
+2026-01-16 04:49:31 +0530  Nirbheek Chauhan <nirbheek@centricular.com>
+
+	* sys/androidmedia/gstamc.c:
+	  amc: Add constrained-baseline profile when baseline is available
+	  Otherwise we can't decode constrained-baseline videos.
+	  Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11551>
+
+2026-01-16 02:43:45 +0530  Nirbheek Chauhan <nirbheek@centricular.com>
+
+	* sys/androidmedia/gstamcvideoenc.c:
+	  amc: Remove support for API level < 25
+	  We no longer support Android older than Nougat.
+	  Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11551>
+
+2026-05-07 17:17:39 +0100  Arthur Chan <arthur.chan@adalogics.com>
+
+	* gst/videoparsers/h263parse.c:
+	  h263parse: Fix wrong ratio masking
+	  Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11537>
+
+2026-05-07 17:09:32 +0100  Arthur Chan <arthur.chan@adalogics.com>
+
+	* gst/videoparsers/gsth263parse.c:
+	  h263parse: Missing handling of reserved invalid EPAR_D value
+	  Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11535>
+
+2026-05-07 16:43:15 +0100  Arthur Chan <arthur.chan@adalogics.com>
+
+	* gst/videoparsers/gstpngparse.c:
+	  pngparse: Fix Use-after-free bug
+	  Signed-off-by: Arthur Chan <arthur.chan@adalogics.com>
+	  Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11531>
+
+2026-05-07 16:35:31 +0100  Arthur Chan <arthur.chan@adalogics.com>
+
+	* gst/videoparsers/gstav1parse.c:
+	  av1parse: Fix null pointer deference
+	  Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11529>
+
+2026-05-06 22:38:43 +0900  Seungha Yang <seungha@centricular.com>
+
+	* ext/qt6d3d11/gstqml6d3d11sink.cpp:
+	* ext/qt6d3d11/gstqsg6d3d11node.cpp:
+	  qml6d3d11sink: Clear texture on Paused-to-Ready transition
+	  Like the GL version of qmlsink, clear owned texture to black
+	  instead of keeping the last rendered frame
+	  Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11520>
+
+2026-04-21 09:32:02 -0400  Xavier Claessens <xclaessens@netflix.com>
+
+	* sys/va/gstvabaseenc.c:
+	  va: do not post error message when push fails
+	  Downstream is responsible to post a specific error message. If it did
+	  not, then upstream source will post a generic error message.
+	  Intermediary elements just have to propagate the return value.
+	  This prevents posting an error message when stopping a pipeline and
+	  GST_FLOW_FLUSHING is returned.
+	  Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11504>
+
+2026-03-26 11:40:44 +0100  Piotr Brzeziński <piotr@centricular.com>
+
+	* sys/applemedia/vtdec.c:
+	* sys/applemedia/vtenc.c:
+	* sys/applemedia/vtutil.c:
+	* sys/applemedia/vtutil.h:
+	  applemedia: Don't expose unsupported formats for Vulkan/GL
+	  We exposed lots of formats in caps, but GL/Vulkan code doesn't have
+	  paths for all of them. For GL specifically, BGRA is theoretically
+	  supported but it's currently broken, pending investigation.
+	  Also adds a filter to gst_vtutil_caps_append_video_format() to avoid
+	  putting RGBA64_LE in non-system-memory part of the caps in vtdec.
+	  Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11498>
+
+2026-04-29 10:00:08 -0400  Dominique Leroux <dominique.p.leroux@gmail.com>
+
+	* tests/check/pipelines/vtdec-output-paths.c:
+	  applemedia: tests: harden vtdec output path checks
+	  The appsink new-sample callback runs from the streaming thread and
+	  asks the main loop to stop once the comparison prefix has been
+	  collected. Release the pulled sample before waking the main thread
+	  and keep only the requested number of buffers.
+	  The fixture has enough frames for the comparison, so EOS before
+	  collecting the requested eight samples is a failure. Require the
+	  expected sample count and report the actual count.
+	  Use gst_check_run_suite_nofork() for the nofork setup as well. The
+	  previous manual runner always returned 0, hiding check failures from
+	  Meson.
+	  Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11461>
+
+2026-04-28 11:45:43 +0200  Tomasz Bujewski <tomasz.bujewski@intel.com>
+
+	* gst-libs/gst/analytics/gstanalyticsobjectdetectionmtd.c:
+	* gst-libs/gst/analytics/gstanalyticssegmentationmtd.c:
+	  analytics: fix meta transform functions for copy cases
+	  Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11476>
+
+2026-01-22 13:13:28 +0100  Fabian Orccon <cfoch.fabian@gmail.com>
+
+	* gst-libs/gst/mse/meson.build:
+	  mse: Also disable the library if the option is disabled
+	  Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11473>
+
+2026-04-28 16:33:05 +0200  Edward Hervey <edward@centricular.com>
+
+	* gst/mpegtsdemux/pesparse.c:
+	  mpegts: Fix ESCR reading
+	  The second part is 4 bytes further
+	  Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11454>
+
+2026-04-28 16:32:18 +0200  Edward Hervey <edward@centricular.com>
+
+	* gst/mpegtsdemux/mpegtsbase.c:
+	  mpegtsbase: Protect potential OOB read
+	  Like it's done in get_registration_from_descriptors()
+	  Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11454>
+
+2026-04-28 15:13:13 +0200  Edward Hervey <edward@centricular.com>
+
+	* gst/mpegtsdemux/mpegtsbase.c:
+	  mpegtsbase: Remove un-needed lines
+	  flush_event will always be NULL here (cleared just above)
+	  Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11454>
+
+2026-04-23 18:39:44 +0200  Piotr Brzeziński <piotr@centricular.com>
+
+	* sys/applemedia/vtdec.c:
+	  vtdec: Avoid blocking decoder output callback
+	  Blocking VT's output callback is not a good idea, as it can cause the
+	  decoder to error out if it's blocked for too long, e.g. when a user
+	  pauses playback. Especially with HEVC+alpha decoding, VT is extremely
+	  sensitive and can error out after being blocked for just 10 seconds.
+	  With this change I can't reproduce any similar problems anymore.
+	  However, changing this also simplifies vtdec's locking situation a lot
+	  because we have one less thread to possibly deadlock with. In fact, it's
+	  been the source of most our problems since the output loop was added.
+	  This change will hopefully reduce the amount of future problems in this
+	  area.
+	  This also resolves a recent issue where if the output loop triggered
+	  draining (via negotiation during buffer push), the input side would
+	  start to push buffers at max speed because the output loop (correctly)
+	  no longer holds the stream lock while pushing.
+	  Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11441>
+
+2026-04-24 16:48:57 +0200  Piotr Brzeziński <piotr@centricular.com>
+
+	* sys/applemedia/vtdec.c:
+	  vtdec: Don't leak CMSampleBuffer during decoder reset
+	  Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11441>
+
+2026-03-30 16:45:31 +0200  Piotr Brzeziński <piotr@centricular.com>
+
+	* ext/vulkan/vkupload.c:
+	* tests/check/elements/vkupload.c:
+	  vkupload: Fix wrong image dimensions due to stride mismatch
+	  We were possibly using the wrong buffer for the get_plane_dimensions()
+	  call. If the input buffer had a different stride value from the newly
+	  allocated Vulkan buffer, the resulting image would be incorrect.
+	  Also adds a test, which was actually meant to test an almost identical
+	  issue in vulkandownload but ended up spotting this problem instead.
+	  Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11387>
+
+2026-03-26 10:34:11 +0100  Piotr Brzeziński <piotr@centricular.com>
+
+	* ext/vulkan/vkdownload.c:
+	* tests/check/elements/vkdownload.c:
+	* tests/check/meson.build:
+	  vkdownload: Fix corrupted output image due to mismatched stride/padding
+	  Makes sure to the destination buffer layout when filling
+	  VkBufferImageCopy for the image download. The old version was using the
+	  input buf parameters for this, so if there was a mismatch, we'd get a
+	  corrupted output image with each row shifted and stretched.
+	  Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11387>
+
+2026-03-31 12:38:22 +0200  Piotr Brzeziński <piotr@centricular.com>
+
+	* tests/check/elements/cudaconvert.c:
+	* tests/check/elements/cudafilter.c:
+	* tests/check/elements/nvdec.c:
+	* tests/check/elements/nvenc.c:
+	* tests/check/libs/cudamemory.c:
+	  tests: replace CK_FORK=no with GST_CHECK_MAIN_NOFORK
+	  Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11387>
+
+2026-03-30 14:55:27 +0200  Piotr Brzeziński <piotr@centricular.com>
+
+	* tests/check/elements/vkcolorconvert.c:
+	* tests/check/elements/vkdeviceprovider.c:
+	* tests/check/elements/vkupload.c:
+	* tests/check/libs/vkcommandpool.c:
+	* tests/check/libs/vkdevice.c:
+	* tests/check/libs/vkformat.c:
+	* tests/check/libs/vkimage.c:
+	* tests/check/libs/vkimagebufferpool.c:
+	* tests/check/libs/vkinstance.c:
+	* tests/check/libs/vkmemory.c:
+	* tests/check/libs/vkvideodecode.c:
+	* tests/check/libs/vkvideoencodeav1.c:
+	* tests/check/libs/vkvideoencodeh264.c:
+	* tests/check/libs/vkvideoencodeh265.c:
+	* tests/check/libs/vkwindow.c:
+	  vulkan: Fix tests crashing on macOS due to fork() usage
+	  Vulkan tests would end up segfaulting somewhere inside Metal when
+	  running under MoltenVK on macOS.
+	  Turns out this was because of fork() and simply disabling its usage
+	  makes it all run.
+	  The only exceptions are vkdeviceprovider and vkwindow tests: those spawn
+	  a vulkansink which needs a window,
+	  and for that we need to use gst_macos_main(), otherwise there's a
+	  critical warning which causes the test to fail.
+	  Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11387>
+
+2026-04-23 12:09:29 -0400  Dominique Leroux <dominique.p.leroux@gmail.com>
+
+	* sys/applemedia/corevideobuffer.c:
+	  applemedia: fix planar CoreVideo buffer offsets
+	  Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11432>
+
+2026-04-23 12:09:00 -0400  Dominique Leroux <dominique.p.leroux@gmail.com>
+
+	* tests/check/pipelines/vtdec-output-paths.c:
+	  applemedia: add vtdec download content checks
+	  Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11432>
+
+2026-04-24 12:25:19 +0300  Vivia Nikolaidou <vivia@ahiru.eu>
+
+	* tests/check/elements/interlace.c:
+	  interlace: Add some more autoated tests
+	  The ones referenced in
+	  https://gitlab.freedesktop.org/gstreamer/gstreamer/-/work_items/1764
+	  and
+	  https://gitlab.freedesktop.org/gstreamer/gstreamer/-/commit/bf89c80d74f424e54a401243513781c73d0a6e6d
+	  Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11428>
+
+2026-04-24 11:49:11 +0300  Vivia Nikolaidou <vivia@ahiru.eu>
+
+	* gst/interlace/gstinterlace.c:
+	  Revert "interlace: Drop framerate from query caps of sinkpad"
+	  This reverts commit 1ac30ad53fff9b572212d7727695b1424b803214.
+	  This commit broke negotiation in pipelines where upstream framerate is flexible
+	  and downstream framerate is fixed, i.e.
+	  gst-launch-1.0 videotestsrc \
+	  ! video/x-raw,framerate=30/1,interlace-mode=progressive \
+	  ! videorate \
+	  ! interlace field-pattern=1:1 \
+	  ! video/x-raw,framerate=25/1,interlace-mode=interleaved \
+	  ! fakesink
+	  The original issue reported was fixed by commit
+	  bf89c80d74f424e54a401243513781c73d0a6e6d.
+	  Fixes: https://gitlab.freedesktop.org/gstreamer/gstreamer/-/work_items/1764
+	  Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11428>
+
+2026-04-23 11:12:37 +0200  RSWilli <bartel.wilhelm@gmail.com>
+
+	* ext/webrtc/webrtcdatachannel.c:
+	  webrtc: take ownership of the src_bin and sink_bin
+	  before this the webrtcbin takes ownership when adding the bins to the webrtcbin.
+	  This could lead to use after free when the datachannel went into error state because of a lost connection
+	  Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11420>
+
+2026-04-23 10:57:31 +0200  RSWilli <bartel.wilhelm@gmail.com>
+
+	* ext/webrtc/webrtcdatachannel.c:
+	  webrtc: don't leak error message
+	  Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11420>
+
+2026-04-04 20:34:19 +0530  Nirbheek Chauhan <nirbheek@centricular.com>
+
+	* sys/applemedia/avfdeviceprovider.m:
+	* sys/applemedia/avsamplevideosink.m:
+	* sys/applemedia/corevideobuffer.c:
+	* sys/applemedia/helpers.h:
+	* sys/applemedia/meson.build:
+	* sys/applemedia/vtdec.c:
+	* sys/applemedia/vtdec.h:
+	* sys/applemedia/vtenc.c:
+	* sys/applemedia/vtutil.c:
+	  applemedia: Require Xcode 12.4 for all builds
+	  Xcode 12.4 is the newest Xcode that you can install on macOS 10.15. We
+	  require Xcode 12.4, but we only support macOS builds on it. For iOS,
+	  tvOS, etc a newer (currently unspecified) Xcode version is required.
+	  Fixes #4941
+	  Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11369>
+
+2026-04-15 13:07:27 +0200  Anders Hellerup Madsen <anders@hellerup-madsen.dk>
+
+	* sys/nvcodec/kernel/gstnvjpegenc.cu:
+	  nvjpegenc: use float-precision constants in CUDA kernel
+	  Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11400>
+
+2026-04-15 13:05:13 +0200  Anders Hellerup Madsen <anders@hellerup-madsen.dk>
+
+	* sys/hip/kernel/converter.cu:
+	  hip: use float-precision constants in converter kernel
+	  Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11400>
+
+2026-04-15 12:52:46 +0200  Anders Hellerup Madsen <anders@hellerup-madsen.dk>
+
+	* sys/nvcodec/kernel/gstcudaconverter.cu:
+	  nvcodec: use float-precision constants in CUDA converter kernel
+	  Replace double-precision floating point literals with explicit
+	  single-precision (f-suffixed) constants throughout the CUDA converter
+	  kernel. This avoids implicit float-to-double promotion in arithmetic
+	  expressions, which incurs a significant performance penalty on GPU
+	  hardware where double-precision math is much slower than float.
+	  Affected areas:
+	  - scale_to_* helper functions (e.g. val * 255.0 -> val * 255.0f)
+	  - blend_* helper functions (division and subtraction chains)
+	  - Output struct Blend methods (1.0 -> 1.0f argument)
+	  - GstCudaConverterMain kernel (coordinate math and comparisons)
+	  - Corresponding string-embedded copy of the kernel code
+	  Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11400>
+
+2026-04-20 18:02:40 +0200  Piotr Brzeziński <piotr@centricular.com>
+
+	* sys/applemedia/vtdec.c:
+	  vtdec: Avoid locking up during a decoder reset
+	  If require_reset is set while the reorder_queue is full, the output
+	  callback can block. This in turn causes VTDecompressionSessionInvalidate
+	  to block as well, leading to a deadlock because the reset logic holds
+	  the stream lock, preventing the output loop from draining the queue.
+	  This simply makes sure we don't block the output callback in this
+	  scenario.
+	  Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11395>
+
+2026-03-30 11:13:38 -0400  Dominique Leroux <dominique.p.leroux@gmail.com>
+
+	* tests/check/meson.build:
+	* tests/check/pipelines/vtdec-output-paths.c:
+	  vtdec: Pipeline tests for all 3 memory output paths
+	  Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11285>
+
+2026-03-29 20:25:37 -0400  Dominique Leroux <dominique.p.leroux@gmail.com>
+
+	* sys/applemedia/vtdec.c:
+	  vtdec: warn about MoltenVK argument buffers
+	  Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11285>
+
+2026-03-17 21:36:21 -0400  Dominique Leroux <dominique.p.leroux@gmail.com>
+
+	* sys/applemedia/iosurfacevulkanmemory.c:
+	* sys/applemedia/iosurfacevulkanmemory.h:
+	* sys/applemedia/metal-helpers.h:
+	* sys/applemedia/videotexturecache-vulkan.mm:
+	  applemedia: import Metal textures at Vulkan image creation time
+	  MoltenVK 1.3.0 and later regressed on the
+	  vtdec -> VulkanImage -> vulkancolorconvert path when
+	  IOSurface-backed plane textures were attached after
+	  vkCreateImage() through vkSetMTLTextureMVK().
+	  That path relies on MoltenVK-specific post-creation binding APIs
+	  that have been superseded by standard Metal interop extensions.
+	  Keep the existing per-plane MTLTexture creation, but move the
+	  Metal texture import into VkImage creation through
+	  VkImportMetalTextureInfoEXT.
+	  Importing the Metal texture as part of VkImageCreateInfo makes
+	  the Vulkan image describe the external texture at creation time
+	  instead of retrofitting it afterward. This aligns the Apple
+	  import path with the newer Metal-object import model and avoids
+	  depending on the deprecated post-create binding flow.
+	  On affected MoltenVK releases, successful playback still requires
+	  setting MVK_CONFIG_USE_METAL_ARGUMENT_BUFFERS=0 at runtime.
+	  That workaround was confirmed from MoltenVK 1.3.0 onward during
+	  investigation of this path.
+	  Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11285>
+
+2026-03-17 21:35:35 -0400  Dominique Leroux <dominique.p.leroux@gmail.com>
+
+	* gst-libs/gst/vulkan/meson.build:
+	  vulkan: prefer direct MoltenVK linkage on Darwin
+	  Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11285>
+
+2026-04-15 13:07:55 +0300  Sebastian Dröge <sebastian@centricular.com>
+
+	* gst/mxf/mxfaes-bwf.c:
+	  mxfmux: aes-bwf: Use correct size when serializing user data / channel status mode
+	  This code is not actually reachable (yet) from mxfmux.
+	  Thanks to Tian Shuo for reporting and suggesting the fix.
+	  Fixes https://gitlab.freedesktop.org/gstreamer/gstreamer/-/work_items/5037
+	  Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11345>
+
+2026-04-10 17:04:55 -0400  Monty C <montyc1999@gmail.com>
+
+	* sys/applemedia/vtdec.c:
+	  vtdec: fix deadlock when restarting
+	  Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11343>
+
+2026-04-14 22:09:40 +0900  Andrew Yooeun Chun <aychun00@gmail.com>
+
+	* gst-libs/gst/codecparsers/gsth265parser.h:
+	  h265parser: fix comments in header
+	  CPS -> CPB, togeter -> together, and add missing spaces after `@param:`.
+	  Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11339>
+
+2026-04-14 22:03:21 +0900  Andrew Yooeun Chun <aychun00@gmail.com>
+
+	* gst-libs/gst/codecparsers/gsth265parser.c:
+	  h265parser: use sub-layer 0 CPB count in buffering_period SEI loops
+	  The NAL and VCL initial CPB removal delay loops were bounded by
+	  cpb_cnt_minus1i. Read the CPB count from sub-layer 0 instead.
+	  Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11339>
+
+2026-04-12 16:21:55 -0400  Monty C <montyc1999@gmail.com>
+
+	* sys/nvcodec/plugin.c:
+	  nvcodec: Fix missing adapter-luid when loading decoders from cache
+	  Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11329>
+
+2026-04-09 21:32:28 +0300  Sebastian Dröge <sebastian@centricular.com>
+
+	* ext/resindvd/gstpesfilter.c:
+	* gst/mpegdemux/gstpesfilter.c:
+	  mpegdemux: Fix ES_rate parsing
+	  It's not used anywhere so this doesn't really matter.
+	  Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11324>
+
+2026-04-09 21:18:36 +0300  Sebastian Dröge <sebastian@centricular.com>
+
+	* gst/mpegtsdemux/pesparse.c:
+	  tsdemux: Only read 3 bytes for the ES_rate
+	  Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11324>
+
+2026-04-09 21:08:55 +0300  Sebastian Dröge <sebastian@centricular.com>
+
+	* gst/mpegtsdemux/pesparse.c:
+	  tsdemux: Fix parsing of PES ESCR and following PES header fields
+	  The ESCR is 6 bytes and in the same format as the PCR, not 5 bytes and in the
+	  same format as DTS/PTS. By skipping only 5 bytes, parsing of all following PES
+	  header fields looked at the wrong bytes.
+	  Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11324>
+
+2026-04-10 15:50:46 +0200  Edward Hervey <bilboed@bilboed.com>
+
+	* gst/mpegtsdemux/mpegtspacketizer.c:
+	  mpegtspacketizer: Avoid potential overflow
+	  Avoid potential address overflow by using subtraction instead of additions.
+	  If data is close to the memory range limit (especially on 32bit systems), adding
+	  to it could make it wrap over.
+	  Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11307>
+
+2026-04-09 09:31:47 +0300  Sebastian Dröge <sebastian@centricular.com>
+
+	* ext/soundtouch/gstbpmdetect.cc:
+	  bpmdetect: Fix calculation of number of samples for >1 channels
+	  Reported by and patch provided by Olivier Laflamme.
+	  Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11297>
+
+2021-07-15 11:47:44 +0200  Andreas Frisch <andreas.frisch@ltnglobal.com>
+
+	* gst/mpegtsdemux/tsdemux.c:
+	  tsdemux: Fix segfault when trying to handle SCTE-35 with incorrect program specified
+	  Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11294>
+
+2026-04-07 20:07:19 +0100  Tim-Philipp Müller <tim@centricular.com>
+
+	* meson.build:
+	  Back to development after 1.28.2
+
 === release 1.28.2 ===
 
 2026-04-07 20:02:23 +0100  Tim-Philipp Müller <tim@centricular.com>

_service:download_files:gst-plugins-bad-1.28.2.tar.xz/RELEASE -> _service:download_files:gst-plugins-bad-1.28.3.tar.xz/RELEASE Changed

_service:download_files:gst-plugins-bad-1.28.2.tar.xz/ext/qt6d3d11/gstqml6d3d11sink.cpp -> _service:download_files:gst-plugins-bad-1.28.3.tar.xz/ext/qt6d3d11/gstqml6d3d11sink.cpp Changed

@@ -79,6 +79,9 @@
     guint prop_id, GValue * value, GParamSpec * pspec);
 static void gst_qml6_d3d11_sink_set_context (GstElement * element,
     GstContext * context);
+static GstStateChangeReturn
+gst_qml6_d3d11_sink_change_state (GstElement * element,
+    GstStateChange transition);
 static gboolean gst_qml6_d3d11_sink_set_caps (GstBaseSink * sink,
     GstCaps * caps);
 static gboolean gst_qml6_d3d11_sink_start (GstBaseSink * sink);
@@ -135,6 +138,8 @@
 
   element_class->set_context =
       GST_DEBUG_FUNCPTR (gst_qml6_d3d11_sink_set_context);
+  element_class->change_state =
+      GST_DEBUG_FUNCPTR (gst_qml6_d3d11_sink_change_state);
 
   sink_class->set_caps = GST_DEBUG_FUNCPTR (gst_qml6_d3d11_sink_set_caps);
   sink_class->start = GST_DEBUG_FUNCPTR (gst_qml6_d3d11_sink_start);
@@ -252,6 +257,22 @@
   GST_ELEMENT_CLASS (parent_class)->set_context (element, context);
 }
 
+static GstStateChangeReturn
+gst_qml6_d3d11_sink_change_state (GstElement * element,
+    GstStateChange transition)
+{
+  auto self = GST_QML6_D3D11_SINK (element);
+  auto priv = self->priv;
+
+  auto ret = GST_ELEMENT_CLASS (parent_class)->change_state (element,
+      transition);
+
+  if (transition == GST_STATE_CHANGE_PAUSED_TO_READY && priv->widget)
+    priv->widget->SetBuffer (nullptr);
+
+  return ret;
+}
+
 static gboolean
 gst_qml6_d3d11_sink_set_caps (GstBaseSink * sink, GstCaps * caps)
 {

_service:download_files:gst-plugins-bad-1.28.2.tar.xz/ext/qt6d3d11/gstqsg6d3d11node.cpp -> _service:download_files:gst-plugins-bad-1.28.3.tar.xz/ext/qt6d3d11/gstqsg6d3d11node.cpp Changed

_service:download_files:gst-plugins-bad-1.28.2.tar.xz/ext/qt6d3d11/gstqt6d3d11videoitem.cpp -> _service:download_files:gst-plugins-bad-1.28.3.tar.xz/ext/qt6d3d11/gstqt6d3d11videoitem.cpp Changed

_service:download_files:gst-plugins-bad-1.28.2.tar.xz/ext/resindvd/gstpesfilter.c -> _service:download_files:gst-plugins-bad-1.28.3.tar.xz/ext/resindvd/gstpesfilter.c Changed

@@ -212,19 +212,16 @@
 
   /* stuffing bits, first two bits are '10' for mpeg2 pes so this code is
    * not triggered. */
-  while (TRUE) {
-    if (*data != 0xff)
-      break;
-
+  while (datalen > 0 && *data == 0xff) {
     data++;
     datalen--;
 
     GST_DEBUG ("got stuffing bit");
-
-    if (datalen < 1)
-      goto need_more_data;
   }
 
+  if (datalen < 1)
+    goto need_more_data;
+
   /* STD buffer size, never for mpeg2 */
   if ((*data & 0xc0) == 0x40) {
     GST_DEBUG ("have STD");
@@ -322,9 +319,10 @@
     }
     /* check for DTS */
     if ((flags & 0x40)) {
-      READ_TS (data, filter->dts, lost_sync);
       if (datalen < 5)
         goto need_more_data;
+
+      READ_TS (data, filter->dts, lost_sync);
       GST_DEBUG ("DTS found %" G_GUINT64_FORMAT, filter->dts);
       header_data_length -= 5;
       datalen -= 5;
@@ -345,10 +343,10 @@
       if (datalen < 3)
         goto need_more_data;
 
-      es_rate = ((guint32) (*data++ & 0x07)) << 14;
-      es_rate |= ((guint32) (*data++)) << 7;
-      es_rate |= ((guint32) (*data++ & 0xFE)) >> 1;
-      GST_DEBUG ("%x ES Rate found %u", filter->id, es_rate);
+      es_rate = GST_READ_UINT24_BE (data);
+      GST_DEBUG ("%x ES Rate found %u", filter->id,
+          ((es_rate >> 1) & 0x003fffff) * 50);
+      data += 3;
       header_data_length -= 3;
       datalen -= 3;
     }
@@ -388,37 +386,60 @@
     }
     /* additional_copy_info_flag  */
     if ((flags & 0x04)) {
+      if (datalen < 1)
+        goto need_more_data;
       GST_DEBUG ("%x additional copy info, flags 0x%02x", filter->id, *data);
+      data++;
+      header_data_length--;
+      datalen--;
     }
     /* PES_CRC_flag  */
     if ((flags & 0x02)) {
+      if (datalen < 2)
+        goto need_more_data;
       GST_DEBUG ("%x PES_CRC", filter->id);
+      data += 2;
+      header_data_length -= 2;
+      datalen -= 2;
     }
     /* PES_extension_flag  */
     if ((flags & 0x01)) {
+      if (datalen < 1)
+        goto need_more_data;
       flags = *data++;
-      header_data_length -= 1;
-      datalen -= 1;
+      header_data_length--;
+      datalen--;
       GST_DEBUG ("%x PES_extension, flags 0x%02x", filter->id, flags);
       /* PES_private_data_flag */
       if ((flags & 0x80)) {
         GST_DEBUG ("%x PES_private_data_flag", filter->id);
+        if (datalen < 16)
+          goto need_more_data;
         data += 16;
         header_data_length -= 16;
         datalen -= 16;
       }
       /* pack_header_field_flag */
       if ((flags & 0x40)) {
-        guint8 pack_field_length = *data;
+        guint8 pack_field_length;
+        if (datalen < 1)
+          goto need_more_data;
+        pack_field_length = *data++;
+        header_data_length--;
+        datalen--;
         GST_DEBUG ("%x pack_header_field_flag, pack_field_length %d",
             filter->id, pack_field_length);
-        data += pack_field_length + 1;
-        header_data_length -= pack_field_length + 1;
-        datalen -= pack_field_length + 1;
+        if (datalen < pack_field_length)
+          goto need_more_data;
+        data += pack_field_length;
+        header_data_length -= pack_field_length;
+        datalen -= pack_field_length;
       }
       /* program_packet_sequence_counter_flag */
       if ((flags & 0x20)) {
         GST_DEBUG ("%x program_packet_sequence_counter_flag", filter->id);
+        if (datalen < 2)
+          goto need_more_data;
         data += 2;
         header_data_length -= 2;
         datalen -= 2;
@@ -426,21 +447,30 @@
       /* P-STD_buffer_flag */
       if ((flags & 0x10)) {
         GST_DEBUG ("%x P-STD_buffer_flag", filter->id);
+        if (datalen < 2)
+          goto need_more_data;
         data += 2;
         header_data_length -= 2;
         datalen -= 2;
       }
       /* PES_extension_flag_2 */
       if ((flags & 0x01)) {
-        guint8 PES_extension_field_length = *data++;
+        guint8 PES_extension_field_length;
+        if (datalen < 1)
+          goto need_more_data;
+        PES_extension_field_length = *data++;
+        header_data_length--;
+        datalen--;
         GST_DEBUG ("%x PES_extension_flag_2, len %d",
             filter->id, PES_extension_field_length & 0x7f);
+        if (datalen < (PES_extension_field_length & 0x7f))
+          goto need_more_data;
         if (PES_extension_field_length == 0x81) {
           GST_DEBUG ("%x substream id 0x%02x", filter->id, *data);
         }
         data += PES_extension_field_length & 0x7f;
-        header_data_length -= (PES_extension_field_length & 0x7f) + 1;
-        datalen -= (PES_extension_field_length & 0x7f) + 1;
+        header_data_length -= PES_extension_field_length & 0x7f;
+        datalen -= PES_extension_field_length & 0x7f;
       }
     }
     /* calculate the amount of real data in this PES packet */

_service:download_files:gst-plugins-bad-1.28.2.tar.xz/ext/soundtouch/gstbpmdetect.cc -> _service:download_files:gst-plugins-bad-1.28.3.tar.xz/ext/soundtouch/gstbpmdetect.cc Changed

_service:download_files:gst-plugins-bad-1.28.2.tar.xz/ext/vulkan/vkdownload.c -> _service:download_files:gst-plugins-bad-1.28.3.tar.xz/ext/vulkan/vkdownload.c Changed

_service:download_files:gst-plugins-bad-1.28.2.tar.xz/ext/vulkan/vkupload.c -> _service:download_files:gst-plugins-bad-1.28.3.tar.xz/ext/vulkan/vkupload.c Changed

_service:download_files:gst-plugins-bad-1.28.2.tar.xz/ext/webrtc/webrtcdatachannel.c -> _service:download_files:gst-plugins-bad-1.28.3.tar.xz/ext/webrtc/webrtcdatachannel.c Changed

@@ -139,6 +139,7 @@
       _channel_store_error (self->data_channel, error);
       _channel_enqueue_task (self->data_channel, (ChannelTask) _close_procedure,
           NULL, NULL);
+      gst_message_unref (message);
       break;
     }
     default:
@@ -1106,6 +1107,7 @@
       (GstPadProbeCallback) on_appsrc_data, channel, NULL);
 
   channel->src_bin = webrtc_error_ignore_bin_new (channel, channel->appsrc);
+  gst_object_ref_sink (channel->src_bin);
 
   channel->appsink = gst_element_factory_make ("appsink", NULL);
   gst_object_ref_sink (channel->appsink);
@@ -1115,6 +1117,7 @@
       channel, NULL);
 
   channel->sink_bin = webrtc_error_ignore_bin_new (channel, channel->appsink);
+  gst_object_ref_sink (channel->sink_bin);
 
   gst_object_unref (pad);
   gst_caps_unref (caps);
@@ -1148,6 +1151,8 @@
 
   g_clear_object (&channel->appsrc);
   g_clear_object (&channel->appsink);
+  g_clear_object (&channel->src_bin);
+  g_clear_object (&channel->sink_bin);
 
   g_weak_ref_clear (&channel->webrtcbin_weak);

_service:download_files:gst-plugins-bad-1.28.2.tar.xz/gst-libs/gst/analytics/gstanalyticsobjectdetectionmtd.c -> _service:download_files:gst-plugins-bad-1.28.3.tar.xz/gst-libs/gst/analytics/gstanalyticsobjectdetectionmtd.c Changed

_service:download_files:gst-plugins-bad-1.28.2.tar.xz/gst-libs/gst/analytics/gstanalyticssegmentationmtd.c -> _service:download_files:gst-plugins-bad-1.28.3.tar.xz/gst-libs/gst/analytics/gstanalyticssegmentationmtd.c Changed

_service:download_files:gst-plugins-bad-1.28.2.tar.xz/gst-libs/gst/codecparsers/gsth265parser.c -> _service:download_files:gst-plugins-bad-1.28.3.tar.xz/gst-libs/gst/codecparsers/gsth265parser.c Changed

_service:download_files:gst-plugins-bad-1.28.2.tar.xz/gst-libs/gst/codecparsers/gsth265parser.h -> _service:download_files:gst-plugins-bad-1.28.3.tar.xz/gst-libs/gst/codecparsers/gsth265parser.h Changed

@@ -511,7 +511,7 @@
  * @temporal_id_plus1: A nal unit temporal identifier
  * @size: The size of the nal unit starting from @offset
  * @offset: The offset of the actual start of the nal unit
- * @sc_offset:The offset of the start code of the nal unit
+ * @sc_offset: The offset of the start code of the nal unit
  * @valid: If the nal unit is valid, which mean it has
  * already been parsed
  * @data: The data from which the Nalu has been parsed
@@ -558,18 +558,18 @@
  * @max_14bit_constraint_flag: used to define profile extensions, see Annex A
  * @level idc: indicate the level which the CVS confirms
  * @sub_layer_profile_present_flag: sublayer profile presence ind
- * @sub_layer_level_present_flag:sublayer level presence indicator.
+ * @sub_layer_level_present_flag: sublayer level presence indicator.
  * @sub_layer_profile_space: profile space for sublayers
  * @sub_layer_tier_flag: tier flags for sublayers.
  * @sub_layer_profile_idc: conformant profile indicator for sublayers.
  * @sub_layer_profile_compatibility_flag632: compatibility flags for sublayers
- * @sub_layer_progressive_source_flag:progressive stream indicator for sublayer
+ * @sub_layer_progressive_source_flag: progressive stream indicator for sublayer
  * @sub_layer_interlaced_source_flag: interlaced stream indicator for sublayer
  * @sub_layer_non_packed_constraint_flag: indicate the presence of
  *   frame packing arrangement sei message with in sublayers
- * @sub_layer_frame_only_constraint_flag:recognize the sublayer
+ * @sub_layer_frame_only_constraint_flag: recognize the sublayer
  *   specific field_seq_flag
- * @sub_layer_level_idc:indicate the sublayer specific level
+ * @sub_layer_level_idc: indicate the sublayer specific level
  *
  * Define ProfileTierLevel parameters
  */
@@ -614,7 +614,7 @@
 
 /**
  * GstH265SubLayerHRDParams:
- * @bit_rate_value_minus1:togeter with bit_rate_scale, it specifies
+ * @bit_rate_value_minus1: together with bit_rate_scale, it specifies
  *   the maximum input bitrate when the CPB operates at the access
  *   unit level
  * @cpb_size_value_minus1: is used together with cpb_size_scale to
@@ -670,7 +670,7 @@
  * @fixed_pic_rate_within_cvs_flag: same as fixed_pic_rate_general_flag
  * @elemental_duration_in_tc_minus1: temporal distance in clock ticks
  * @low_delay_hrd_flag: specifies the HRD operational mode
- * @cpb_cnt_minus1:specifies the number of alternative CPS specifications.
+ * @cpb_cnt_minus1: specifies the number of alternative CPB specifications.
  * @sublayer_hrd_params: Sublayer HRD parameters.
  *
  * Defines the HRD parameters
@@ -709,7 +709,7 @@
  * @base_layer_internal_flag and @base_layer_available_flag:
  *   specify availability of base layer
  * @max_layers_minus1: should be zero, but can be other values in future
- * @max_sub_layers_minus1:specifies the maximum number of temporal sub-layers
+ * @max_sub_layers_minus1: specifies the maximum number of temporal sub-layers
  * @temporal_id_nesting_flag: specifies whether inter prediction is
  *   additionally restricted
  * @profile_tier_level: ProfileTierLevel info

_service:download_files:gst-plugins-bad-1.28.2.tar.xz/gst-libs/gst/codecparsers/gsth266parser.c -> _service:download_files:gst-plugins-bad-1.28.3.tar.xz/gst-libs/gst/codecparsers/gsth266parser.c Changed

@@ -3761,6 +3761,11 @@
             guint16 slice_height_in_ctus;
 
             for (j = 0; j < pps->num_exp_slices_in_tilei; j++) {
+              if (i + j >= pps->num_slices_in_pic_minus1) {
+                GST_WARNING ("Too may slices %d", i + j + 1);
+                goto error;
+              }
+
               READ_UE_MAX (nr, pps->exp_slice_height_in_ctus_minus1ij,
                   pps->tile_row_height_minus1tile_y);
 
@@ -6128,6 +6133,18 @@
   return GST_H266_PARSER_ERROR;
 }
 
+// This is public API since 1.30
+static void
+gst_h266_sei_clear (GstH266SEIMessage * sei)
+{
+  if (sei->payloadType == GST_H266_SEI_REGISTERED_USER_DATA) {
+    GstH266RegisteredUserData *rud = &sei->payload.registered_user_data;
+    g_free ((guint8 *) rud->data);
+    rud->data = NULL;
+  }
+  memset (sei, 0, sizeof (GstH266SEIMessage));
+}
+
 /**
  * gst_h266_parser_parse_sei:
  * @parser: a #GstH266Parser
@@ -6154,6 +6171,7 @@
   nal_reader_init (&nr, nalu->data + nalu->offset + nalu->header_bytes,
       nalu->size - nalu->header_bytes);
   *messages = g_array_new (FALSE, FALSE, sizeof (GstH266SEIMessage));
+  g_array_set_clear_func (*messages, (GDestroyNotify) gst_h266_sei_clear);
 
   do {
     res = gst_h266_parser_parse_sei_message (&sei, &nr, nalparser, nalu->type,

_service:download_files:gst-plugins-bad-1.28.2.tar.xz/gst-libs/gst/mse/meson.build -> _service:download_files:gst-plugins-bad-1.28.3.tar.xz/gst-libs/gst/mse/meson.build Changed

_service:download_files:gst-plugins-bad-1.28.2.tar.xz/gst-libs/gst/vulkan/meson.build -> _service:download_files:gst-plugins-bad-1.28.3.tar.xz/gst-libs/gst/vulkan/meson.build Changed

@@ -116,21 +116,15 @@
 
 vulkan_plugin_kwargs = {}
 if host_system == 'darwin'
-  vulkan_dep = dependency('vulkan', method: 'pkg-config', required : false)
+  # Prefer direct MoltenVK linkage on Darwin instead of the Vulkan loader.
+  # This matches the framework packaging model and avoids depending on local
+  # ICD/loader setup when running the Vulkan plugin.
+  objcpp = meson.get_compiler('objcpp')
+  vulkan_dep = objcpp.find_library('MoltenVK', required: false)
   if not vulkan_dep.found()
-    # - ios does not support the loader/validation layers
-    # - We need to link directly to MoltenVK to be able to use
-    #   MoltenVK-specific functions that use dispatchable handles (like
-    #   retrieving the metal device from the VkDevice) which is currently waiting
-    #   on implementing a proper Metal extension for Vulkan
-    #   https://github.com/KhronosGroup/MoltenVK/issues/492
-    objcpp = meson.get_compiler('objcpp')
-    vulkan_dep = objcpp.find_library('MoltenVK', required: false)
-    if not vulkan_dep.found()
-      vulkan_dep = dependency('MoltenVK', fallback: 'moltenvk', required: vulkan_opt)
-      # We need this to find libMoltenVK.dylib when installed
-      vulkan_plugin_kwargs += {'install_rpath': '@loader_path/..'}
-    endif
+    vulkan_dep = dependency('MoltenVK', fallback: 'moltenvk', required: vulkan_opt)
+    # We need this to find libMoltenVK.dylib when installed
+    vulkan_plugin_kwargs += {'install_rpath': '@loader_path/..'}
   endif
 elif host_system == 'windows'
   vulkan_root = run_command(python3, '-c', 'import os; print(os.environ.get("VK_SDK_PATH"))', check: false).stdout().strip()

_service:download_files:gst-plugins-bad-1.28.2.tar.xz/gst-plugins-bad.doap -> _service:download_files:gst-plugins-bad-1.28.3.tar.xz/gst-plugins-bad.doap Changed

_service:download_files:gst-plugins-bad-1.28.2.tar.xz/gst/closedcaption/misc.h -> _service:download_files:gst-plugins-bad-1.28.3.tar.xz/gst/closedcaption/misc.h Changed

@@ -329,20 +329,20 @@
 #define debug3(hook, templ, args...)					\
 	VBI_CAT_LEVEL_LOG (GST_LEVEL_TRACE, NULL, templ , ##args)
 #elif defined(G_HAVE_ISO_VARARGS)
-#define error(hook, templ, ...)					\
-	VBI_CAT_LEVEL_LOG (GST_LEVEL_ERROR, NULL, templ, __VA_ARGS__)
-#define warn(hook, templ, ...)					\
-	VBI_CAT_LEVEL_LOG (GST_LEVEL_WARNING, NULL, templ, __VA_ARGS__)
-#define notice(hook, templ, ...)					\
-	VBI_CAT_LEVEL_LOG (GST_LEVEL_INFO, NULL, templ, __VA_ARGS__)
-#define info(hook, templ, ...)					\
-	VBI_CAT_LEVEL_LOG (GST_LEVEL_INFO, NULL, templ, __VA_ARGS__)
-#define debug1(hook, templ, ...)					\
-	VBI_CAT_LEVEL_LOG (GST_LEVEL_DEBUG, NULL, templ, __VA_ARGS__)
-#define debug2(hook, templ, ...)					\
-	VBI_CAT_LEVEL_LOG (GST_LEVEL_LOG, NULL, templ, __VA_ARGS__)
-#define debug3(hook, templ, ...)					\
-	VBI_CAT_LEVEL_LOG (GST_LEVEL_TRACE, NULL, templ, __VA_ARGS__)
+#define error(hook, ...)					\
+	VBI_CAT_LEVEL_LOG (GST_LEVEL_ERROR, NULL, __VA_ARGS__)
+#define warn(hook, ...)						\
+	VBI_CAT_LEVEL_LOG (GST_LEVEL_WARNING, NULL, __VA_ARGS__)
+#define notice(hook, ...)					\
+	VBI_CAT_LEVEL_LOG (GST_LEVEL_INFO, NULL, __VA_ARGS__)
+#define info(hook, ...)						\
+	VBI_CAT_LEVEL_LOG (GST_LEVEL_INFO, NULL, __VA_ARGS__)
+#define debug1(hook, ...)					\
+	VBI_CAT_LEVEL_LOG (GST_LEVEL_DEBUG, NULL, __VA_ARGS__)
+#define debug2(hook, ...)					\
+	VBI_CAT_LEVEL_LOG (GST_LEVEL_LOG, NULL, __VA_ARGS__)
+#define debug3(hook, ...)					\
+	VBI_CAT_LEVEL_LOG (GST_LEVEL_TRACE, NULL, __VA_ARGS__)
 #else
 /* if someone needs this, they can implement the inline functions for it */
 #error "variadic macros are required"

_service:download_files:gst-plugins-bad-1.28.2.tar.xz/gst/interlace/gstinterlace.c -> _service:download_files:gst-plugins-bad-1.28.3.tar.xz/gst/interlace/gstinterlace.c Changed

@@ -1005,25 +1005,18 @@
     icaps = gst_caps_merge (icaps, alternate);
   }
 
-  /* Drop framerate for sinkpad */
-  if (pad == interlace->sinkpad) {
+  if (pattern == GST_INTERLACE_PATTERN_1_1) {
+    icaps =
+        gst_interlace_caps_double_framerate (icaps, (pad == interlace->srcpad),
+        FALSE);
+  } else if (pattern != GST_INTERLACE_PATTERN_2_2) {
+    GST_FIXME_OBJECT (interlace,
+        "Add calculations for telecine framerate conversions");
     for (i = 0; i < gst_caps_get_size (icaps); ++i) {
       GstStructure *s = gst_caps_get_structure (icaps, i);
 
       gst_structure_remove_field (s, "framerate");
     }
-  } else {
-    if (pattern == GST_INTERLACE_PATTERN_1_1) {
-      icaps = gst_interlace_caps_double_framerate (icaps, TRUE, FALSE);
-    } else if (pattern != GST_INTERLACE_PATTERN_2_2) {
-      GST_FIXME_OBJECT (interlace,
-          "Add calculations for telecine framerate conversions");
-      for (i = 0; i < gst_caps_get_size (icaps); ++i) {
-        GstStructure *s = gst_caps_get_structure (icaps, i);
-
-        gst_structure_remove_field (s, "framerate");
-      }
-    }
   }
 
   if (clean_filter)

_service:download_files:gst-plugins-bad-1.28.2.tar.xz/gst/mpegdemux/gstmpegdemux.c -> _service:download_files:gst-plugins-bad-1.28.3.tar.xz/gst/mpegdemux/gstmpegdemux.c Changed

@@ -2554,16 +2554,17 @@
   guint32 scr1, scr2;
   guint64 scr;
   guint64 pts, dts;
-  guint32 code;
-  guint16 len;
+
   /* read the 4 bytes for the sync code */
-  code = GST_READ_UINT32_BE (data);
-  if (G_LIKELY (code != ID_PS_PACK_START_CODE))
+  if (end - data < 4)
     goto beach;
-  if (data + 12 > end)
+  if (G_LIKELY (GST_READ_UINT32_BE (data) != ID_PS_PACK_START_CODE))
     goto beach;
-  /* skip start code */
   data += 4;
+
+  if (end - data < 8)
+    goto beach;
+  /* skip start code */
   scr1 = GST_READ_UINT32_BE (data);
   scr2 = GST_READ_UINT32_BE (data + 4);
   /* start parsing the stream */
@@ -2591,7 +2592,7 @@
        to DTS/PTS, that also implies 1 tick rounding error */
     data += 6;
 
-    if (data + 4 > end)
+    if (end - data < 4)
       goto beach;
     /* PMR:22 ! :2==11 ! reserved:5 ! stuffing_len:3 */
     next32 = GST_READ_UINT32_BE (data);
@@ -2599,7 +2600,7 @@
       goto beach;
     stuffing_bytes = (next32 & 0x07);
     data += 4;
-    if (data + stuffing_bytes > end)
+    if (end - data < stuffing_bytes)
       goto beach;
     while (stuffing_bytes--) {
       if (*data++ != 0xff)
@@ -2627,17 +2628,17 @@
   }
 
   /* Possible optional System header here */
-  if (data + 8 > end)
+  if (end - data < 6)
     goto beach;
 
-  code = GST_READ_UINT32_BE (data);
-  len = GST_READ_UINT16_BE (data + 4);
+  guint32 code = GST_READ_UINT32_BE (data);
+  guint len = GST_READ_UINT16_BE (data + 4);
   if (code == ID_PS_SYSTEM_HEADER_START_CODE) {
     /* Found a system header, skip it */
     /* Check for sufficient data - system header, plus enough
      * left over for the PES packet header */
-    if (data + 6 + len + 6 > end)
-      return FALSE;
+    if (end - data < 6 + len + 6)
+      goto beach;
     data += len + 6;
     /* read the 4 bytes for the PES sync code */
     code = GST_READ_UINT32_BE (data);
@@ -2645,8 +2646,8 @@
   }
 
   /* Check we have enough data left for reading the PES packet */
-  if (data + 6 + len > end)
-    return FALSE;
+  if (end - data < 6 + len)
+    goto beach;
   if (!gst_ps_demux_is_pes_sync (code))
     goto beach;
   switch (code) {
@@ -2665,29 +2666,49 @@
 
   /* skip sync code and size */
   data += 6;
+  /* update end to the actual size of the PES packet */
+  end = data + len;
+
   pts = dts = -1;
   /* stuffing bits, first two bits are '10' for mpeg2 pes so this code is
    * not triggered. */
-  while (TRUE) {
+  while (data < end) {
     if (*data != 0xff)
       break;
     data++;
   }
+  if (data == end)
+    goto beach;
 
   /* STD buffer size, never for mpeg2 */
-  if ((*data & 0xc0) == 0x40)
+  if ((*data & 0xc0) == 0x40) {
+    if (end - data < 2)
+      goto beach;
     data += 2;
+  }
+
   /* PTS but no DTS, never for mpeg2 */
+  if (data == end)
+    goto beach;
   if ((*data & 0xf0) == 0x20) {
+    if (end - data < 5)
+      goto beach;
     READ_TS (data, pts, beach);
+    data += 5;
   }
   /* PTS and DTS, never for mpeg2 */
   else if ((*data & 0xf0) == 0x30) {
+    if (end - data < 10)
+      goto beach;
     READ_TS (data, pts, beach);
     READ_TS (data, dts, beach);
+    data += 10;
   } else if ((*data & 0xc0) == 0x80) {
+    guint8 flags;
+
+    if (end - data < 3)
+      goto beach;
     /* mpeg2 case */
-    guchar flags;
     /* 2: '10'
      * 2: PES_scrambling_control
      * 1: PES_priority
@@ -2695,9 +2716,8 @@
      * 1: copyright
      * 1: original_or_copy
      */
-    flags = *data++;
-    if ((flags & 0xc0) != 0x80)
-      goto beach;
+    data++;
+
     /* 2: PTS_DTS_flags
      * 1: ESCR_flag
      * 1: ES_rate_flag
@@ -2707,17 +2727,23 @@
      * 1: PES_extension_flag
      */
     flags = *data++;
-    /* 8: PES_header_data_length */
-    data++;
     /* only DTS: this is invalid */
     if ((flags & 0xc0) == 0x40)
       goto beach;
+
+    /* 8: PES_header_data_length */
+    data++;
+
     /* check for PTS */
     if ((flags & 0x80)) {
+      if (end - data < 5)
+        goto beach;
       READ_TS (data, pts, beach);
     }
     /* check for DTS */
     if ((flags & 0x40)) {
+      if (end - data < 5)
+        goto beach;
       READ_TS (data, dts, beach);
     }
   }

_service:download_files:gst-plugins-bad-1.28.2.tar.xz/gst/mpegdemux/gstpesfilter.c -> _service:download_files:gst-plugins-bad-1.28.3.tar.xz/gst/mpegdemux/gstpesfilter.c Changed

@@ -212,19 +212,16 @@
 
   /* stuffing bits, first two bits are '10' for mpeg2 pes so this code is
    * not triggered. */
-  while (TRUE) {
-    if (*data != 0xff)
-      break;
-
+  while (datalen > 0 && *data == 0xff) {
     data++;
     datalen--;
 
     GST_DEBUG ("got stuffing bit");
-
-    if (datalen < 1)
-      goto need_more_data;
   }
 
+  if (datalen < 1)
+    goto need_more_data;
+
   /* STD buffer size, never for mpeg2 */
   if ((*data & 0xc0) == 0x40) {
     GST_DEBUG ("have STD");
@@ -322,9 +319,10 @@
     }
     /* check for DTS */
     if ((flags & 0x40)) {
-      READ_TS (data, filter->dts, lost_sync);
       if (datalen < 5)
         goto need_more_data;
+
+      READ_TS (data, filter->dts, lost_sync);
       GST_DEBUG ("DTS found %" G_GUINT64_FORMAT, filter->dts);
       header_data_length -= 5;
       datalen -= 5;
@@ -345,10 +343,10 @@
       if (datalen < 3)
         goto need_more_data;
 
-      es_rate = ((guint32) (*data++ & 0x07)) << 14;
-      es_rate |= ((guint32) (*data++)) << 7;
-      es_rate |= ((guint32) (*data++ & 0xFE)) >> 1;
-      GST_DEBUG ("%x ES Rate found %u", filter->id, es_rate);
+      es_rate = GST_READ_UINT24_BE (data);
+      GST_DEBUG ("%x ES Rate found %u", filter->id,
+          ((es_rate >> 1) & 0x003fffff) * 50);
+      data += 3;
       header_data_length -= 3;
       datalen -= 3;
     }
@@ -388,37 +386,60 @@
     }
     /* additional_copy_info_flag  */
     if ((flags & 0x04)) {
+      if (datalen < 1)
+        goto need_more_data;
       GST_DEBUG ("%x additional copy info, flags 0x%02x", filter->id, *data);
+      data++;
+      header_data_length--;
+      datalen--;
     }
     /* PES_CRC_flag  */
     if ((flags & 0x02)) {
+      if (datalen < 2)
+        goto need_more_data;
       GST_DEBUG ("%x PES_CRC", filter->id);
+      data += 2;
+      header_data_length -= 2;
+      datalen -= 2;
     }
     /* PES_extension_flag  */
     if ((flags & 0x01)) {
+      if (datalen < 1)
+        goto need_more_data;
       flags = *data++;
-      header_data_length -= 1;
-      datalen -= 1;
+      header_data_length--;
+      datalen--;
       GST_DEBUG ("%x PES_extension, flags 0x%02x", filter->id, flags);
       /* PES_private_data_flag */
       if ((flags & 0x80)) {
         GST_DEBUG ("%x PES_private_data_flag", filter->id);
+        if (datalen < 16)
+          goto need_more_data;
         data += 16;
         header_data_length -= 16;
         datalen -= 16;
       }
       /* pack_header_field_flag */
       if ((flags & 0x40)) {
-        guint8 pack_field_length = *data;
+        guint8 pack_field_length;
+        if (datalen < 1)
+          goto need_more_data;
+        pack_field_length = *data++;
+        header_data_length--;
+        datalen--;
         GST_DEBUG ("%x pack_header_field_flag, pack_field_length %d",
             filter->id, pack_field_length);
-        data += pack_field_length + 1;
-        header_data_length -= pack_field_length + 1;
-        datalen -= pack_field_length + 1;
+        if (datalen < pack_field_length)
+          goto need_more_data;
+        data += pack_field_length;
+        header_data_length -= pack_field_length;
+        datalen -= pack_field_length;
       }
       /* program_packet_sequence_counter_flag */
       if ((flags & 0x20)) {
         GST_DEBUG ("%x program_packet_sequence_counter_flag", filter->id);
+        if (datalen < 2)
+          goto need_more_data;
         data += 2;
         header_data_length -= 2;
         datalen -= 2;
@@ -426,21 +447,30 @@
       /* P-STD_buffer_flag */
       if ((flags & 0x10)) {
         GST_DEBUG ("%x P-STD_buffer_flag", filter->id);
+        if (datalen < 2)
+          goto need_more_data;
         data += 2;
         header_data_length -= 2;
         datalen -= 2;
       }
       /* PES_extension_flag_2 */
       if ((flags & 0x01)) {
-        guint8 PES_extension_field_length = *data++;
+        guint8 PES_extension_field_length;
+        if (datalen < 1)
+          goto need_more_data;
+        PES_extension_field_length = *data++;
+        header_data_length--;
+        datalen--;
         GST_DEBUG ("%x PES_extension_flag_2, len %d",
             filter->id, PES_extension_field_length & 0x7f);
+        if (datalen < (PES_extension_field_length & 0x7f))
+          goto need_more_data;
         if (PES_extension_field_length == 0x81) {
           GST_DEBUG ("%x substream id 0x%02x", filter->id, *data);
         }
         data += PES_extension_field_length & 0x7f;
-        header_data_length -= (PES_extension_field_length & 0x7f) + 1;
-        datalen -= (PES_extension_field_length & 0x7f) + 1;
+        header_data_length -= PES_extension_field_length & 0x7f;
+        datalen -= PES_extension_field_length & 0x7f;
       }
     }
     /* calculate the amount of real data in this PES packet */

_service:download_files:gst-plugins-bad-1.28.2.tar.xz/gst/mpegtsdemux/mpegtsbase.c -> _service:download_files:gst-plugins-bad-1.28.3.tar.xz/gst/mpegtsdemux/mpegtsbase.c Changed

_service:download_files:gst-plugins-bad-1.28.2.tar.xz/gst/mpegtsdemux/mpegtspacketizer.c -> _service:download_files:gst-plugins-bad-1.28.3.tar.xz/gst/mpegtsdemux/mpegtspacketizer.c Changed

_service:download_files:gst-plugins-bad-1.28.2.tar.xz/gst/mpegtsdemux/pesparse.c -> _service:download_files:gst-plugins-bad-1.28.3.tar.xz/gst/mpegtsdemux/pesparse.c Changed

@@ -173,10 +173,20 @@
 
   if (flags & 0x20) {
     /* ESCR */
-    if (G_UNLIKELY (length < 5))
+    if (G_UNLIKELY (length < 6))
       goto need_more_data;
-    READ_TS (data, res->ESCR, bad_ESCR_value);
-    length -= 5;
+
+    guint32 escr1 = GST_READ_UINT32_BE (data);
+    guint16 escr2 = GST_READ_UINT16_BE (data + 4);
+    guint64 escr, escr_ext;
+
+    escr = ((guint64) escr1) << 1;
+    escr |= (escr2 & 0x8000) >> 15;
+    escr_ext = (escr2 & 0x01ff);
+    res->ESCR = escr * 300 + escr_ext % 300;
+
+    data += 6;
+    length -= 6;
 
     GST_LOG ("ESCR %" G_GUINT64_FORMAT " %" GST_TIME_FORMAT,
         res->ESCR, GST_TIME_ARGS (PCRTIME_TO_GSTTIME (res->ESCR)));
@@ -186,12 +196,12 @@
     /* ES_rate */
     if (G_UNLIKELY (length < 3))
       goto need_more_data;
-    val32 = GST_READ_UINT32_BE (data);
+    val32 = GST_READ_UINT24_BE (data);
     data += 3;
     length -= 3;
-    if (G_UNLIKELY ((val32 & 0x80000100) != 0x80000100))
+    if (G_UNLIKELY ((val32 & 0x00800001) != 0x00800001))
       goto bad_ES_rate;
-    res->ES_rate = ((val32 >> 9) & 0x003fffff) * 50;
+    res->ES_rate = ((val32 >> 1) & 0x003fffff) * 50;
     GST_LOG ("ES_rate : %d", res->ES_rate);
   }
 
@@ -421,10 +431,6 @@
   GST_WARNING ("bad DTS value");
   return PES_PARSING_BAD;
 
-bad_ESCR_value:
-  GST_WARNING ("bad ESCR value");
-  return PES_PARSING_BAD;
-
 bad_ES_rate:
   GST_WARNING ("Invalid ES_rate markers 0x%0x", val32);
   return PES_PARSING_BAD;

_service:download_files:gst-plugins-bad-1.28.2.tar.xz/gst/mpegtsdemux/tsdemux.c -> _service:download_files:gst-plugins-bad-1.28.3.tar.xz/gst/mpegtsdemux/tsdemux.c Changed

_service:download_files:gst-plugins-bad-1.28.2.tar.xz/gst/mxf/mxfaes-bwf.c -> _service:download_files:gst-plugins-bad-1.28.3.tar.xz/gst/mxf/mxfaes-bwf.c Changed

_service:download_files:gst-plugins-bad-1.28.2.tar.xz/gst/mxf/mxfdemux.c -> _service:download_files:gst-plugins-bad-1.28.3.tar.xz/gst/mxf/mxfdemux.c Changed

_service:download_files:gst-plugins-bad-1.28.2.tar.xz/gst/mxf/mxfvanc.c -> _service:download_files:gst-plugins-bad-1.28.3.tar.xz/gst/mxf/mxfvanc.c Changed

@@ -140,30 +140,31 @@
   gst_bit_writer_put_bits_uint16 (writer, data_count, 10);
 }
 
-static GstBuffer *
-mxf_vanc_to_st2038 (const guint8 * vanc_data, gsize vanc_data_size,
-    guint16 line_number, guint16 payload_sample_count,
-    guint8 payload_sample_coding, guint32 array_count, guint32 array_item_size)
+static void
+mxf_vanc_to_st2038 (GstByteWriter * writer, const guint8 * vanc_data,
+    gsize vanc_data_size, guint16 line_number, guint16 payload_sample_count,
+    guint8 payload_sample_coding)
 {
-  GstBitWriter writer;
-  GstBitReader bit_reader;
-  GstByteReader byte_reader;
+  GstBitWriter bit_writer;
   guint16 checksum, did, sdid, data_count;
   guint8 c_not_y_channel_flag, *data;
   gboolean payload_10bit;
   gsize size;
   guint i;
+  guint8 tmp_data64 + 256 * 2 = { 0, };
 
   c_not_y_channel_flag = get_c_not_y_channel_flag (payload_sample_coding);
   payload_10bit = is_payload_10bit (payload_sample_coding);
 
   if (payload_10bit) {
+    GstBitReader bit_reader;
+
     gst_bit_reader_init (&bit_reader, vanc_data, vanc_data_size);
 
     /* Check if we can read DID, SDID and Data Count */
     if (gst_bit_reader_get_remaining (&bit_reader) < 32) {
       GST_WARNING ("Insufficient VANC data");
-      return NULL;
+      return;
     }
 
     /* See section 5.4.4 of ST-436 on 10-bit sample coding */
@@ -174,14 +175,15 @@
     /* Skip 2-bit padding */
     gst_bit_reader_skip (&bit_reader, 2);
 
-    if (payload_sample_count - 3 < data_count) {
+    if (payload_sample_count - 3 < (data_count & 0xFF)) {
       GST_WARNING ("Insufficient user data words");
-      return NULL;
+      return;
     }
 
-    gst_bit_writer_init_with_size (&writer, 64 + data_count * 2, FALSE);
-    write_st2038_header (&writer, c_not_y_channel_flag, line_number, did, sdid,
-        data_count);
+    gst_bit_writer_init_with_data (&bit_writer, tmp_data,
+        64 + (data_count & 0xFF) * 2, FALSE);
+    write_st2038_header (&bit_writer, c_not_y_channel_flag, line_number, did,
+        sdid, data_count);
 
     /*
      * See Section 6.7 of ST-291 on Checksum Word.
@@ -192,7 +194,7 @@
      * significant bits of the DID, SDID, DC and UDW.
      */
     checksum = (did & 0x1FF) + (sdid & 0x1FF) + (data_count & 0x1FF);
-    for (i = 0; i < data_count; i++) {
+    for (i = 0; i < (data_count & 0xFF); i++) {
       /*
        * For a 10-bit coding, 4 bytes representing 3 source samples
        * are coded using the high-order 30-bits (bits 2 to 31) of a
@@ -200,23 +202,32 @@
        * bits of the payload data 32-bit word (bits 0 and 1) are set
        * to zero.
        */
-      guint16 udw = gst_bit_reader_get_bits_uint16_unchecked (&bit_reader, 10);
+      guint16 udw;
+      if (!gst_bit_reader_get_bits_uint16 (&bit_reader, &udw, 10)) {
+        GST_WARNING ("Insufficient data available");
+        return;
+      }
       checksum += (udw & 0x1FF);
-      gst_bit_writer_put_bits_uint16 (&writer, udw, 10);
+      gst_bit_writer_put_bits_uint16 (&bit_writer, udw, 10);
 
       if (i % 3 == 2) {
-        gst_bit_reader_skip (&bit_reader, 2);
+        if (!gst_bit_reader_skip (&bit_reader, 2)) {
+          GST_WARNING ("Insufficient data available");
+          return;
+        }
       }
     }
 
-    gst_bit_writer_put_bits_uint16 (&writer, checksum & 0x1FF, 10);
+    gst_bit_writer_put_bits_uint16 (&bit_writer, checksum & 0x1FF, 10);
   } else {
+    GstByteReader byte_reader;
+
     gst_byte_reader_init (&byte_reader, vanc_data, vanc_data_size);
 
     /* Check if we can read DID, SDID and Data Count */
     if (gst_byte_reader_get_remaining (&byte_reader) < 3) {
       GST_WARNING ("Insufficient VANC data");
-      return NULL;
+      return;
     }
 
     did = gst_byte_reader_get_uint8_unchecked (&byte_reader);
@@ -225,11 +236,12 @@
 
     if (payload_sample_count - 3 < data_count) {
       GST_WARNING ("Insufficient user data words");
-      return NULL;
+      return;
     }
 
-    gst_bit_writer_init_with_size (&writer, 64 + data_count * 2, FALSE);
-    write_st2038_header (&writer, c_not_y_channel_flag, line_number,
+    gst_bit_writer_init_with_data (&bit_writer, tmp_data, 64 + data_count * 2,
+        FALSE);
+    write_st2038_header (&bit_writer, c_not_y_channel_flag, line_number,
         with_parity (did), with_parity (sdid), with_parity (data_count));
 
     /*
@@ -238,20 +250,25 @@
      */
     checksum = did + sdid + data_count;
     for (i = 0; i < data_count; i++) {
-      guint8 udw = gst_byte_reader_get_uint8_unchecked (&byte_reader);
+      guint8 udw;
+      if (!gst_byte_reader_get_uint8 (&byte_reader, &udw)) {
+        GST_WARNING ("Insufficient data available");
+        return;
+      }
       checksum += udw;
-      gst_bit_writer_put_bits_uint16 (&writer, with_parity (udw), 10);
+      gst_bit_writer_put_bits_uint16 (&bit_writer, with_parity (udw), 10);
     }
 
-    gst_bit_writer_put_bits_uint16 (&writer, with_parity (checksum & 0xFF), 10);
+    gst_bit_writer_put_bits_uint16 (&bit_writer, with_parity (checksum & 0xFF),
+        10);
   }
 
-  gst_bit_writer_align_bytes (&writer, 1);
+  gst_bit_writer_align_bytes (&bit_writer, 1);
 
-  size = gst_bit_writer_get_size (&writer) / 8;
-  data = gst_bit_writer_reset_and_get_data (&writer);
+  size = gst_bit_writer_get_size (&bit_writer) / 8;
+  data = gst_bit_writer_get_data (&bit_writer);
 
-  return gst_buffer_new_wrapped (data, size);
+  gst_byte_writer_put_data (writer, data, size);
 }
 
 static GstFlowReturn
@@ -264,6 +281,9 @@
   GstByteReader reader;
   GstFlowReturn ret = GST_FLOW_ERROR;
   guint16 num_packets, i;
+  GstByteWriter writer;
+
+  gst_byte_writer_init (&writer);
 
   /* SMPTE 436M 6.1 */
   if (key->u12 != 0x17 || key->u14 != 0x02) {
@@ -314,7 +334,7 @@
     guint8 did, sdid;
     guint8 cdp_size;
 
-    if (gst_byte_reader_get_remaining (&reader) < 16)
+    if (gst_byte_reader_get_remaining (&reader) < 14)
       goto out;
 
     line_num = gst_byte_reader_get_uint16_be_unchecked (&reader);
@@ -325,24 +345,31 @@
     array_count = gst_byte_reader_get_uint32_be_unchecked (&reader);
     array_item_size = gst_byte_reader_get_uint32_be_unchecked (&reader);
 
+    if (array_item_size != 1) {
+      if (!gst_byte_reader_skip (&reader, array_count * array_item_size))
+        goto out;
+      continue;
+    }
+
     if (!HANDLE_AS_ST2038) {
       /* Skip over anything that is not 8 bit VANC */
       if (payload_sample_coding != 4 && payload_sample_coding != 5
           && payload_sample_coding != 6) {
-        if (!gst_byte_reader_skip (&reader, array_count * array_item_size))
+        if (!gst_byte_reader_skip (&reader, array_count))
           goto out;
         continue;
       }
     }
 
-    if (gst_byte_reader_get_remaining (&reader) < array_count * array_item_size)
+    if (gst_byte_reader_get_remaining (&reader) < array_count)
       goto out;
 
     if (gst_byte_reader_get_remaining (&reader) < payload_sample_count)
       goto out;
 
-    if (payload_sample_count < 2) {
-      if (!gst_byte_reader_skip (&reader, array_count * array_item_size))
+    // DID, SDID and CDP size
+    if (payload_sample_count < 3) {
+      if (!gst_byte_reader_skip (&reader, array_count))
         goto out;
       continue;
     }
@@ -355,41 +382,44 @@
       /* Not S334 EIA-708 */
       if (did != 0x61 && sdid != 0x01) {
         GST_TRACE ("Skipping VANC data with DID/SDID 0x%02X/0x%02X", did, sdid);
-        if (!gst_byte_reader_skip (&reader, array_count * array_item_size - 2))
+        if (!gst_byte_reader_skip (&reader, array_count - 2))
           goto out;
         continue;
       }
 
       cdp_size = gst_byte_reader_get_uint8_unchecked (&reader);
       if (payload_sample_count - 3 < cdp_size) {
-        if (!gst_byte_reader_skip (&reader, array_count * array_item_size - 3))
+        if (!gst_byte_reader_skip (&reader, array_count - 3))
+          goto out;
+        continue;
+      }
+      if (gst_byte_reader_get_remaining (&reader) < cdp_size) {
+        if (!gst_byte_reader_skip (&reader, array_count - 3))
           goto out;
         continue;
       }
 
-      gst_buffer_unmap (buffer, &map);
-      *outbuf =
-          gst_buffer_copy_region (buffer, GST_BUFFER_COPY_ALL,
-          gst_byte_reader_get_pos (&reader), cdp_size);
-      gst_buffer_unref (buffer);
+      gst_byte_writer_put_data (&writer,
+          gst_byte_reader_get_data_unchecked (&reader, cdp_size), cdp_size);
     } else {
       gsize byte_pos = gst_byte_reader_get_pos (&reader);
-      gsize vanc_data_size = gst_byte_reader_get_remaining (&reader);
 
       /* Convert from ST-436M to ST-2038 */
-      *outbuf = mxf_vanc_to_st2038 (&map.databyte_pos, vanc_data_size,
-          line_num, payload_sample_count, payload_sample_coding,
-          array_count, array_item_size);
-      if (!outbuf)
-        goto no_data;
-
-      gst_buffer_unmap (buffer, &map);
-      gst_buffer_unref (buffer);
-    }
+      mxf_vanc_to_st2038 (&writer, &map.databyte_pos, array_count,
+          line_num, payload_sample_count, payload_sample_coding);
 
-    return GST_FLOW_OK;
+      if (!gst_byte_reader_skip (&reader, array_count))
+        goto out;
+    }
   }
 
+  *outbuf = gst_byte_writer_reset_and_get_buffer (&writer);
+
+  gst_buffer_unmap (buffer, &map);
+  gst_buffer_unref (buffer);
+
+  return GST_FLOW_OK;
+
 no_data:
 
   /* No packets or we skipped over all packets */
@@ -398,6 +428,7 @@
   ret = GST_FLOW_OK;
 
 out:
+  gst_byte_writer_reset (&writer);
   gst_buffer_unmap (buffer, &map);
   gst_buffer_unref (buffer);
 
@@ -656,10 +687,10 @@
       break;
 
     /*
-     * Each ANC packet in ST 436M needs:
-     * 2 bytes DID/SDID + 1 byte DC + data_count bytes + 1 checksum byte
+     * Each ANC packet in ST 436M needs 14 bytes plus the byte array of the
+     * actual ANC packet rounded up to a multiple of 4.
      */
-    guint packet_size = 4 + header.data_count;
+    guint packet_size = 14 + GST_ROUND_UP_4 (4 + header.data_count);
     total_anc_size += packet_size;
     num_anc_structures++;
 
@@ -675,9 +706,9 @@
 
   /*
    * Calculate total ST 436M wrapper size:
-   * 16 bytes base header + 4 bytes array count + total ANC data
+   * 2 bytes number of ANC structures + total ANC data size
    */
-  size = 20 + total_anc_size;
+  size = 2 + total_anc_size;
 
   gst_byte_writer_init_with_size (&writer, size, TRUE);
 
@@ -714,14 +745,15 @@
       gst_byte_writer_put_uint8_unchecked (&writer, 4); /* Payload Sample Coding */
     }
 
-    gst_byte_writer_put_uint16_be_unchecked (&writer, total_anc_size);  /* Payload Sample Count */
+    gst_byte_writer_put_uint16_be_unchecked (&writer, 4 + header.data_count);   /* Payload Sample Count */
 
     /*
      * See Section 4.3 of ST-377 on Compound Data Types.
      * First 4 bytes define the number of elements in the array.
      * Last 4 bytes define the length of each element.
      */
-    gst_byte_writer_put_uint32_be_unchecked (&writer, total_anc_size);
+    gst_byte_writer_put_uint32_be_unchecked (&writer,
+        GST_ROUND_UP_4 (4 + header.data_count));
     gst_byte_writer_put_uint32_be_unchecked (&writer, 1);
 
     did_sdid = (header.did << 8) | header.sdid;
@@ -745,6 +777,7 @@
     offset += header.len_bytes;
   }
 
+  g_assert (gst_byte_writer_get_pos (&writer) == size);
   data = gst_byte_writer_reset_and_get_data (&writer);
 
   gst_buffer_unmap (buffer, &map);

_service:download_files:gst-plugins-bad-1.28.2.tar.xz/gst/videoparsers/gstav1parse.c -> _service:download_files:gst-plugins-bad-1.28.3.tar.xz/gst/videoparsers/gstav1parse.c Changed

_service:download_files:gst-plugins-bad-1.28.2.tar.xz/gst/videoparsers/gsth263parse.c -> _service:download_files:gst-plugins-bad-1.28.3.tar.xz/gst/videoparsers/gsth263parse.c Changed

_service:download_files:gst-plugins-bad-1.28.2.tar.xz/gst/videoparsers/gstpngparse.c -> _service:download_files:gst-plugins-bad-1.28.3.tar.xz/gst/videoparsers/gstpngparse.c Changed

_service:download_files:gst-plugins-bad-1.28.2.tar.xz/gst/videoparsers/h263parse.c -> _service:download_files:gst-plugins-bad-1.28.3.tar.xz/gst/videoparsers/h263parse.c Changed

_service:download_files:gst-plugins-bad-1.28.2.tar.xz/meson.build -> _service:download_files:gst-plugins-bad-1.28.3.tar.xz/meson.build Changed

_service:download_files:gst-plugins-bad-1.28.2.tar.xz/po/gst-plugins-bad-1.0.pot -> _service:download_files:gst-plugins-bad-1.28.3.tar.xz/po/gst-plugins-bad-1.0.pot Changed

_service:download_files:gst-plugins-bad-1.28.2.tar.xz/po/gst-plugins-bad.pot -> _service:download_files:gst-plugins-bad-1.28.3.tar.xz/po/gst-plugins-bad.pot Changed

_service:download_files:gst-plugins-bad-1.28.2.tar.xz/release-notes-1.28.md -> _service:download_files:gst-plugins-bad-1.28.3.tar.xz/release-notes-1.28.md Changed

@@ -2,11 +2,11 @@
 
 GStreamer 1.28.0 was originally released on 27 January 2026.
 
-The latest bug-fix release in the stable 1.28 series is 1.28.2(#1.28.2) and was released on 07 April 2026.
+The latest bug-fix release in the stable 1.28 series is 1.28.3(#1.28.3) and was released on 11 May 2026.
 
 See https://gstreamer.freedesktop.org/releases/1.28/latest for the latest version of this document.
 
-*Last updated: Tuesday 07 April 2026, 12:30 UTC (log)gitlog*
+*Last updated: Monday 11 May 2026, 16:00 UTC (log)gitlog*
 
 latest: https://gstreamer.freedesktop.org/releases/1.28/
 gitlog: https://gitlab.freedesktop.org/gstreamer/www/commits/main/src/htdocs/releases/1.28/release-notes-1.28.md
@@ -1942,7 +1942,251 @@
 #### List of merge requests and issues fixed in 1.28.2
 
 - List of Merge Requests applied in 1.28.2(https://gitlab.freedesktop.org/groups/gstreamer/-/merge_requests?scope=all&utf8=%E2%9C%93&state=merged&milestone_title=1.28.2)
-- List of Issues fixed in 1.28.2(https://gitlab.freedesktop.org/groups/gstreamer/-/issues?scope=all&utf8=%E2%9C%93&state=closed&milestone_title=1.28.2)
+- List of Issues fixed in 1.28.2(https://gitlab.freedesktop.org/groups/gstreamer/-/work_items?sort=created_date&state=closed&milestone_title=1.28.2)
+
+<a id="1.28.3"></a>
+
+### 1.28.3
+
+The third 1.28 bug-fix release (1.28.3) was released on 11 May 2026.
+
+This release only contains bugfixes and important security fixessecurity.
+It *should* be safe to update from 1.28.x and we recommend you do so at your
+earliest convenience.
+
+security: https://gstreamer.freedesktop.org/security/
+
+#### Highlighted bugfixes in 1.28.3
+
+ - Various security fixessecurity and playback fixes
+ - applemedia: vtdec stability, MoltenVK integration and planar video format handling fixes
+ - audioresample: Fix regression on armv7hf
+ - bpmdetect: Fixes for stereo and multi-channel modes
+ - devicemonitor: wait for start thread to finish when listing devices so all the info is there for e.g. v4l2 provider
+ - fallbacksrc: Add fallback-source and enable-dummy properties
+ - nvidia: fix cudaconvert performance regression and nvdec device creation regression
+ - opengl: add GBRA swizzle support, and fix glcolorconvert vertical flip issue on crop
+ - rtspsrc: include user-agent property in HTTP tunnel requests and fix mikey regression
+ - threadshare: add leaky mode to dataqueue-based elements
+ - v4l2: fix negotiation error when trying to force stateful decoders to output dmabufs
+ - webrtcsink: Add support imx8mp vpuenc_hevc hardware H.265 encoder
+ - cerbero: Extend gst-plugins-rs melding to Darwin platforms for smaller binary sizes and static linking improvements
+ - inno Windows installer fixes, including silent install mode via the command line
+ - macOS: provide script to allow uninstalling the package; relocate absolute paths to Python.framework in wheels
+ - Various bug fixes, build fixes, memory leak fixes, and other stability and reliability improvements
+
+#### gstreamer
+
+ - pad: fix potential buffer leak in get_range_failed error handler(https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11284)
+ - aggregator: Fix documentation(https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11488)
+ - allocator: Use g_try_malloc() instead of g_malloc() for sysmem(https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11569)
+ - baseparse: Fix memory leak when subclass returns error(https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11567)
+ - bitwriter: Allow unsetting set bits when overwriting them(https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11471)
+ - devicemonitor: Wait for start thread to finish when listing devices(https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11554)
+ - streams: Add METADATA to the valid stream flags for serialization(https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11566)
+ - value: On buffer deserialization errors first unmap the buffer and then unref it(https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11590)
+ - gst-inspect-1.0: type for string caps fields should be 'string' not 'gchararray'(https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11460)
+
+#### gst-plugins-base
+
+ - appsink, appsrc: Allow passing NULL callbacks(https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11431)
+ - appsrc: Fix dropped counting with bufferlist(https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11312)
+ - audioaggregator: Don't drop pending input buffers on sinkpads on srcpad caps changes(https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11483)
+ - audioaggregator: Don't reset samples_per_buffer unless sample rate / output-buffer-duration has changed(https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11487)
+ - audioaggregator: Don't try converting buffers on caps changes if impossible(https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11479)
+ - audioresample: Fix extra samples produced at speech-to-silence transitions(https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11439)
+ - audio-resampler-neon: fix Thumb encoding and use Clang O2 calculation for strides(https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11491)
+ - audio sounds strange on release 1.28.2 for armv7hf(https://gitlab.freedesktop.org/gstreamer/gstreamer/-/work_items/5075)
+ - decodebin2: fix leak of endpads list on shutdown while exposing(https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11470)
+ - discoverer: Take the DISCO_LOCK while parsing stream topology(https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11539)
+ - exiftag: Use a hashtable instead of a linked list for storing the pending tags(https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11364)
+ - gl: add GBRA swizzle support(https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11422)
+ - id3v2: Add input validation and refactor id3v2_ununsync_data(https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11320)
+ - id3v2: Check valid frame sizes more(https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11380)
+ - opengl: Fix glcolorconvert vertical flip issue on crop(https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11413)
+ - glcolorconvert: GBRA input hits unreachable swizzle path(https://gitlab.freedesktop.org/gstreamer/gstreamer/-/work_items/5060)
+ - subparse / samiparse: Various robustness fixes and minor other fixes.(https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11362)
+ - subparse: Fix memory leakage for text colour and background colour(https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11359)
+ - subparse: O(N^2) complexity in SAMI parser causes timeout with crafted large input(https://gitlab.freedesktop.org/gstreamer/gstreamer/-/work_items/5046)
+ - tag: Prevent ubsan and wrong fraction usage(https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11293)
+ - tag: Off-by-one checking for id3v2 unnsync tag parsing(https://gitlab.freedesktop.org/gstreamer/gstreamer/-/work_items/5049)
+ - video: add precondition check on dma helpers(https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11451)
+ - videodmabufpool: Break ref cycle between the pool and its thread(https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11337)
+ 
+#### gst-plugins-good
+
+ - adaptivedemux/hlsdemux assertions / fixes(https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11572)
+ - avidemux: Fix divide by zero if VPRP contains fields==0(https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11305)
+ - avidemux: Divide-by-Zero in vprp parser(https://gitlab.freedesktop.org/gstreamer/gstreamer/-/work_items/5027)
+ - isomp4: Fix memory leak when file is corrupted(https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11564)
+ - isomp4: qtdemux: Add bounds checks for ESDS descriptors(https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11382)
+ - matroska: Fix wrong object type bug(https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11561)
+ - qml6glsink: Fix redraw issues on buffer change(https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11338)
+ - qtdemux: Check for minimum stride requirements and width/height constraints with uncompressed video(https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11591)
+ - rtspsrc: mki is optional upon crypto update(https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11448)
+ - rtspsrc: mikey without mki failure(https://gitlab.freedesktop.org/gstreamer/gstreamer/-/work_items/5050)
+ - rtspsrc: include user-agent property in HTTP tunnel requests(https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11286)
+ - v4l2: object: Fix caps filtering in caps negotiation(https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11288)
+ - v4l2transform: release input buffers earlier(https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11368)
+ - wavparse: Remove assertion about upstream file size(https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11506)
+ - wavparse: recover from invalid av_bps instead of failing(https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11331)
+ - wavparse: Assert and execute an integer overflow on invalid duration(https://gitlab.freedesktop.org/gstreamer/gstreamer/-/work_items/5077)
+ - Require C std gnu11 or c11, remove custom 'restrict' definition, fixing build with Qt 6.11(https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11563)
+
+#### gst-plugins-bad
+
+ - ajasink: Correctly set reference source(https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11309)
+ - analytics: fix meta transform function for copy cases(https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11476)
+ - android: an AMC video decoder is always found, fix decoding of constrained-baseline files(https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11551)
+ - androidmedia: Free element name after use for logging(https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11573)
+ - applemedia: Don't expose unsupported formats for Vulkan/GL(https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11498)
+ - applemedia: Fix MoltenVK usage with vtdec-imported textures(https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11285)
+ - applemedia: Fix test instability and nofork issues(https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11461)
+ - applemedia: Require Xcode 12.4 for all builds(https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11369)
+ - applemedia: fix planar CoreVideo buffer plane offsets(https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11432)
+ - applemedia: Unable to build on MacOS 12 1.28.1(https://gitlab.freedesktop.org/gstreamer/gstreamer/-/work_items/4941)
+ - av1parse: Fix null pointer deference(https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11529)
+ - bpmdetect: Fix calculation of number of samples for >1 channels(https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11297)
+ - codecparsers: Stack Buffer Overflow in H.265 Buffering Period SEI Parser(https://gitlab.freedesktop.org/gstreamer/gstreamer/-/work_items/5036)
+ - cudaconvert: fix performance regression caused by double precision floating point constants(https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11400)
+ - decklink: Fix various refcount issues and related leaks(https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11558)
+ - h263parse: Fix wrong ratio masking(https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11537)
+ - h263parse: Missing handling of reserved invalid EPAR_D value(https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11535)
+ - h265parser: use sub-layer 0 CPB count in buffering_period SEI loops(https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11339)
+ - h266parser: Add missing clearing function for H266 SEI message(https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11571)
+ - h266parser: Avoid out-of-bounds write when parsing PPS tile slices(https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11588)
+ - mpegdemux: Add various bounds checks related to PES header parsing(https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11587)
+ - interlace: Revert "Drop framerate from query caps of sinkpad"(https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11428)
+ - mpegtsdemux: Various fixes(https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11454)
+ - mpegtspacketizer: Avoid potential overflow(https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11307)
+ - mse: Also disable the library if the meson option is disabled(https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11473)
+ - mxf: Fix multiple writing / parsing issues when handling VANC packets(https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11592)
+ - mxfdemux: Fix reverse temporal offsets array upper bounds check(https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11589)
+ - mxfmux: aes-bwf: Use correct size when serializing user data / channel status mode(https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11345)
+ - mxf: Theoretical heap Buffer Overflow in MXF AES3 Audio Descriptor write_tags(https://gitlab.freedesktop.org/gstreamer/gstreamer/-/work_items/5037)
+ - nvcodec: Fix missing adapter-luid when loading decoders(https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11329)
+ - nvdec regression in 1.28.2: "Couldn't create new device with adapter luid 0"(https://gitlab.freedesktop.org/gstreamer/gstreamer/-/work_items/5031)
+ - pngparse: Fix Use-after-free bug(https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11531)
+ - qml6d3d11sink: Clear texture on Paused-to-Ready transition(https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11520)
+ - qt6d3d11: fix null check in SetForceAspectRatio()(https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11575)
+ - tsdemux: Fix parsing of PES ESCR and following PES header fields(https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11324)
+ - tsdemux: Fix segfault when trying to handle SCTE-35 with incorrect program specified(https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11294)
+ - va: do not post error message when push fails(https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11504)
+ - vkupload/vkdownload: Fix possible corrupted image due to mismatched stride/padding(https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11387)
+ - vtdec: Avoid blocking decoder output callback(https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11430)
+ - vtdec: Avoid locking up during a decoder reset(https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11395)
+ - vtdec: deadlock when restarting pipeline(https://gitlab.freedesktop.org/gstreamer/gstreamer/-/work_items/5029)
+ - vtdec: fix deadlock when restarting pipeline(https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11343)
+ - webrtc: take ownership of src_bin and sink_bin and don't leak error message(https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11420)
+ - Require C std gnu11 or c11, remove custom 'restrict' definition, fixing build with Qt 6.11(https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11563)
+
+#### gst-plugins-ugly
+
+ - No changes
+
+#### GStreamer Rust plugins
+
+ - fallbacksrc: Add fallback-source and enable-dummy properties(https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/3017)
+ - isobmff: Change caps updates in test to not be delayed(https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/3041)
+ - quinn: Disable tests which were flaky(https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/3030)
+ - quinnwtsrc/sink: Fix session close(https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/3034)
+ - rtpbin2: examples: fix audio resyncs, stream offsets and frame drops(https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/3029)
+ - rtprecv: extend jitter accounted for(https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/3019)
+ - threadshare: add leaky mode to dataqueue-based elements(https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/3036)
+ - tracers: feature gate remaining PluginAPIFlags makers behind doc(https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/3013)
+ - webrtcsink: actually allow custom signaller to be set(https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/3043)
+ - webrtcsink: Adding imx8mp vpuenc_hevc support for 265(https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/3044)
+ - Switch from `std::os::raw` to `std::ffi` for C types(https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/3011)
+ - Update dependencies(https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/3021)
+ - all: address clippy 1.95.0 suggestions(https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/3037)
+ - Fix new 1.95 clippy warnings(https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/3048)
+
+#### gst-libav
+
+ - No changes
+
+#### gst-rtsp-server
+
+ - No changes
+
+#### gstreamer-sharp
+
+ - No changes
+
+#### gst-python
+
+ - No changes
+
+#### gst-editing-services
+
+ - Plug memory leaks reported running valgrind on our testsuite(https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11284)
+ - Fix use-after-free in GESUriSource decodebin callbacks(https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11375)
+ - Fix use-after-free in structured-interface and asset cache(https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11349)
+
+#### gst-devtools, gst-validate + gst-integration-testsuites
+
+ - Plug memory leaks reported running valgrind on our testsuite(https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11284)
+
+#### gst-examples
+
+ - No changes
+
+#### gstreamer-docs
+
+ - android: trim tutorials by using fewer plugins, ensure that an AMC video decoder is always found, fix decoding of constrained-baseline files(https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11551)
+
+#### Development build environment
+
+ - Add AGENTS.md file to let agents know what the participation rules are(https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11475)
+ - libffi.wrap, proxy-libintl.wrap: switch to wrap-file, g-i: add support for wrap-file libffi/libintl(https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11444)
+
+#### Cerbero build tool and packaging changes in 1.28.3
+
+ - cerbero: Fix entering into the build environment, add explicit non-interactive mode(https://gitlab.freedesktop.org/gstreamer/cerbero/-/merge_requests/2199)
+ - cerbero: Fix invalid target_subsystem when targeting Android on macOS(https://gitlab.freedesktop.org/gstreamer/cerbero/-/merge_requests/2209)
+ - cerbero: Fixes for background build setup(https://gitlab.freedesktop.org/gstreamer/cerbero/-/merge_requests/2201)
+ - cerbero: Fixes for background mode on macOS(https://gitlab.freedesktop.org/gstreamer/cerbero/-/merge_requests/2183)
+ - cerbero: Support differently named Xcode for iOS and tvOS builds(https://gitlab.freedesktop.org/gstreamer/cerbero/-/merge_requests/2212)
+ - cmake: Fix destination for the Java plugin initializers(https://gitlab.freedesktop.org/gstreamer/cerbero/-/merge_requests/2241)
+ - gst-plugins-rs: Extend melding to Darwin platforms(https://gitlab.freedesktop.org/gstreamer/cerbero/-/merge_requests/2202)
+ - gst-plugins-rs: fix MSVC link errors for cargo binary consumers(https://gitlab.freedesktop.org/gstreamer/cerbero/-/merge_requests/2237)
+ - libffi.recipe: Update to latest 3.2.9999.5 release, update proxy-libintl to 0.5(https://gitlab.freedesktop.org/gstreamer/cerbero/-/merge_requests/2210)
+ - libproxy: add backend, gio module and add to gstreamer-1.0-net.package(https://gitlab.freedesktop.org/gstreamer/cerbero/-/merge_requests/2213)
+ - osxrelocator: relocate absolute paths to Python.framework(https://gitlab.freedesktop.org/gstreamer/cerbero/-/merge_requests/2211)
+ - srt: update to 1.5.5(https://gitlab.freedesktop.org/gstreamer/cerbero/-/merge_requests/2219)
+ - vvdec: upgrade to 3.1.0(https://gitlab.freedesktop.org/gstreamer/cerbero/-/merge_requests/2214)
+ - wheels: rename and placehold the msvc runtime wheel(https://gitlab.freedesktop.org/gstreamer/cerbero/-/merge_requests/2222)
+ - wheels must have static dependency metadata, no conditional dep on gstreamer-msvc-runtime(https://gitlab.freedesktop.org/gstreamer/cerbero/-/work_items/573)
+ - wheels: Version number needs to follow PEP 440(https://gitlab.freedesktop.org/gstreamer/cerbero/-/merge_requests/2223)
+ - gstreamer_python: hardcoded path for libgstpython.dylib(https://gitlab.freedesktop.org/gstreamer/cerbero/-/work_items/577)
+ - inno: do not automatically create envvars or Registry keys with portable mode enabled(https://gitlab.freedesktop.org/gstreamer/cerbero/-/merge_requests/2238)
+ - inno Windows installer: allow setting User or Admin-level install via command line(https://gitlab.freedesktop.org/gstreamer/cerbero/-/merge_requests/2220)
+ - ios: Execute postinstall template copy only with user level installs(https://gitlab.freedesktop.org/gstreamer/cerbero/-/merge_requests/2226)
+ - m4: Update to 1.4.21(https://gitlab.freedesktop.org/gstreamer/cerbero/-/merge_requests/2236)
+ - macos: document or provide a way to uninstall the package(https://gitlab.freedesktop.org/gstreamer/cerbero/-/work_items/370)
+ - osx: Add uninstaller script via osascript(https://gitlab.freedesktop.org/gstreamer/cerbero/-/merge_requests/2224)
+ - Update to Rust 1.95 / rustup 1.29.0 / cargo-c 0.10.22(https://gitlab.freedesktop.org/gstreamer/cerbero/-/merge_requests/2230)
+
+#### Contributors to 1.28.3
+
+Anders Hellerup Madsen, Andreas Frisch, Andrew Yooeun Chun, Arthur Chan,
+Dennis Han, Bartel Wilhelm, Dominique Leroux, Edward Hervey, Fabian Orccon,
+François Laignel, Jan Schmidt, Jeongmin Kwak, Leonardo Salvatore,
+L. E. Segovia, Mathieu Duponchelle, Michael Olbrich, Michiel Westerbeek,
+Monty C, Nicolas Dufresne, Nirbheek Chauhan, Ognyan Tonchev, Philippe Normand,
+Philipp Wallrich, Piotr Brzeziński, Sanchayan Maity, Santiago Carot-Nemesio,
+Sebastian Dröge, Seungha Yang, Shigeharu Kamiya, Thibault Saunier,
+Tim-Philipp Müller, Tjitte de Wert, Tobias Koenig, Tomasz Bujewski,
+Víctor Manuel Jáquez Leal, Vivia Nikolaidou, Xabier Rodriguez Calvar,
+Xavier Claessens,
+
+... and many others who have contributed bug reports, translations, sent
+suggestions or helped testing. Thank you all!
+
+#### List of merge requests and issues fixed in 1.28.3
+
+- List of Merge Requests applied in 1.28.3(https://gitlab.freedesktop.org/groups/gstreamer/-/merge_requests?scope=all&utf8=%E2%9C%93&state=merged&milestone_title=1.28.3)
+- List of Issues fixed in 1.28.3(https://gitlab.freedesktop.org/groups/gstreamer/-/work_items?scope=all&utf8=%E2%9C%93&state=closed&milestone_title=1.28.3)
 
 ## Schedule for 1.30

_service:download_files:gst-plugins-bad-1.28.2.tar.xz/sys/aja/gstajasink.cpp -> _service:download_files:gst-plugins-bad-1.28.3.tar.xz/sys/aja/gstajasink.cpp Changed

_service:download_files:gst-plugins-bad-1.28.2.tar.xz/sys/androidmedia/gstamc.c -> _service:download_files:gst-plugins-bad-1.28.3.tar.xz/sys/androidmedia/gstamc.c Changed

@@ -200,18 +200,18 @@
       goto next_codec;
     }
 
-    GST_INFO ("Checking codec '%s'", name_str);
+    GST_LOG ("Checking codec '%s'", name_str);
 
     /* Compatibility codec names */
     if (strcmp (name_str, "AACEncoder") == 0 ||
         strcmp (name_str, "OMX.google.raw.decoder") == 0) {
-      GST_INFO ("Skipping compatibility codec '%s'", name_str);
+      GST_LOG ("Skipping compatibility codec '%s'", name_str);
       valid_codec = FALSE;
       goto next_codec;
     }
 
     if (g_str_has_suffix (name_str, ".secure")) {
-      GST_INFO ("Skipping DRM codec '%s'", name_str);
+      GST_LOG ("Skipping DRM codec '%s'", name_str);
       valid_codec = FALSE;
       goto next_codec;
     }
@@ -223,14 +223,14 @@
      */
     if (gst_amc_jni_is_vm_started () &&
         !g_str_has_prefix (name_str, "OMX.google.")) {
-      GST_INFO ("Skipping non-Google codec '%s' in standalone mode", name_str);
+      GST_LOG ("Skipping non-Google codec '%s' in standalone mode", name_str);
       valid_codec = FALSE;
       goto next_codec;
     }
 #endif
 
     if (g_str_has_prefix (name_str, "OMX.ARICENT.")) {
-      GST_INFO ("Skipping possible broken codec '%s'", name_str);
+      GST_LOG ("Skipping possible broken codec '%s'", name_str);
       valid_codec = FALSE;
       goto next_codec;
     }
@@ -242,7 +242,7 @@
     if (strcmp (name_str, "OMX.google.vorbis.decoder") == 0 ||
         strcmp (name_str, "OMX.google.g711.alaw.decoder") == 0 ||
         strcmp (name_str, "OMX.google.g711.mlaw.decoder") == 0) {
-      GST_INFO ("Skipping known broken codec '%s'", name_str);
+      GST_LOG ("Skipping known broken codec '%s'", name_str);
       valid_codec = FALSE;
       goto next_codec;
     }
@@ -282,7 +282,7 @@
       goto next_codec;
     }
 
-    GST_INFO ("Codec '%s' (%s) has %" G_GSIZE_FORMAT " supported types",
+    GST_LOG ("Codec '%s' (%s) has %" G_GSIZE_FORMAT " supported types",
         name_str, gst_amc_accel_to_string (gst_codec_info->accel),
         n_supported_types);
 
@@ -305,7 +305,7 @@
       gst_codec_type = &gst_codec_info->supported_typesj;
       supported_type_str = supported_typesj;
 
-      GST_INFO ("Supported type '%s'", supported_type_str);
+      GST_LOG ("Supported type '%s'", supported_type_str);
       gst_codec_type->mime = g_strdup (supported_type_str);
 
       capabilities =
@@ -330,7 +330,7 @@
         }
 
         for (k = 0; k < gst_codec_type->n_color_formats; k++) {
-          GST_INFO ("Color format %d: 0x%x", k,
+          GST_LOG ("Color format %d: 0x%x", k,
               gst_codec_type->color_formatsk);
         }
 
@@ -361,9 +361,9 @@
       }
 
       for (k = 0; k < gst_codec_type->n_profile_levels; k++) {
-        GST_INFO ("Level %d: 0x%08x", k,
+        GST_LOG ("Level %d: 0x%08x", k,
             gst_codec_type->profile_levelsk.level);
-        GST_INFO ("Profile %d: 0x%08x", k,
+        GST_LOG ("Profile %d: 0x%08x", k,
             gst_codec_type->profile_levelsk.profile);
       }
 
@@ -610,14 +610,14 @@
 
   if (color_format == COLOR_FormatYCbYCr) {
     if (strcmp (codec_info->name, "OMX.k3.video.decoder.avc") == 0) {
-      GST_INFO
+      GST_LOG
           ("OMX.k3.video.decoder.avc: COLOR_FormatYCbYCr is actually GST_VIDEO_FORMAT_NV12.");
       return GST_VIDEO_FORMAT_NV12;
     }
 
     /* FIXME COLOR_FormatYCbYCr doesn't work properly for OMX.k3.video.encoder.avc temporarily. */
     if (strcmp (codec_info->name, "OMX.k3.video.encoder.avc") == 0) {
-      GST_INFO
+      GST_FIXME
           ("OMX.k3.video.encoder.avc: COLOR_FormatYCbYCr is not supported yet.");
       return GST_VIDEO_FORMAT_UNKNOWN;
     }
@@ -628,7 +628,7 @@
 
   if (color_format == COLOR_FormatYUV420SemiPlanar) {
     if (strcmp (codec_info->name, "OMX.k3.video.encoder.avc") == 0) {
-      GST_INFO
+      GST_LOG
           ("OMX.k3.video.encoder.avc: COLOR_FormatYUV420SemiPlanar is actually GST_VIDEO_FORMAT_NV21.");
       return GST_VIDEO_FORMAT_NV21;
     }
@@ -661,7 +661,7 @@
 
   if (video_format == GST_VIDEO_FORMAT_NV12) {
     if (strcmp (codec_info->name, "OMX.k3.video.decoder.avc") == 0) {
-      GST_INFO
+      GST_LOG
           ("OMX.k3.video.decoder.avc: GST_VIDEO_FORMAT_NV12 is reported as COLOR_FormatYCbYCr.");
 
       return COLOR_FormatYCbYCr;
@@ -670,7 +670,7 @@
 
   if (video_format == GST_VIDEO_FORMAT_NV21) {
     if (strcmp (codec_info->name, "OMX.k3.video.encoder.avc") == 0) {
-      GST_INFO
+      GST_LOG
           ("OMX.k3.video.encoder.avc: GST_VIDEO_FORMAT_NV21 is reported as COLOR_FormatYUV420SemiPlanar.");
 
       return COLOR_FormatYUV420SemiPlanar;
@@ -1780,6 +1780,7 @@
       GType type, subtype;
       gchar *type_name, *element_name;
       guint rank;
+      GstCaps *caps;
       GstAmcCodecType *codec_type = &codec_info->supported_typesi;
 
       if (g_str_has_prefix (codec_type->mime, "audio/")) {
@@ -1910,10 +1911,24 @@
       }
 
       ret |= gst_element_register (plugin, element_name, rank, subtype);
-      g_free (element_name);
 
-      GST_INFO ("Registered %s codec '%s' with rank %u",
-          gst_amc_accel_to_string (codec_info->accel), codec_info->name, rank);
+      if (codec_info->is_encoder) {
+        gst_amc_codec_info_to_caps (codec_info, NULL, &caps);
+        GST_INFO
+            ("Registered encoder %s for %s impl %s with rank %u and outcaps %"
+            GST_PTR_FORMAT, element_name,
+            gst_amc_accel_to_string (codec_info->accel), codec_info->name, rank,
+            caps);
+      } else {
+        gst_amc_codec_info_to_caps (codec_info, &caps, NULL);
+        GST_INFO
+            ("Registered decoder %s for %s impl %s with rank %u and incaps %"
+            GST_PTR_FORMAT, element_name,
+            gst_amc_accel_to_string (codec_info->accel), codec_info->name, rank,
+            caps);
+      }
+      gst_caps_unref (caps);
+      g_free (element_name);
     }
   }
 
@@ -2329,6 +2344,8 @@
         } else if (strcmp (type->mime, "video/avc") == 0) {
           gint j;
           gboolean have_profile_level = FALSE;
+          gboolean have_baseline_profile = FALSE;
+          gboolean have_constrained_baseline_profile = FALSE;
 
           tmp = gst_structure_new ("video/x-h264",
               "width", GST_TYPE_INT_RANGE, 16, 4096,
@@ -2353,6 +2370,12 @@
                 continue;
               }
 
+              if (type->profile_levelsj.profile ==
+                  AVCProfileConstrainedBaseline)
+                have_constrained_baseline_profile = TRUE;
+              else if (type->profile_levelsj.profile == AVCProfileBaseline)
+                have_baseline_profile = TRUE;
+
               tmp2 = gst_structure_copy (tmp);
               gst_structure_set (tmp2, "profile", G_TYPE_STRING, profile, NULL);
 
@@ -2360,8 +2383,9 @@
                 tmp3 = gst_structure_copy (tmp);
                 gst_structure_set (tmp3, "profile", G_TYPE_STRING, alternative,
                     NULL);
-              } else
+              } else {
                 tmp3 = NULL;
+              }
 
               if (codec_info->is_encoder) {
                 const gchar *level;
@@ -2400,6 +2424,12 @@
           if (!have_profile_level) {
             encoded_ret = gst_caps_merge_structure (encoded_ret, tmp);
           } else {
+            if (have_baseline_profile && !have_constrained_baseline_profile) {
+              tmp2 = gst_structure_copy (tmp);
+              gst_structure_set (tmp2, "profile", G_TYPE_STRING,
+                  "constrained-baseline", NULL);
+              encoded_ret = gst_caps_merge_structure (encoded_ret, tmp2);
+            }
             gst_structure_free (tmp);
           }
         } else if (strcmp (type->mime, "video/hevc") == 0) {
@@ -2512,20 +2542,20 @@
   }
 
   /* Split caps into structures to bypass logcat line length limit */
-  if (gst_debug_category_get_threshold (GST_CAT_DEFAULT) >= GST_LEVEL_INFO) {
+  if (gst_debug_category_get_threshold (GST_CAT_DEFAULT) >= GST_LEVEL_LOG) {
     guint i, n;
-    GST_INFO ("Returning caps for '%s':", codec_info->name);
+    GST_LOG ("Returning caps for '%s':", codec_info->name);
 
-    GST_INFO (" raw caps:");
+    GST_LOG (" raw caps:");
     n = gst_caps_get_size (raw_ret);
     for (i = 0; i < n; i++) {
-      GST_INFO ("  %" GST_PTR_FORMAT, gst_caps_get_structure (raw_ret, i));
+      GST_LOG ("  %" GST_PTR_FORMAT, gst_caps_get_structure (raw_ret, i));
     }
 
-    GST_INFO (" encoded caps:");
+    GST_LOG (" encoded caps:");
     n = gst_caps_get_size (encoded_ret);
     for (i = 0; i < n; i++) {
-      GST_INFO ("  %" GST_PTR_FORMAT, gst_caps_get_structure (encoded_ret, i));
+      GST_LOG ("  %" GST_PTR_FORMAT, gst_caps_get_structure (encoded_ret, i));
     }
   }
 }

_service:download_files:gst-plugins-bad-1.28.2.tar.xz/sys/androidmedia/gstamcvideoenc.c -> _service:download_files:gst-plugins-bad-1.28.3.tar.xz/sys/androidmedia/gstamcvideoenc.c Changed

_service:download_files:gst-plugins-bad-1.28.2.tar.xz/sys/applemedia/avfdeviceprovider.m -> _service:download_files:gst-plugins-bad-1.28.3.tar.xz/sys/applemedia/avfdeviceprovider.m Changed

_service:download_files:gst-plugins-bad-1.28.2.tar.xz/sys/applemedia/avsamplevideosink.m -> _service:download_files:gst-plugins-bad-1.28.3.tar.xz/sys/applemedia/avsamplevideosink.m Changed

_service:download_files:gst-plugins-bad-1.28.2.tar.xz/sys/applemedia/corevideobuffer.c -> _service:download_files:gst-plugins-bad-1.28.3.tar.xz/sys/applemedia/corevideobuffer.c Changed

@@ -30,7 +30,7 @@
 
 #include "videotexturecache-gl.h"
 
-#if defined(APPLEMEDIA_MOLTENVK)
+#ifdef APPLEMEDIA_MOLTENVK
 #include "videotexturecache-vulkan.h"
 #if TARGET_OS_OSX
 #include "iosurfacevulkanmemory.h"
@@ -133,7 +133,7 @@
 #endif
 }
 
-#if defined(APPLEMEDIA_MOLTENVK)
+#ifdef APPLEMEDIA_MOLTENVK
 /* in videotexturecache-vulkan.m to avoid objc-ism from Metal being included
   * in a non-objc file */
 extern GstMemory *_create_vulkan_memory (GstAppleCoreVideoPixelBuffer * gpixbuf,
@@ -153,7 +153,7 @@
   GstAppleCoreVideoPixelBuffer *gpixbuf;
   GstMemory *mem = NULL;
   gboolean do_gl = GST_IS_VIDEO_TEXTURE_CACHE_GL (cache);
-#if defined(APPLEMEDIA_MOLTENVK)
+#ifdef APPLEMEDIA_MOLTENVK
   gboolean do_vulkan = GST_IS_VIDEO_TEXTURE_CACHE_VULKAN (cache);
 #endif
 
@@ -163,22 +163,20 @@
     *has_padding = FALSE;
 
   if (CVPixelBufferIsPlanar (pixel_buf)) {
-    gint i, size = 0, plane_offset = 0;
+    gint size = 0;
 
     n_planes = CVPixelBufferGetPlaneCount (pixel_buf);
-    for (i = 0; i < n_planes; i++) {
+    for (gint i = 0; i < n_planes; i++) {
       stridei = CVPixelBufferGetBytesPerRowOfPlane (pixel_buf, i);
 
       if (stridei != GST_VIDEO_INFO_PLANE_STRIDE (info, i) && has_padding)
         *has_padding = TRUE;
 
       size = stridei * CVPixelBufferGetHeightOfPlane (pixel_buf, i);
-      offseti = plane_offset;
-      plane_offset += size;
 
       if (do_gl)
         mem = _create_glmem (gpixbuf, info, i, size, cache);
-#if defined(APPLEMEDIA_MOLTENVK)
+#ifdef APPLEMEDIA_MOLTENVK
       else if (do_vulkan)
         mem = _create_vulkan_memory (gpixbuf, info, i, size, cache);
 #endif
@@ -186,6 +184,7 @@
         mem =
             GST_MEMORY_CAST (gst_apple_core_video_memory_new_wrapped (gpixbuf,
                 i, size));
+      offseti = gst_buffer_get_size (buf);
       gst_buffer_append_memory (buf, mem);
     }
   } else {
@@ -196,7 +195,7 @@
 
     if (do_gl)
       mem = _create_glmem (gpixbuf, info, 0, size, cache);
-#if defined(APPLEMEDIA_MOLTENVK)
+#ifdef APPLEMEDIA_MOLTENVK
     else if (do_vulkan)
       mem = _create_vulkan_memory (gpixbuf, info, 0, size, cache);
 #endif

_service:download_files:gst-plugins-bad-1.28.2.tar.xz/sys/applemedia/helpers.h -> _service:download_files:gst-plugins-bad-1.28.3.tar.xz/sys/applemedia/helpers.h Changed

@@ -26,17 +26,21 @@
 
 // kCVPixelFormatType_64RGBALE is only available for 11.3 +.
 // See https://developer.apple.com/documentation/corevideo/1563591-pixel_format_identifiers/kcvpixelformattype_64rgbale
-#if defined(MAC_OS_X_VERSION_MAX_ALLOWED) && MAC_OS_X_VERSION_MAX_ALLOWED < 110300
+#if MAC_OS_X_VERSION_MAX_ALLOWED < 110300
 #define kCVPixelFormatType_64RGBALE 'l64r'
 #endif
 #define GST_APPLEMEDIA_HAVE_64RGBALE __builtin_available(macOS 11.3, *)
 
-// kCMVideoCodecType_AV1 is only available for M3 series or later
-// The actual FourCC value for AV1 is 'av01'
-#if defined(MAC_OS_X_VERSION_MAX_ALLOWED) && MAC_OS_X_VERSION_MAX_ALLOWED < 130100
+// Added in Xcode 14
+#if MAC_OS_X_VERSION_MAX_ALLOWED < 130100
 #define kCMVideoCodecType_AV1 'av01'
 #endif
 
+// Added in Xcode 12
+#if MAC_OS_X_VERSION_MAX_ALLOWED < 110000
+#define kCMVideoCodecType_VP9 'vp09'
+#endif
+
 #define GST_CVPIXELFORMAT_FOURCC_ARGS(fourcc) \
   __GST_PRINT_CHAR(((fourcc) >> 24) & 0xff),  \
   __GST_PRINT_CHAR(((fourcc) >> 16) & 0xff),  \

_service:download_files:gst-plugins-bad-1.28.2.tar.xz/sys/applemedia/iosurfacevulkanmemory.c -> _service:download_files:gst-plugins-bad-1.28.3.tar.xz/sys/applemedia/iosurfacevulkanmemory.c Changed

@@ -23,6 +23,7 @@
 #endif
 
 #include "iosurfacevulkanmemory.h"
+#include <vulkan/vulkan_metal.h>
 #include "metal-helpers.h"
 
 GST_DEBUG_CATEGORY_STATIC (GST_CAT_IO_SURFACE_VULKAN_MEMORY);
@@ -43,8 +44,10 @@
 static void
 _mem_free (GstAllocator * allocator, GstMemory * mem)
 {
-  gst_io_surface_vulkan_memory_set_surface ((GstIOSurfaceVulkanMemory *) mem,
-      NULL);
+  GstIOSurfaceVulkanMemory *io_surface_mem = (GstIOSurfaceVulkanMemory *) mem;
+  if (io_surface_mem && io_surface_mem->surface) {
+    IOSurfaceDecrementUseCount (io_surface_mem->surface);
+  }
 
   GST_ALLOCATOR_CLASS
       (gst_io_surface_vulkan_memory_allocator_parent_class)->free (allocator,
@@ -140,12 +143,13 @@
 
 static GstIOSurfaceVulkanMemory *
 _io_surface_vulkan_memory_new (GstVulkanDevice * device, IOSurfaceRef surface,
-    unsigned int /* MTLPixelFormat */ fmt, GstVideoInfo * info, guint plane,
-    gpointer user_data, GDestroyNotify notify)
+    unsigned int /* MTLPixelFormat */ fmt, gpointer metal_texture,
+    GstVideoInfo * info, guint plane, gpointer user_data, GDestroyNotify notify)
 {
   GstIOSurfaceVulkanMemory *mem;
   GstAllocationParams params = { 0, };
   VkImageCreateInfo image_info;
+  VkImportMetalTextureInfoEXT import_texture_info;
   VkPhysicalDevice gpu;
   VkImageUsageFlags usage;
   VkImageTiling tiling = VK_IMAGE_TILING_OPTIMAL;
@@ -163,9 +167,17 @@
       VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT;
 
   /* *INDENT-OFF* */
+  import_texture_info = (VkImportMetalTextureInfoEXT) {
+      .sType = VK_STRUCTURE_TYPE_IMPORT_METAL_TEXTURE_INFO_EXT,
+      .pNext = NULL,
+      .plane = VK_IMAGE_ASPECT_COLOR_BIT,
+      .mtlTexture = metal_texture,
+  };
+
+  /* *INDENT-OFF* */
   image_info = (VkImageCreateInfo) {
       .sType = VK_STRUCTURE_TYPE_IMAGE_CREATE_INFO,
-      .pNext = NULL,
+      .pNext = metal_texture ? &import_texture_info : NULL,
       .flags = 0,
       .imageType = VK_IMAGE_TYPE_2D,
       .format = vk_format,
@@ -210,9 +222,10 @@
 
   GST_MINI_OBJECT_FLAG_SET (mem, GST_MEMORY_FLAG_READONLY);
 
-  mem->surface = NULL;
+  mem->surface = surface;
+  if (surface)
+    IOSurfaceIncrementUseCount (surface);
   mem->plane = plane;
-  gst_io_surface_vulkan_memory_set_surface (mem, surface);
 
   return mem;
 
@@ -235,8 +248,9 @@
 GstIOSurfaceVulkanMemory *
 gst_io_surface_vulkan_memory_wrapped (GstVulkanDevice * device,
     IOSurfaceRef surface, unsigned int /* MTLPixelFormat */ fmt,
+    gpointer metal_texture,
     GstVideoInfo * info, guint plane, gpointer user_data, GDestroyNotify notify)
 {
-  return _io_surface_vulkan_memory_new (device, surface, fmt, info, plane,
-      user_data, notify);
+  return _io_surface_vulkan_memory_new (device, surface, fmt, metal_texture,
+      info, plane, user_data, notify);
 }

_service:download_files:gst-plugins-bad-1.28.2.tar.xz/sys/applemedia/iosurfacevulkanmemory.h -> _service:download_files:gst-plugins-bad-1.28.3.tar.xz/sys/applemedia/iosurfacevulkanmemory.h Changed

_service:download_files:gst-plugins-bad-1.28.2.tar.xz/sys/applemedia/meson.build -> _service:download_files:gst-plugins-bad-1.28.3.tar.xz/sys/applemedia/meson.build Changed

_service:download_files:gst-plugins-bad-1.28.2.tar.xz/sys/applemedia/metal-helpers.h -> _service:download_files:gst-plugins-bad-1.28.3.tar.xz/sys/applemedia/metal-helpers.h Changed

_service:download_files:gst-plugins-bad-1.28.2.tar.xz/sys/applemedia/videotexturecache-vulkan.mm -> _service:download_files:gst-plugins-bad-1.28.3.tar.xz/sys/applemedia/videotexturecache-vulkan.mm Changed

@@ -64,11 +64,11 @@
 #define GET_PRIV(instance) \
     G_TYPE_INSTANCE_GET_PRIVATE (instance, GST_TYPE_VIDEO_TEXTURE_CACHE_VULKAN, GstVideoTextureCacheVulkanPrivate)
 
-typedef struct _IOSTextureWrapper
+typedef struct _IOSurfaceTextureWrapper
 {
-  CVMetalTextureCacheRef cache;
-  CVMetalTextureRef texture;
-} IOSTextureWrapper;
+  CVPixelBufferRef pixbuf;
+  gpointer texture; /* id<MTLTexture> */
+} IOSurfaceTextureWrapper;
 
 enum
 {
@@ -79,6 +79,15 @@
 static GstMemory * gst_video_texture_cache_vulkan_create_memory (GstVideoTextureCache * cache,
       GstAppleCoreVideoPixelBuffer *gpixbuf, guint plane, gsize size);
 
+static void
+free_texture_wrapper (IOSurfaceTextureWrapper * wrapper)
+{
+  CFRelease (wrapper->pixbuf);
+  id<MTLTexture> tex = (__bridge_transfer id<MTLTexture>) wrapper->texture;
+  (void) tex;
+  g_free (wrapper);
+}
+
 GstVideoTextureCache *
 gst_video_texture_cache_vulkan_new (GstVulkanDevice * device)
 {
@@ -223,95 +232,42 @@
   GstVideoTextureCacheVulkan *cache_vulkan =
       GST_VIDEO_TEXTURE_CACHE_VULKAN (cache);
   MTLPixelFormat fmt = (MTLPixelFormat) video_info_to_metal_format (info, plane);
+  GstVulkanDevice *device = cache_vulkan->device;
+  VkPhysicalDevice gpu;
+  id<MTLDevice> mtl_dev = nil;
+  MTLTextureDescriptor *tex_desc;
+  id<MTLTexture> texture = nil;
+
+  gpu = gst_vulkan_device_get_physical_device (device);
+  G_GNUC_BEGIN_IGNORE_DEPRECATIONS;
+  vkGetMTLDeviceMVK (gpu, &mtl_dev);
+  G_GNUC_END_IGNORE_DEPRECATIONS;
+
+  tex_desc = MTLTextureDescriptor new;
+  tex_desc.pixelFormat = fmt;
+  tex_desc.textureType = MTLTextureType2D;
+  tex_desc.width = GST_VIDEO_INFO_COMP_WIDTH (info, plane);
+  tex_desc.height = GST_VIDEO_INFO_COMP_HEIGHT (info, plane);
+  tex_desc.depth = 1;
+  tex_desc.mipmapLevelCount = 1;
+  tex_desc.sampleCount = 1;
+  tex_desc.arrayLength = 1;
+  tex_desc.usage = MTLTextureUsageShaderRead;
+  tex_desc.cpuCacheMode = MTLCPUCacheModeDefaultCache;
+
+  texture = mtl_dev newTextureWithDescriptor:tex_desc iosurface:surface plane:plane;
+  if (!texture)
+    return NULL;
 
-  CFRetain (pixel_buf);
-  mem = gst_io_surface_vulkan_memory_wrapped (cache_vulkan->device,
-      surface, fmt, info, plane, pixel_buf, (GDestroyNotify) CFRelease);
+  IOSurfaceTextureWrapper *texture_data = g_new0 (IOSurfaceTextureWrapper, 1);
+  texture_data->pixbuf = (CVPixelBufferRef) CFRetain (pixel_buf);
+  texture_data->texture = (__bridge_retained gpointer) texture;
 
+  mem = gst_io_surface_vulkan_memory_wrapped (device, surface, fmt,
+      (__bridge void *) texture, info, plane, texture_data,
+      (GDestroyNotify) free_texture_wrapper);
   if (!mem)
-    return NULL;
+    free_texture_wrapper (texture_data);
 
   return GST_MEMORY_CAST (mem);
 }
-
-typedef struct _IOSurfaceTextureWrapper
-{
-  CVPixelBufferRef pixbuf;
-  gpointer texture; /* id<MTLTexture> */
-} IOSurfaceTextureWrapper;
-
-static void
-free_texture_wrapper (IOSurfaceTextureWrapper * wrapper)
-{
-  CFRelease (wrapper->pixbuf);
-  id<MTLTexture> tex = (__bridge_transfer id<MTLTexture>) wrapper->texture;
-  (void) tex;
-  g_free (wrapper);
-}
-
-static MTLTextureDescriptor *
-gst_new_mtl_tex_descripter_from_memory (GstIOSurfaceVulkanMemory * memory)
-{
-  GstVulkanImageMemory *vk_mem = (GstVulkanImageMemory *) memory;
-  MTLTextureDescriptor* tex_desc = MTLTextureDescriptor new;
-  tex_desc.pixelFormat = mvkMTLPixelFormatFromVkFormat (vk_mem->create_info.format);
-  tex_desc.textureType = mvkMTLTextureTypeFromVkImageType (vk_mem->create_info.imageType, 0, false);
-  tex_desc.width = vk_mem->create_info.extent.width;
-  tex_desc.height = vk_mem->create_info.extent.height;
-  tex_desc.depth = vk_mem->create_info.extent.depth;
-  tex_desc.mipmapLevelCount = vk_mem->create_info.mipLevels;
-  tex_desc.sampleCount = mvkSampleCountFromVkSampleCountFlagBits(vk_mem->create_info.samples);
-  tex_desc.arrayLength = vk_mem->create_info.arrayLayers;
-  tex_desc.usage = MTLTextureUsageShaderRead | MTLTextureUsagePixelFormatView;//mvkMTLTextureUsageFromVkImageUsageFlags(vk_mem->create_info.usage);
-  tex_desc.storageMode = MTLStorageModeShared;
-  tex_desc.cpuCacheMode = MTLCPUCacheModeDefaultCache;//mvkMTLCPUCacheModeFromVkMemoryPropertyFlags(vk_mem->vk_mem->properties);
-
-  return tex_desc;
-}
-
-void
-gst_io_surface_vulkan_memory_set_surface (GstIOSurfaceVulkanMemory * memory,
-    IOSurfaceRef surface)
-{
-  GstVulkanImageMemory *vk_mem = (GstVulkanImageMemory *) memory;
-
-  if (memory->surface) {
-     IOSurfaceDecrementUseCount (memory->surface);
-  } else {
-    g_assert (vk_mem->notify == (GDestroyNotify) CFRelease);
-    g_assert (vk_mem->user_data != NULL);
-  }
-
-  memory->surface = surface;
-  if (surface) {
-    id<MTLDevice> mtl_dev = nil;
-    id<MTLTexture> texture = nil;
-    VkPhysicalDevice gpu;
-
-    IOSurfaceIncrementUseCount (surface);
-
-    gpu = gst_vulkan_device_get_physical_device (vk_mem->device);
-    G_GNUC_BEGIN_IGNORE_DEPRECATIONS;
-    vkGetMTLDeviceMVK (gpu, &mtl_dev);
-    G_GNUC_END_IGNORE_DEPRECATIONS;
-
-    /* We cannot use vkUseIOSurfaceMVK() for multi-planer as MoltenVK does not
-     * support them. */
-
-    MTLTextureDescriptor *tex_desc = gst_new_mtl_tex_descripter_from_memory (memory);
-    texture = mtl_dev newTextureWithDescriptor:tex_desc iosurface:surface plane:memory->plane;
-
-    IOSurfaceTextureWrapper *texture_data = g_new0 (IOSurfaceTextureWrapper, 1);
-    texture_data->pixbuf = (CVPixelBufferRef) vk_mem->user_data;
-    texture_data->texture = (__bridge_retained gpointer) texture;
-
-    G_GNUC_BEGIN_IGNORE_DEPRECATIONS;
-    VkResult err = vkSetMTLTextureMVK (memory->vulkan_mem.image, texture);
-    G_GNUC_END_IGNORE_DEPRECATIONS;
-    GST_DEBUG ("bound texture %p to image %" GST_VULKAN_NON_DISPATCHABLE_HANDLE_FORMAT ": 0x%x",
-               texture, memory->vulkan_mem.image, err);
-
-    vk_mem->user_data = texture_data;
-    vk_mem->notify = (GDestroyNotify) free_texture_wrapper;
-  }
-}

_service:download_files:gst-plugins-bad-1.28.2.tar.xz/sys/applemedia/vtdec.c -> _service:download_files:gst-plugins-bad-1.28.3.tar.xz/sys/applemedia/vtdec.c Changed

@@ -51,6 +51,8 @@
 #endif
 
 #include <string.h>
+#include <stddef.h>
+#include <dlfcn.h>
 #include "vtdec.h"
 #include <gst/gst.h>
 #include <gst/base/gstbytewriter.h>
@@ -63,13 +65,89 @@
 #include "corevideobuffer.h"
 #include "coremediabuffer.h"
 #include "videotexturecache-gl.h"
-#if defined(APPLEMEDIA_MOLTENVK)
+
+#ifdef APPLEMEDIA_MOLTENVK
+#include <MoltenVK/mvk_private_api.h>
 #include "videotexturecache-vulkan.h"
 #endif
 
 GST_DEBUG_CATEGORY_STATIC (gst_vtdec_debug_category);
 #define GST_CAT_DEFAULT gst_vtdec_debug_category
 
+/* Added in Xcode 13 */
+#if MAC_OS_X_VERSION_MAX_ALLOWED < 120000
+#define kVTVideoDecoderReferenceMissingErr -17694
+#endif
+
+#ifdef APPLEMEDIA_MOLTENVK
+/* Temporary MoltenVK-specific warning probe for issue #2705.
+ * Remove this once GStreamer ships a MoltenVK version containing the fix:
+ * https://github.com/KhronosGroup/MoltenVK/issues/2705
+ */
+static gboolean
+gst_vtdec_moltenvk_argument_buffers_enabled (GstVtdec * vtdec)
+{
+  static const size_t arg_buffers_field_end = offsetof (MVKConfiguration,
+      useMetalArgumentBuffers) + sizeof (VkBool32);
+  PFN_vkGetMoltenVKConfigurationMVK get_mvk_config;
+  MVKConfiguration config;
+  size_t config_size = sizeof (config);
+  VkResult result;
+
+  get_mvk_config =
+      (PFN_vkGetMoltenVKConfigurationMVK) dlsym (RTLD_DEFAULT,
+      "vkGetMoltenVKConfigurationMVK");
+  if (!get_mvk_config) {
+    get_mvk_config = (PFN_vkGetMoltenVKConfigurationMVK)
+        gst_vulkan_instance_get_proc_address (vtdec->instance,
+        "vkGetMoltenVKConfigurationMVK");
+  }
+  if (!get_mvk_config) {
+    GST_WARNING_OBJECT (vtdec,
+        "MoltenVK config probe could not resolve vkGetMoltenVKConfigurationMVK");
+    return FALSE;
+  }
+
+  memset (&config, 0, sizeof (config));
+  result = get_mvk_config (VK_NULL_HANDLE, &config, &config_size);
+  if (result != VK_SUCCESS && result != VK_INCOMPLETE) {
+    GST_WARNING_OBJECT (vtdec,
+        "MoltenVK configuration query failed with VkResult %d", result);
+    return FALSE;
+  }
+
+  if (config_size < arg_buffers_field_end) {
+    GST_WARNING_OBJECT (vtdec,
+        "MoltenVK configuration size %zu does not cover useMetalArgumentBuffers",
+        config_size);
+    return FALSE;
+  }
+
+  return config.useMetalArgumentBuffers != VK_FALSE;
+}
+
+static void
+gst_vtdec_warn_moltenvk_argument_buffers (GstVtdec * vtdec)
+{
+  static gsize warned_once = 0;
+  static const gchar *message =
+      "vtdec Vulkan output on MoltenVK may lose the device when Metal "
+      "argument buffers are enabled; workaround: "
+      "MVK_CONFIG_USE_METAL_ARGUMENT_BUFFERS=0; upstream: "
+      "https://github.com/KhronosGroup/MoltenVK/issues/2705.";
+
+  if (!gst_vtdec_moltenvk_argument_buffers_enabled (vtdec))
+    return;
+
+  if (!g_once_init_enter (&warned_once))
+    return;
+
+  GST_ELEMENT_WARNING (vtdec, RESOURCE, FAILED, ("%s", message), (NULL));
+
+  g_once_init_leave (&warned_once, 1);
+}
+#endif
+
 typedef enum
 {
   NoneSupported = 0,
@@ -85,10 +163,6 @@
   VTDEC_FRAME_FLAG_ERROR = (1 << 12),
 };
 
-#if (defined(__IPHONE_OS_VERSION_MAX_ALLOWED) && __IPHONE_OS_VERSION_MAX_ALLOWED < 140000) || (defined(MAC_OS_X_VERSION_MAX_ALLOWED) && MAC_OS_X_VERSION_MAX_ALLOWED < 110000)
-#define kCMVideoCodecType_VP9 'vp09'
-#endif
-
 static void gst_vtdec_finalize (GObject * object);
 
 static gboolean gst_vtdec_start (GstVideoDecoder * decoder);
@@ -159,28 +233,24 @@
 
 static SupplementalSupport gst_vtdec_codec_support = NoneSupported;
 
-/* define EnableHardwareAcceleratedVideoDecoder in < 10.9 */
-#if defined(MAC_OS_X_VERSION_MAX_ALLOWED) && MAC_OS_X_VERSION_MAX_ALLOWED < 1090
-const CFStringRef
-    kVTVideoDecoderSpecification_EnableHardwareAcceleratedVideoDecoder =
-CFSTR ("EnableHardwareAcceleratedVideoDecoder");
-const CFStringRef
-    kVTVideoDecoderSpecification_RequireHardwareAcceleratedVideoDecoder =
-CFSTR ("RequireHardwareAcceleratedVideoDecoder");
-#endif
+#define VIDEO_SRC_CAPS_NATIVE_FORMATS "{ NV12, AYUV64, ARGB64_BE, P010_10LE }"
 
-#define VIDEO_SRC_CAPS_FORMATS "{ NV12, AYUV64, ARGB64_BE, P010_10LE }"
+/* TODO: Add support for more formats to videotexturecache-vulkan/gl.
+ * VideoToolbox will output most formats with HW-backed buffers,
+ * but our GL/Vulkan code does not support handling them yet. */
+#define VIDEO_SRC_CAPS_GL_FORMATS "{ NV12 }"
+#define VIDEO_SRC_CAPS_VULKAN_FORMATS "{ NV12, BGRA }"
 
 #define VIDEO_SRC_CAPS_NATIVE                                           \
     GST_VIDEO_CAPS_MAKE_WITH_FEATURES(GST_CAPS_FEATURE_MEMORY_GL_MEMORY,\
-        VIDEO_SRC_CAPS_FORMATS) ", "                                    \
-    "texture-target = (string) rectangle ;"                             \
-    GST_VIDEO_CAPS_MAKE(VIDEO_SRC_CAPS_FORMATS)
+        VIDEO_SRC_CAPS_GL_FORMATS) ", "                                 \
+    "texture-target = (string) rectangle ;"                              \
+    GST_VIDEO_CAPS_MAKE(VIDEO_SRC_CAPS_NATIVE_FORMATS)
 
-#if defined(APPLEMEDIA_MOLTENVK)
+#ifdef APPLEMEDIA_MOLTENVK
 #define VIDEO_SRC_CAPS                                                      \
     GST_VIDEO_CAPS_MAKE_WITH_FEATURES(GST_CAPS_FEATURE_MEMORY_VULKAN_IMAGE, \
-        VIDEO_SRC_CAPS_FORMATS) ";" VIDEO_SRC_CAPS_NATIVE
+        VIDEO_SRC_CAPS_VULKAN_FORMATS) ";" VIDEO_SRC_CAPS_NATIVE
 #else
 #define VIDEO_SRC_CAPS VIDEO_SRC_CAPS_NATIVE
 #endif
@@ -203,7 +273,8 @@
     GstCaps *caps = gst_caps_from_string (VIDEO_SRC_CAPS);
     /* RGBA64_LE is kCVPixelFormatType_64RGBALE, only available on macOS 11.3+ */
     if (GST_APPLEMEDIA_HAVE_64RGBALE)
-      caps = gst_vtutil_caps_append_video_format (caps, "RGBA64_LE");
+      caps = gst_vtutil_caps_append_video_format (caps, "RGBA64_LE",
+          GST_CAPS_FEATURE_MEMORY_SYSTEM_MEMORY);
     gst_element_class_add_pad_template (element_class,
         gst_pad_template_new ("src", GST_PAD_SRC, GST_PAD_ALWAYS, caps));
     gst_caps_unref (caps);
@@ -290,8 +361,12 @@
 
   GST_DEBUG_OBJECT (vtdec, "stop");
 
+  GST_VIDEO_DECODER_STREAM_LOCK (vtdec);
   gst_vtdec_drain_decoder (GST_VIDEO_DECODER_CAST (vtdec), TRUE);
   vtdec->downstream_ret = GST_FLOW_FLUSHING;
+  GST_VIDEO_DECODER_STREAM_UNLOCK (vtdec);
+
+  gst_pad_stop_task (GST_VIDEO_DECODER_SRC_PAD (decoder));
 
   while ((frame = gst_vec_deque_pop_head (vtdec->reorder_queue))) {
     gst_video_decoder_release_frame (decoder, frame);
@@ -299,8 +374,6 @@
   gst_vec_deque_free (vtdec->reorder_queue);
   vtdec->reorder_queue = NULL;
 
-  gst_pad_stop_task (GST_VIDEO_DECODER_SRC_PAD (decoder));
-
   if (vtdec->input_state)
     gst_video_codec_state_unref (vtdec->input_state);
   vtdec->input_state = NULL;
@@ -326,7 +399,7 @@
     gst_buffer_unref (vtdec->av1_sequence_header_obu);
   vtdec->av1_sequence_header_obu = NULL;
 
-#if defined(APPLEMEDIA_MOLTENVK)
+#ifdef APPLEMEDIA_MOLTENVK
   gst_clear_object (&vtdec->device);
   gst_clear_object (&vtdec->instance);
 #endif
@@ -347,7 +420,8 @@
     g_cond_wait (&vtdec->queue_cond, &vtdec->queue_mutex);
   }
 
-  /* If we're currently draining/flushing, make sure to not pause before we output all the frames */
+  /* If we're currently draining/flushing,
+   * make sure to not pause before we output all the frames */
   if (vtdec->pause_task &&
       ((!vtdec->is_flushing && !vtdec->is_draining) ||
           gst_vec_deque_is_empty (vtdec->reorder_queue))) {
@@ -361,10 +435,9 @@
    * that we push in PTS order, or if we're draining/flushing */
   while ((gst_vec_deque_get_length (vtdec->reorder_queue) >
           vtdec->dbp_size) || vtdec->is_flushing || vtdec->is_draining) {
-    gboolean is_flushing;
+    gboolean is_flushing = vtdec->is_flushing;
 
     frame = gst_vec_deque_pop_head (vtdec->reorder_queue);
-    is_flushing = vtdec->is_flushing;
     g_cond_signal (&vtdec->queue_cond);
     g_mutex_unlock (&vtdec->queue_mutex);
 
@@ -399,21 +472,22 @@
   g_mutex_unlock (&vtdec->queue_mutex);
   GST_VIDEO_DECODER_STREAM_LOCK (vtdec);
 
-  /* We need to empty the queue immediately so that session_output_callback()
-   * can push out the current buffer, otherwise it can deadlock */
   if (ret != GST_FLOW_OK) {
     g_mutex_lock (&vtdec->queue_mutex);
 
-    while ((frame = gst_vec_deque_pop_head (vtdec->reorder_queue))) {
-      GST_LOG_OBJECT (vtdec, "flushing frame %d", frame->system_frame_number);
-      gst_video_decoder_release_frame (decoder, frame);
-    }
-
-    /* Don't consider the FLUSHING ret an error if something flagged is_flushing in the meantime */
+    /* Don't consider the FLUSHING ret an error if
+     * something flagged is_flushing in the meantime */
     if (vtdec->is_flushing && ret == GST_FLOW_FLUSHING) {
       ret = GST_FLOW_OK;
     }
-    g_cond_signal (&vtdec->queue_cond);
+
+    /* Make sure handle_frame() won't get stuck due to the queue size limit */
+    if (!vtdec->is_flushing) {
+      GST_DEBUG_OBJECT (vtdec, "setting flushing flag");
+      vtdec->is_flushing = TRUE;
+      g_cond_signal (&vtdec->queue_cond);
+    }
+
     g_mutex_unlock (&vtdec->queue_mutex);
   }
 
@@ -545,7 +619,7 @@
   OSStatus err = noErr;
   GstCapsFeatures *features = NULL;
   gboolean output_textures = FALSE;
-#if defined(APPLEMEDIA_MOLTENVK)
+#ifdef APPLEMEDIA_MOLTENVK
   gboolean output_vulkan = FALSE;
 #endif
 
@@ -566,7 +640,6 @@
   peercaps =
       gst_pad_peer_query_caps (GST_VIDEO_DECODER_SRC_PAD (vtdec), templcaps);
   gst_caps_unref (templcaps);
-
   if (gst_caps_is_empty (peercaps)) {
     GST_INFO_OBJECT (vtdec, "empty peer caps, can't negotiate");
 
@@ -641,7 +714,7 @@
           NULL);
 #endif
 
-#if defined(APPLEMEDIA_MOLTENVK)
+#ifdef APPLEMEDIA_MOLTENVK
     output_vulkan =
         gst_caps_features_contains (features,
         GST_CAPS_FEATURE_MEMORY_VULKAN_IMAGE);
@@ -683,7 +756,7 @@
   if (vtdec->texture_cache != NULL
       && ((GST_IS_VIDEO_TEXTURE_CACHE_GL (vtdec->texture_cache)
               && !output_textures)
-#if defined(APPLEMEDIA_MOLTENVK)
+#ifdef APPLEMEDIA_MOLTENVK
           || (GST_IS_VIDEO_TEXTURE_CACHE_VULKAN (vtdec->texture_cache)
               && !output_vulkan)
 #endif
@@ -719,7 +792,7 @@
         setup_texture_cache (vtdec, format);
       }
     }
-#if defined(APPLEMEDIA_MOLTENVK)
+#ifdef APPLEMEDIA_MOLTENVK
     if (output_vulkan) {
       GstVideoTextureCacheVulkan *cache_vulkan = NULL;
 
@@ -734,6 +807,8 @@
         return FALSE;
       }
 
+      gst_vtdec_warn_moltenvk_argument_buffers (vtdec);
+
       GST_INFO_OBJECT (vtdec, "pushing vulkan images, device %" GST_PTR_FORMAT
           " old device %" GST_PTR_FORMAT, vtdec->device,
           cache_vulkan ? cache_vulkan->device : NULL);
@@ -909,20 +984,6 @@
       GST_VIDEO_DECODER_CLASS (gst_vtdec_parent_class)->sink_event (decoder,
       event);
 
-  switch (type) {
-    case GST_EVENT_FLUSH_STOP:
-      /* The base class handles this event and calls _flush().
-       * We can then safely reset the flushing flag. */
-      GST_DEBUG_OBJECT (vtdec, "flush stop received, removing flushing flag");
-
-      g_mutex_lock (&vtdec->queue_mutex);
-      vtdec->is_flushing = FALSE;
-      g_mutex_unlock (&vtdec->queue_mutex);
-      break;
-    default:
-      break;
-  }
-
   return ret;
 }
 
@@ -996,6 +1057,8 @@
   int decode_frame_number = frame->decode_frame_number;
   GstTaskState task_state;
 
+  GST_LOG_OBJECT (vtdec, "got input frame %d", decode_frame_number);
+
   if (vtdec->format_description == NULL) {
     ret = GST_FLOW_NOT_NEGOTIATED;
     goto drop;
@@ -1103,7 +1166,28 @@
     }
   }
 
-  GST_LOG_OBJECT (vtdec, "got input frame %d", decode_frame_number);
+  /* Don't process too many frames ahead AND make sure to not push if some other thread
+   * triggers draining (e.g. output loop via a frame push), as there's nothing stopping
+   * the input from going full throttle then.  */
+  GST_VIDEO_DECODER_STREAM_UNLOCK (vtdec);
+  g_mutex_lock (&vtdec->queue_mutex);
+  while ((gst_vec_deque_get_length (vtdec->reorder_queue) >
+          vtdec->dbp_size * 2 + 1 || vtdec->is_draining)
+      && !vtdec->is_flushing) {
+    g_cond_wait (&vtdec->queue_cond, &vtdec->queue_mutex);
+  }
+
+  /* Drop immediately if flushing was triggered from elsewhere */
+  if (vtdec->is_flushing) {
+    g_mutex_unlock (&vtdec->queue_mutex);
+    GST_DEBUG_OBJECT (vtdec, "Flushing flag set, ignoring frame");
+    GST_VIDEO_DECODER_STREAM_LOCK (vtdec);
+    ret = GST_FLOW_FLUSHING;
+    goto drop;
+  }
+
+  g_mutex_unlock (&vtdec->queue_mutex);
+  GST_VIDEO_DECODER_STREAM_LOCK (vtdec);
 
   /* don't bother enabling kVTDecodeFrame_EnableTemporalProcessing at all since
    * it's not mandatory for the underlying VT codec to respect it. KISS and do
@@ -1113,15 +1197,8 @@
   cm_sample_buffer =
       cm_sample_buffer_from_gst_buffer (vtdec, frame->input_buffer);
 
-  /* We need to unlock the stream lock here because
-   * the decode call can wait until gst_vtdec_session_output_callback()
-   * is finished, which in turn can wait until there's space in the
-   * output queue, which is being handled by the output loop,
-   * which also uses the stream lock... */
-  GST_VIDEO_DECODER_STREAM_UNLOCK (vtdec);
   status = VTDecompressionSessionDecodeFrame (vtdec->session, cm_sample_buffer,
       input_flags, frame, NULL);
-  GST_VIDEO_DECODER_STREAM_LOCK (vtdec);
 
   GST_LOG_OBJECT (vtdec, "VTDecompressionSessionDecodeFrame returned: %d",
       status);
@@ -1138,15 +1215,19 @@
       status == codecErr ||
 #endif
       status == kVTVideoDecoderMalfunctionErr) {
-    GST_WARNING_OBJECT (vtdec, "DecodeFrame returned %i, resetting session",
-        status);
-    if (!gst_vtdec_reset_session (vtdec))
-      return GST_FLOW_ERROR;
+    GST_WARNING_OBJECT (vtdec,
+        "DecodeFrame returned %i, resetting session", status);
+    if (!gst_vtdec_reset_session (vtdec)) {
+      ret = GST_FLOW_ERROR;
+      gst_video_decoder_drop_frame (decoder, frame);
+      goto out;
+    }
 
     gst_video_decoder_request_sync_point (decoder, frame,
         GST_VIDEO_DECODER_REQUEST_SYNC_POINT_DISCARD_INPUT);
     gst_video_decoder_drop_frame (decoder, frame);
-    return GST_FLOW_OK;
+    ret = GST_FLOW_OK;
+    goto out;
   }
 
   if (status != noErr) {
@@ -1196,7 +1277,11 @@
       &kCFTypeDictionaryValueCallBacks);
 
 #if TARGET_OS_OSX || TARGET_OS_VISION || TARGET_OS_IOS || TARGET_OS_TV
+#if MAC_OS_X_VERSION_MAX_ALLOWED < 140000
+  if (__builtin_available (macOS 10.9, iOS 17.0, tvOS 17.0, *)) {
+#else
   if (__builtin_available (macOS 10.9, iOS 17.0, tvOS 17.0, visionOS 1.0, *)) {
+#endif
     gst_vtutil_dict_set_boolean (videoDecoderSpecification,
         kVTVideoDecoderSpecification_EnableHardwareAcceleratedVideoDecoder,
         enable_hardware);
@@ -1619,7 +1704,6 @@
   GstVtdec *vtdec = (GstVtdec *) decompression_output_ref_con;
   GstVideoCodecFrame *frame = (GstVideoCodecFrame *) source_frame_ref_con;
   GstVideoCodecState *state;
-  gboolean push_anyway = FALSE;
 
   GST_LOG_OBJECT (vtdec, "got output frame %p %d and VT buffer %p", frame,
       frame->decode_frame_number, image_buffer);
@@ -1693,23 +1777,9 @@
     }
   }
 
-  /* Limit the amount of frames in our output queue
-   * to avoid processing too many frames ahead.
-   * The DPB * 2 size limit is completely arbitrary. */
   g_mutex_lock (&vtdec->queue_mutex);
-  /* If negotiate() gets called from the output loop (via finish_frame()),
-   * it can attempt to drain and call VTDecompressionSessionWaitForAsynchronousFrames,
-   * which will lock up if we decide to wait in this callback, creating a deadlock. */
-  push_anyway = vtdec->is_flushing || vtdec->is_draining;
-  while (!push_anyway
-      && gst_vec_deque_get_length (vtdec->reorder_queue) >
-      vtdec->dbp_size * 2 + 1) {
-    g_cond_wait (&vtdec->queue_cond, &vtdec->queue_mutex);
-    push_anyway = vtdec->is_flushing || vtdec->is_draining;
-  }
-
-  gst_vec_deque_push_sorted (vtdec->reorder_queue, frame, sort_frames_by_pts,
-      NULL);
+  gst_vec_deque_push_sorted (vtdec->reorder_queue,
+      frame, sort_frames_by_pts, NULL);
   GST_LOG ("pushed frame %d, queue length %" G_GSIZE_FORMAT,
       frame->decode_frame_number,
       gst_vec_deque_get_length (vtdec->reorder_queue));
@@ -1732,12 +1802,6 @@
   /* Only early-return here if we're draining (as that needs to output frames).
    * Flushing doesn't care about errors from downstream. */
   if (!flush && vtdec->downstream_ret != GST_FLOW_OK) {
-    /* Makes sure the output callback won't get stuck waiting for space in the queue */
-    g_mutex_lock (&vtdec->queue_mutex);
-    vtdec->is_flushing = TRUE;
-    g_cond_signal (&vtdec->queue_cond);
-    g_mutex_unlock (&vtdec->queue_mutex);
-
     GST_WARNING_OBJECT (vtdec, "Output loop stopped with error (%s), leaving",
         gst_flow_get_name (vtdec->downstream_ret));
     return vtdec->downstream_ret;
@@ -1770,9 +1834,9 @@
 
   /* This will only pause after all frames are out because is_flushing/is_draining=TRUE */
   gst_vtdec_pause_output_loop (vtdec);
-
   GST_VIDEO_DECODER_STREAM_LOCK (vtdec);
 
+  g_mutex_lock (&vtdec->queue_mutex);
   if (flush) {
     GST_DEBUG_OBJECT (vtdec, "clearing flushing flag");
     vtdec->is_flushing = FALSE;
@@ -1780,13 +1844,11 @@
     GST_DEBUG_OBJECT (vtdec, "clearing draining flag");
     vtdec->is_draining = FALSE;
   }
+  g_cond_signal (&vtdec->queue_cond);
+  g_mutex_unlock (&vtdec->queue_mutex);
 
-  if (vtdec->downstream_ret == GST_FLOW_OK)
-    GST_DEBUG_OBJECT (vtdec, "buffer queue cleaned");
-  else
-    GST_DEBUG_OBJECT (vtdec,
-        "buffer queue not cleaned, output thread returned %s",
-        gst_flow_get_name (vtdec->downstream_ret));
+  GST_DEBUG_OBJECT (vtdec, "output thread returned %s",
+      gst_flow_get_name (vtdec->downstream_ret));
 
   return vtdec->downstream_ret;
 }
@@ -2197,7 +2259,7 @@
   gst_gl_handle_set_context (element, context,
       &vtdec->ctxh->display, &vtdec->ctxh->other_context);
 
-#if defined (APPLEMEDIA_MOLTENVK)
+#ifdef APPLEMEDIA_MOLTENVK
   gst_vulkan_handle_set_context (element, context, NULL, &vtdec->instance);
 #endif
 
@@ -2256,7 +2318,11 @@
   gst_vtdec_init_once ();
 
 #if !TARGET_OS_WATCH
+#if MAC_OS_X_VERSION_MAX_ALLOWED < 140000
+  if (__builtin_available (macOS 10.9, iOS 17.0, tvOS 17.0, *))
+#else
   if (__builtin_available (macOS 10.9, iOS 17.0, tvOS 17.0, visionOS 1.0, *))
+#endif
     rank = GST_RANK_SECONDARY;
 #endif
 
@@ -2269,7 +2335,11 @@
 {
   gst_vtdec_init_once ();
 
+#if MAC_OS_X_VERSION_MAX_ALLOWED < 140000
+  if (__builtin_available (macOS 10.9, iOS 17.0, tvOS 17.0, *)) {
+#else
   if (__builtin_available (macOS 10.9, iOS 17.0, tvOS 17.0, visionOS 1.0, *)) {
+#endif
     return gst_element_register (plugin, "vtdec_hw", GST_RANK_PRIMARY + 1,
         GST_TYPE_VTDEC_HW);
   }

_service:download_files:gst-plugins-bad-1.28.2.tar.xz/sys/applemedia/vtdec.h -> _service:download_files:gst-plugins-bad-1.28.3.tar.xz/sys/applemedia/vtdec.h Changed

_service:download_files:gst-plugins-bad-1.28.2.tar.xz/sys/applemedia/vtenc.c -> _service:download_files:gst-plugins-bad-1.28.3.tar.xz/sys/applemedia/vtenc.c Changed

@@ -155,30 +155,17 @@
 
 #define CMTIME_TO_GST_CLOCK_TIME(time) time.value / (time.timescale / GST_SECOND)
 
-/* define EnableHardwareAcceleratedVideoEncoder in < 10.9 */
-#if defined(MAC_OS_X_VERSION_MAX_ALLOWED) && MAC_OS_X_VERSION_MAX_ALLOWED < 1090
-const CFStringRef
-    kVTVideoEncoderSpecification_EnableHardwareAcceleratedVideoEncoder =
-CFSTR ("EnableHardwareAcceleratedVideoEncoder");
-const CFStringRef
-    kVTVideoEncoderSpecification_RequireHardwareAcceleratedVideoEncoder =
-CFSTR ("RequireHardwareAcceleratedVideoEncoder");
-const CFStringRef kVTCompressionPropertyKey_ProfileLevel =
-CFSTR ("ProfileLevel");
-const CFStringRef kVTProfileLevel_H264_Baseline_AutoLevel =
-CFSTR ("H264_Baseline_AutoLevel");
-#endif
-
-#if defined(MAC_OS_X_VERSION_MAX_ALLOWED) && MAC_OS_X_VERSION_MAX_ALLOWED < 1080
-const CFStringRef kVTCompressionPropertyKey_Quality = CFSTR ("Quality");
-#endif
-
 /* This property key is currently completely undocumented. The only way you can
  * know about its existence is if Apple tells you. It allows you to tell the
  * encoder to not preserve alpha even when outputting alpha formats. */
 const CFStringRef gstVTCodecPropertyKey_PreserveAlphaChannel =
 CFSTR ("kVTCodecPropertyKey_PreserveAlphaChannel");
 
+#if MAC_OS_X_VERSION_MAX_ALLOWED < 130000
+const CFStringRef kVTCompressionPropertyKey_ConstantBitRate =
+CFSTR ("ConstantBitrate");
+#endif
+
 enum
 {
   PROP_0,
@@ -338,10 +325,10 @@
     }
 
     if (enable_argb) {
-      caps = gst_vtutil_caps_append_video_format (caps, "ARGB64_BE");
+      caps = gst_vtutil_caps_append_video_format (caps, "ARGB64_BE", NULL);
       /* RGBA64_LE is kCVPixelFormatType_64RGBALE, only available on macOS 11.3+ */
       if (GST_APPLEMEDIA_HAVE_64RGBALE)
-        caps = gst_vtutil_caps_append_video_format (caps, "RGBA64_LE");
+        caps = gst_vtutil_caps_append_video_format (caps, "RGBA64_LE", NULL);
     }
 #endif
     gst_element_class_add_pad_template (element_class,
@@ -1633,7 +1620,11 @@
     self->dump_properties = FALSE;
   }
 #if !TARGET_OS_WATCH
-  if (__builtin_available (ios 8.0, macos 10.9, tvos 10.2, visionos 1.0, *)) {
+#if MAC_OS_X_VERSION_MAX_ALLOWED < 140000
+  if (__builtin_available (iOS 8.0, macOS 10.9, tvOS 10.2, *)) {
+#else
+  if (__builtin_available (iOS 8.0, macOS 10.9, tvOS 10.2, visionOS 1.0, *)) {
+#endif
     status = VTCompressionSessionPrepareToEncodeFrames (session);
     if (status != noErr) {
       GST_ERROR_OBJECT (self,
@@ -1774,7 +1765,11 @@
     /*
      * In addition to the OS requirements, CBR also requires Apple Silicon
      */
+#if MAC_OS_X_VERSION_MAX_ALLOWED < 140000
+    if (__builtin_available (macOS 13.0, iOS 16.0, tvOS 16.0, *)) {
+#else
     if (__builtin_available (macOS 13.0, iOS 16.0, tvOS 16.0, visionOS 1.0, *)) {
+#endif
       key = kVTCompressionPropertyKey_ConstantBitRate;
     } else
 #endif

_service:download_files:gst-plugins-bad-1.28.2.tar.xz/sys/applemedia/vtutil.c -> _service:download_files:gst-plugins-bad-1.28.3.tar.xz/sys/applemedia/vtutil.c Changed

@@ -18,15 +18,16 @@
  */
 
 #include "vtutil.h"
+
+#include <dlfcn.h>
 #include <VideoToolbox/VideoToolbox.h>
 #include <TargetConditionals.h>
 
 #if TARGET_OS_OSX || TARGET_OS_IOS || TARGET_OS_TV || TARGET_OS_VISION
 #define HAVE_SUPPLEMENTAL
-#if (TARGET_OS_OSX && __MAC_OS_X_VERSION_MAX_ALLOWED >= 110000) || (TARGET_OS_IOS && __IPHONE_OS_VERSION_MAX_ALLOWED >= 260200) || (TARGET_OS_TV && __TV_OS_VERSION_MAX_ALLOWED >= 260200) || (TARGET_OS_VISION && __VISION_OS_VERSION_MAX_ALLOWED >= 260200)
+/* Added in Xcode 12 for macOS and in Xcode 26.2 for iPhone/tvOS/visionOS */
+#if (TARGET_OS_OSX && MAC_OS_X_VERSION_MAX_ALLOWED >= 110000) || __IPHONE_OS_VERSION_MAX_ALLOWED >= 260200
 #define HAVE_SUPPLEMENTAL_DEFINITION
-#else
-#include <dlfcn.h>
 #endif
 #endif
 
@@ -148,26 +149,38 @@
 }
 
 GstCaps *
-gst_vtutil_caps_append_video_format (GstCaps * caps, const char *vfmt)
+gst_vtutil_caps_append_video_format (GstCaps * caps, const char *vfmt,
+    const char *features_filter)
 {
-  GstStructure *s;
-  GValueArray *arr;
+  guint i;
   GValue val = G_VALUE_INIT;
 
   caps = gst_caps_make_writable (caps);
-  s = gst_caps_get_structure (caps, 0);
-  gst_structure_get_list (s, "format", &arr);
-
   g_value_init (&val, G_TYPE_STRING);
-
   g_value_set_string (&val, vfmt);
-  G_GNUC_BEGIN_IGNORE_DEPRECATIONS;
-  arr = g_value_array_append (arr, &val);
-  G_GNUC_END_IGNORE_DEPRECATIONS;
+
+  for (i = 0; i < gst_caps_get_size (caps); i++) {
+    GstCapsFeatures *features;
+    GstStructure *s;
+    GValueArray *arr;
+
+    features = gst_caps_get_features (caps, i);
+    if (features_filter &&
+        (!features || !gst_caps_features_contains (features, features_filter)))
+      continue;
+
+    s = gst_caps_get_structure (caps, i);
+    gst_structure_get_list (s, "format", &arr);
+
+    G_GNUC_BEGIN_IGNORE_DEPRECATIONS;
+    arr = g_value_array_append (arr, &val);
+    G_GNUC_END_IGNORE_DEPRECATIONS;
+
+    gst_structure_set_list (s, "format", arr);
+  }
 
   g_value_unset (&val);
 
-  gst_structure_set_list (s, "format", arr);
   return caps;
 }
 
@@ -182,7 +195,11 @@
 
 #ifdef HAVE_SUPPLEMENTAL
 #ifdef HAVE_SUPPLEMENTAL_DEFINITION
+#if MAC_OS_X_VERSION_MAX_ALLOWED < 140000
+  if (__builtin_available (macOS 11.0, iOS 26.2, tvOS 26.2, *)) {
+#else
   if (__builtin_available (macOS 11.0, iOS 26.2, tvOS 26.2, visionOS 26.2, *)) {
+#endif
     GST_INFO ("Registering supplemental VideoToolbox decoder by direct call");
     VTRegisterSupplementalVideoDecoderIfAvailable (codec_type);
     return TRUE;

_service:download_files:gst-plugins-bad-1.28.2.tar.xz/sys/applemedia/vtutil.h -> _service:download_files:gst-plugins-bad-1.28.3.tar.xz/sys/applemedia/vtutil.h Changed

_service:download_files:gst-plugins-bad-1.28.2.tar.xz/sys/decklink/gstdecklink.cpp -> _service:download_files:gst-plugins-bad-1.28.3.tar.xz/sys/decklink/gstdecklink.cpp Changed

_service:download_files:gst-plugins-bad-1.28.2.tar.xz/sys/decklink/gstdecklinkvideosink.cpp -> _service:download_files:gst-plugins-bad-1.28.3.tar.xz/sys/decklink/gstdecklinkvideosink.cpp Changed

_service:download_files:gst-plugins-bad-1.28.2.tar.xz/sys/hip/kernel/converter.cu -> _service:download_files:gst-plugins-bad-1.28.3.tar.xz/sys/hip/kernel/converter.cu Changed

@@ -80,31 +80,31 @@
 __device__ inline unsigned char
 scale_to_2bits (float val)
 {
-  return (unsigned short) __float2int_rz (val * 3.0);
+  return (unsigned short) __float2int_rz (val * 3.0f);
 }
 
 __device__ inline unsigned char
 scale_to_uchar (float val)
 {
-  return (unsigned char) __float2int_rz (val * 255.0);
+  return (unsigned char) __float2int_rz (val * 255.0f);
 }
 
 __device__ inline unsigned short
 scale_to_ushort (float val)
 {
-  return (unsigned short) __float2int_rz (val * 65535.0);
+  return (unsigned short) __float2int_rz (val * 65535.0f);
 }
 
 __device__ inline unsigned short
 scale_to_10bits (float val)
 {
-  return (unsigned short) __float2int_rz (val * 1023.0);
+  return (unsigned short) __float2int_rz (val * 1023.0f);
 }
 
 __device__ inline unsigned short
 scale_to_12bits (float val)
 {
-  return (unsigned short) __float2int_rz (val * 4095.0);
+  return (unsigned short) __float2int_rz (val * 4095.0f);
 }
 
 __device__ inline unsigned char
@@ -112,8 +112,8 @@
 {
   // DstColor' = SrcA * SrcColor + (1 - SrcA) DstColor
   float src_val = src * src_alpha;
-  float dst_val = __int2float_rz (dst) / 255.0 * (1.0 - src_alpha);
-  return scale_to_uchar(clamp(src_val + dst_val, 0, 1.0));
+  float dst_val = __int2float_rz (dst) / 255.0f * (1.0f - src_alpha);
+  return scale_to_uchar(clamp(src_val + dst_val, 0, 1.0f));
 }
 
 __device__ inline unsigned short
@@ -121,8 +121,8 @@
 {
   // DstColor' = SrcA * SrcColor + (1 - SrcA) DstColor
   float src_val = src * src_alpha;
-  float dst_val = __int2float_rz (dst) / 65535.0 * (1.0 - src_alpha);
-  return scale_to_ushort(clamp(src_val + dst_val, 0, 1.0));
+  float dst_val = __int2float_rz (dst) / 65535.0f * (1.0f - src_alpha);
+  return scale_to_ushort(clamp(src_val + dst_val, 0, 1.0f));
 }
 
 __device__ inline unsigned short
@@ -130,8 +130,8 @@
 {
   // DstColor' = SrcA * SrcColor + (1 - SrcA) DstColor
   float src_val = src * src_alpha;
-  float dst_val = __int2float_rz (dst) / 1023.0 * (1.0 - src_alpha);
-  return scale_to_10bits(clamp(src_val + dst_val, 0, 1.0));
+  float dst_val = __int2float_rz (dst) / 1023.0f * (1.0f - src_alpha);
+  return scale_to_10bits(clamp(src_val + dst_val, 0, 1.0f));
 }
 
 __device__ inline unsigned short
@@ -139,8 +139,8 @@
 {
   // DstColor' = SrcA * SrcColor + (1 - SrcA) DstColor
   float src_val = src * src_alpha;
-  float dst_val = __int2float_rz (dst) / 4095.0 * (1.0 - src_alpha);
-  return scale_to_12bits(clamp(src_val + dst_val, 0, 1.0));
+  float dst_val = __int2float_rz (dst) / 4095.0f * (1.0f - src_alpha);
+  return scale_to_12bits(clamp(src_val + dst_val, 0, 1.0f));
 }
 
 struct IConverter
@@ -772,7 +772,7 @@
     dst0pos = blend_uchar (dst0pos, sample.x, sample.w);
     dst0pos + 1 = blend_uchar (dst0pos + 1, sample.y, sample.w);
     dst0pos + 2 = blend_uchar (dst0pos + 2, sample.z, sample.w);
-    dst0pos + 3 = blend_uchar (dst0pos + 3, 1.0, sample.w);
+    dst0pos + 3 = blend_uchar (dst0pos + 3, 1.0f, sample.w);
   }
 };
 
@@ -826,7 +826,7 @@
     dst0pos = blend_uchar (dst0pos, sample.z, sample.w);
     dst0pos + 1 = blend_uchar (dst0pos + 1, sample.y, sample.w);
     dst0pos + 2 = blend_uchar (dst0pos + 2, sample.x, sample.w);
-    dst0pos + 3 = blend_uchar (dst0pos + 3, 1.0, sample.w);
+    dst0pos + 3 = blend_uchar (dst0pos + 3, 1.0f, sample.w);
   }
 };
 
@@ -877,7 +877,7 @@
       int stride1)
   {
     int pos = x * 4 + y * stride0;
-    dst0pos = blend_uchar (dst0pos, 1.0, sample.w);
+    dst0pos = blend_uchar (dst0pos, 1.0f, sample.w);
     dst0pos + 1 = blend_uchar (dst0pos + 1, sample.x, sample.w);
     dst0pos + 2 = blend_uchar (dst0pos + 2, sample.y, sample.w);
     dst0pos + 3 = blend_uchar (dst0pos + 3, sample.z, sample.w);
@@ -904,7 +904,7 @@
       int stride1)
   {
     int pos = x * 4 + y * stride0;
-    dst0pos = blend_uchar (dst0pos, 1.0, sample.w);
+    dst0pos = blend_uchar (dst0pos, 1.0f, sample.w);
     dst0pos + 1 = blend_uchar (dst0pos + 1, sample.z, sample.w);
     dst0pos + 2 = blend_uchar (dst0pos + 2, sample.y, sample.w);
     dst0pos + 3 = blend_uchar (dst0pos + 3, sample.x, sample.w);
@@ -1327,7 +1327,7 @@
     dst0pos = blend_uchar (dst0pos, sample.y, sample.w);
     dst1pos = blend_uchar (dst1pos, sample.z, sample.w);
     dst2pos = blend_uchar (dst2pos, sample.x, sample.w);
-    dst3pos = blend_uchar (dst3pos, 1.0, sample.w);
+    dst3pos = blend_uchar (dst3pos, 1.0f, sample.w);
   }
 };
 
@@ -1354,7 +1354,7 @@
     dst0pos = blend_uchar (dst0pos, sample.z, sample.w);
     dst0pos + 1 = blend_uchar (dst0pos + 1, sample.y, sample.w);
     dst0pos + 2 = blend_uchar (dst0pos + 2, sample.x, sample.w);
-    dst0pos + 3 = blend_uchar (dst0pos + 3, 1.0, sample.w);
+    dst0pos + 3 = blend_uchar (dst0pos + 3, 1.0f, sample.w);
   }
 };
 
@@ -1367,31 +1367,31 @@
 __device__ inline float2
 rotate_90r (float x, float y)
 {
-  return make_float2(y, 1.0 - x);
+  return make_float2(y, 1.0f - x);
 }
 
 __device__ inline float2
 rotate_180 (float x, float y)
 {
-  return make_float2(1.0 - x, 1.0 - y);
+  return make_float2(1.0f - x, 1.0f - y);
 }
 
 __device__ inline float2
 rotate_90l (float x, float y)
 {
-  return make_float2(1.0 - y, x);
+  return make_float2(1.0f - y, x);
 }
 
 __device__ inline float2
 rotate_horiz (float x, float y)
 {
-  return make_float2(1.0 - x, y);
+  return make_float2(1.0f - x, y);
 }
 
 __device__ inline float2
 rotate_vert (float x, float y)
 {
-  return make_float2(x, 1.0 - y);
+  return make_float2(x, 1.0f - y);
 }
 
 __device__ inline float2
@@ -1403,7 +1403,7 @@
 __device__ inline float2
 rotate_ur_ll (float x, float y)
 {
-  return make_float2(1.0 - y, 1.0 - x);
+  return make_float2(1.0f - y, 1.0f - x);
 }
 __device__ inline float2
 do_rotate (float x, float y, int direction)
@@ -1451,11 +1451,11 @@
     sample = make_float4 (const_buf.border_x, const_buf.border_y,
        const_buf.border_z, const_buf.border_w);
   } else {
-    float x = (__int2float_rz (x_pos - const_buf.left) + 0.5) / const_buf.view_width;
-    if (x < 0.0 || x > 1.0)
+    float x = (__int2float_rz (x_pos - const_buf.left) + 0.5f) / const_buf.view_width;
+    if (x < 0.0f || x > 1.0f)
       return;
-    float y = (__int2float_rz (y_pos - const_buf.top) + 0.5) / const_buf.view_height;
-    if (y < 0.0 || y > 1.0)
+    float y = (__int2float_rz (y_pos - const_buf.top) + 0.5f) / const_buf.view_height;
+    if (y < 0.0f || y > 1.0f)
       return;
     float2 rotated = do_rotate (x, y, const_buf.video_direction);
     float4 s = g_sampler.Execute (tex0, tex1, tex2, tex3, rotated.x, rotated.y);
@@ -1532,31 +1532,31 @@
 "__device__ inline unsigned char\n"
 "scale_to_2bits (float val)\n"
 "{\n"
-"  return (unsigned short) __float2int_rz (val * 3.0);\n"
+"  return (unsigned short) __float2int_rz (val * 3.0f);\n"
 "}\n"
 "\n"
 "__device__ inline unsigned char\n"
 "scale_to_uchar (float val)\n"
 "{\n"
-"  return (unsigned char) __float2int_rz (val * 255.0);\n"
+"  return (unsigned char) __float2int_rz (val * 255.0f);\n"
 "}\n"
 "\n"
 "__device__ inline unsigned short\n"
 "scale_to_ushort (float val)\n"
 "{\n"
-"  return (unsigned short) __float2int_rz (val * 65535.0);\n"
+"  return (unsigned short) __float2int_rz (val * 65535.0f);\n"
 "}\n"
 "\n"
 "__device__ inline unsigned short\n"
 "scale_to_10bits (float val)\n"
 "{\n"
-"  return (unsigned short) __float2int_rz (val * 1023.0);\n"
+"  return (unsigned short) __float2int_rz (val * 1023.0f);\n"
 "}\n"
 "\n"
 "__device__ inline unsigned short\n"
 "scale_to_12bits (float val)\n"
 "{\n"
-"  return (unsigned short) __float2int_rz (val * 4095.0);\n"
+"  return (unsigned short) __float2int_rz (val * 4095.0f);\n"
 "}\n"
 "\n"
 "__device__ inline unsigned char\n"
@@ -1564,8 +1564,8 @@
 "{\n"
 "  // DstColor' = SrcA * SrcColor + (1 - SrcA) DstColor\n"
 "  float src_val = src * src_alpha;\n"
-"  float dst_val = __int2float_rz (dst) / 255.0 * (1.0 - src_alpha);\n"
-"  return scale_to_uchar(clamp(src_val + dst_val, 0, 1.0));\n"
+"  float dst_val = __int2float_rz (dst) / 255.0f * (1.0f - src_alpha);\n"
+"  return scale_to_uchar(clamp(src_val + dst_val, 0, 1.0f));\n"
 "}\n"
 "\n"
 "__device__ inline unsigned short\n"
@@ -1573,8 +1573,8 @@
 "{\n"
 "  // DstColor' = SrcA * SrcColor + (1 - SrcA) DstColor\n"
 "  float src_val = src * src_alpha;\n"
-"  float dst_val = __int2float_rz (dst) / 65535.0 * (1.0 - src_alpha);\n"
-"  return scale_to_ushort(clamp(src_val + dst_val, 0, 1.0));\n"
+"  float dst_val = __int2float_rz (dst) / 65535.0f * (1.0f - src_alpha);\n"
+"  return scale_to_ushort(clamp(src_val + dst_val, 0, 1.0f));\n"
 "}\n"
 "\n"
 "__device__ inline unsigned short\n"
@@ -1582,8 +1582,8 @@
 "{\n"
 "  // DstColor' = SrcA * SrcColor + (1 - SrcA) DstColor\n"
 "  float src_val = src * src_alpha;\n"
-"  float dst_val = __int2float_rz (dst) / 1023.0 * (1.0 - src_alpha);\n"
-"  return scale_to_10bits(clamp(src_val + dst_val, 0, 1.0));\n"
+"  float dst_val = __int2float_rz (dst) / 1023.0f * (1.0f - src_alpha);\n"
+"  return scale_to_10bits(clamp(src_val + dst_val, 0, 1.0f));\n"
 "}\n"
 "\n"
 "__device__ inline unsigned short\n"
@@ -1591,8 +1591,8 @@
 "{\n"
 "  // DstColor' = SrcA * SrcColor + (1 - SrcA) DstColor\n"
 "  float src_val = src * src_alpha;\n"
-"  float dst_val = __int2float_rz (dst) / 4095.0 * (1.0 - src_alpha);\n"
-"  return scale_to_12bits(clamp(src_val + dst_val, 0, 1.0));\n"
+"  float dst_val = __int2float_rz (dst) / 4095.0f * (1.0f - src_alpha);\n"
+"  return scale_to_12bits(clamp(src_val + dst_val, 0, 1.0f));\n"
 "}\n"
 "\n"
 "struct IConverter\n"
@@ -2224,7 +2224,7 @@
 "    dst0pos = blend_uchar (dst0pos, sample.x, sample.w);\n"
 "    dst0pos + 1 = blend_uchar (dst0pos + 1, sample.y, sample.w);\n"
 "    dst0pos + 2 = blend_uchar (dst0pos + 2, sample.z, sample.w);\n"
-"    dst0pos + 3 = blend_uchar (dst0pos + 3, 1.0, sample.w);\n"
+"    dst0pos + 3 = blend_uchar (dst0pos + 3, 1.0f, sample.w);\n"
 "  }\n"
 "};\n"
 "\n"
@@ -2278,7 +2278,7 @@
 "    dst0pos = blend_uchar (dst0pos, sample.z, sample.w);\n"
 "    dst0pos + 1 = blend_uchar (dst0pos + 1, sample.y, sample.w);\n"
 "    dst0pos + 2 = blend_uchar (dst0pos + 2, sample.x, sample.w);\n"
-"    dst0pos + 3 = blend_uchar (dst0pos + 3, 1.0, sample.w);\n"
+"    dst0pos + 3 = blend_uchar (dst0pos + 3, 1.0f, sample.w);\n"
 "  }\n"
 "};\n"
 "\n"
@@ -2329,7 +2329,7 @@
 "      int stride1)\n"
 "  {\n"
 "    int pos = x * 4 + y * stride0;\n"
-"    dst0pos = blend_uchar (dst0pos, 1.0, sample.w);\n"
+"    dst0pos = blend_uchar (dst0pos, 1.0f, sample.w);\n"
 "    dst0pos + 1 = blend_uchar (dst0pos + 1, sample.x, sample.w);\n"
 "    dst0pos + 2 = blend_uchar (dst0pos + 2, sample.y, sample.w);\n"
 "    dst0pos + 3 = blend_uchar (dst0pos + 3, sample.z, sample.w);\n"
@@ -2356,7 +2356,7 @@
 "      int stride1)\n"
 "  {\n"
 "    int pos = x * 4 + y * stride0;\n"
-"    dst0pos = blend_uchar (dst0pos, 1.0, sample.w);\n"
+"    dst0pos = blend_uchar (dst0pos, 1.0f, sample.w);\n"
 "    dst0pos + 1 = blend_uchar (dst0pos + 1, sample.z, sample.w);\n"
 "    dst0pos + 2 = blend_uchar (dst0pos + 2, sample.y, sample.w);\n"
 "    dst0pos + 3 = blend_uchar (dst0pos + 3, sample.x, sample.w);\n"
@@ -2779,7 +2779,7 @@
 "    dst0pos = blend_uchar (dst0pos, sample.y, sample.w);\n"
 "    dst1pos = blend_uchar (dst1pos, sample.z, sample.w);\n"
 "    dst2pos = blend_uchar (dst2pos, sample.x, sample.w);\n"
-"    dst3pos = blend_uchar (dst3pos, 1.0, sample.w);\n"
+"    dst3pos = blend_uchar (dst3pos, 1.0f, sample.w);\n"
 "  }\n"
 "};\n"
 "\n"
@@ -2806,7 +2806,7 @@
 "    dst0pos = blend_uchar (dst0pos, sample.z, sample.w);\n"
 "    dst0pos + 1 = blend_uchar (dst0pos + 1, sample.y, sample.w);\n"
 "    dst0pos + 2 = blend_uchar (dst0pos + 2, sample.x, sample.w);\n"
-"    dst0pos + 3 = blend_uchar (dst0pos + 3, 1.0, sample.w);\n"
+"    dst0pos + 3 = blend_uchar (dst0pos + 3, 1.0f, sample.w);\n"
 "  }\n"
 "};\n"
 "\n"
@@ -2819,31 +2819,31 @@
 "__device__ inline float2\n"
 "rotate_90r (float x, float y)\n"
 "{\n"
-"  return make_float2(y, 1.0 - x);\n"
+"  return make_float2(y, 1.0f - x);\n"
 "}\n"
 "\n"
 "__device__ inline float2\n"
 "rotate_180 (float x, float y)\n"
 "{\n"
-"  return make_float2(1.0 - x, 1.0 - y);\n"
+"  return make_float2(1.0f - x, 1.0f - y);\n"
 "}\n"
 "\n"
 "__device__ inline float2\n"
 "rotate_90l (float x, float y)\n"
 "{\n"
-"  return make_float2(1.0 - y, x);\n"
+"  return make_float2(1.0f - y, x);\n"
 "}\n"
 "\n"
 "__device__ inline float2\n"
 "rotate_horiz (float x, float y)\n"
 "{\n"
-"  return make_float2(1.0 - x, y);\n"
+"  return make_float2(1.0f - x, y);\n"
 "}\n"
 "\n"
 "__device__ inline float2\n"
 "rotate_vert (float x, float y)\n"
 "{\n"
-"  return make_float2(x, 1.0 - y);\n"
+"  return make_float2(x, 1.0f - y);\n"
 "}\n"
 "\n"
 "__device__ inline float2\n"
@@ -2855,7 +2855,7 @@
 "__device__ inline float2\n"
 "rotate_ur_ll (float x, float y)\n"
 "{\n"
-"  return make_float2(1.0 - y, 1.0 - x);\n"
+"  return make_float2(1.0f - y, 1.0f - x);\n"
 "}\n"
 "__device__ inline float2\n"
 "do_rotate (float x, float y, int direction)\n"
@@ -2903,11 +2903,11 @@
 "    sample = make_float4 (const_buf.border_x, const_buf.border_y,\n"
 "       const_buf.border_z, const_buf.border_w);\n"
 "  } else {\n"
-"    float x = (__int2float_rz (x_pos - const_buf.left) + 0.5) / const_buf.view_width;\n"
-"    if (x < 0.0 || x > 1.0)\n"
+"    float x = (__int2float_rz (x_pos - const_buf.left) + 0.5f) / const_buf.view_width;\n"
+"    if (x < 0.0f || x > 1.0f)\n"
 "      return;\n"
-"    float y = (__int2float_rz (y_pos - const_buf.top) + 0.5) / const_buf.view_height;\n"
-"    if (y < 0.0 || y > 1.0)\n"
+"    float y = (__int2float_rz (y_pos - const_buf.top) + 0.5f) / const_buf.view_height;\n"
+"    if (y < 0.0f || y > 1.0f)\n"
 "      return;\n"
 "    float2 rotated = do_rotate (x, y, const_buf.video_direction);\n"
 "    float4 s = g_sampler.Execute (tex0, tex1, tex2, tex3, rotated.x, rotated.y);\n"

_service:download_files:gst-plugins-bad-1.28.2.tar.xz/sys/nvcodec/kernel/gstcudaconverter.cu -> _service:download_files:gst-plugins-bad-1.28.3.tar.xz/sys/nvcodec/kernel/gstcudaconverter.cu Changed

@@ -75,31 +75,31 @@
 __device__ inline unsigned char
 scale_to_2bits (float val)
 {
-  return (unsigned short) __float2int_rz (val * 3.0);
+  return (unsigned short) __float2int_rz (val * 3.0f);
 }
 
 __device__ inline unsigned char
 scale_to_uchar (float val)
 {
-  return (unsigned char) __float2int_rz (val * 255.0);
+  return (unsigned char) __float2int_rz (val * 255.0f);
 }
 
 __device__ inline unsigned short
 scale_to_ushort (float val)
 {
-  return (unsigned short) __float2int_rz (val * 65535.0);
+  return (unsigned short) __float2int_rz (val * 65535.0f);
 }
 
 __device__ inline unsigned short
 scale_to_10bits (float val)
 {
-  return (unsigned short) __float2int_rz (val * 1023.0);
+  return (unsigned short) __float2int_rz (val * 1023.0f);
 }
 
 __device__ inline unsigned short
 scale_to_12bits (float val)
 {
-  return (unsigned short) __float2int_rz (val * 4095.0);
+  return (unsigned short) __float2int_rz (val * 4095.0f);
 }
 
 __device__ inline unsigned char
@@ -107,8 +107,8 @@
 {
   // DstColor' = SrcA * SrcColor + (1 - SrcA) DstColor
   float src_val = src * src_alpha;
-  float dst_val = __int2float_rz (dst) / 255.0 * (1.0 - src_alpha);
-  return scale_to_uchar(clamp(src_val + dst_val, 0, 1.0));
+  float dst_val = __int2float_rz (dst) / 255.0f * (1.0f - src_alpha);
+  return scale_to_uchar(clamp(src_val + dst_val, 0, 1.0f));
 }
 
 __device__ inline unsigned short
@@ -116,8 +116,8 @@
 {
   // DstColor' = SrcA * SrcColor + (1 - SrcA) DstColor
   float src_val = src * src_alpha;
-  float dst_val = __int2float_rz (dst) / 65535.0 * (1.0 - src_alpha);
-  return scale_to_ushort(clamp(src_val + dst_val, 0, 1.0));
+  float dst_val = __int2float_rz (dst) / 65535.0f * (1.0f - src_alpha);
+  return scale_to_ushort(clamp(src_val + dst_val, 0, 1.0f));
 }
 
 __device__ inline unsigned short
@@ -125,8 +125,8 @@
 {
   // DstColor' = SrcA * SrcColor + (1 - SrcA) DstColor
   float src_val = src * src_alpha;
-  float dst_val = __int2float_rz (dst) / 1023.0 * (1.0 - src_alpha);
-  return scale_to_10bits(clamp(src_val + dst_val, 0, 1.0));
+  float dst_val = __int2float_rz (dst) / 1023.0f * (1.0f - src_alpha);
+  return scale_to_10bits(clamp(src_val + dst_val, 0, 1.0f));
 }
 
 __device__ inline unsigned short
@@ -134,8 +134,8 @@
 {
   // DstColor' = SrcA * SrcColor + (1 - SrcA) DstColor
   float src_val = src * src_alpha;
-  float dst_val = __int2float_rz (dst) / 4095.0 * (1.0 - src_alpha);
-  return scale_to_12bits(clamp(src_val + dst_val, 0, 1.0));
+  float dst_val = __int2float_rz (dst) / 4095.0f * (1.0f - src_alpha);
+  return scale_to_12bits(clamp(src_val + dst_val, 0, 1.0f));
 }
 
 struct IConverter
@@ -767,7 +767,7 @@
     dst0pos = blend_uchar (dst0pos, sample.x, sample.w);
     dst0pos + 1 = blend_uchar (dst0pos + 1, sample.y, sample.w);
     dst0pos + 2 = blend_uchar (dst0pos + 2, sample.z, sample.w);
-    dst0pos + 3 = blend_uchar (dst0pos + 3, 1.0, sample.w);
+    dst0pos + 3 = blend_uchar (dst0pos + 3, 1.0f, sample.w);
   }
 };
 
@@ -821,7 +821,7 @@
     dst0pos = blend_uchar (dst0pos, sample.z, sample.w);
     dst0pos + 1 = blend_uchar (dst0pos + 1, sample.y, sample.w);
     dst0pos + 2 = blend_uchar (dst0pos + 2, sample.x, sample.w);
-    dst0pos + 3 = blend_uchar (dst0pos + 3, 1.0, sample.w);
+    dst0pos + 3 = blend_uchar (dst0pos + 3, 1.0f, sample.w);
   }
 };
 
@@ -872,7 +872,7 @@
       int stride1)
   {
     int pos = x * 4 + y * stride0;
-    dst0pos = blend_uchar (dst0pos, 1.0, sample.w);
+    dst0pos = blend_uchar (dst0pos, 1.0f, sample.w);
     dst0pos + 1 = blend_uchar (dst0pos + 1, sample.x, sample.w);
     dst0pos + 2 = blend_uchar (dst0pos + 2, sample.y, sample.w);
     dst0pos + 3 = blend_uchar (dst0pos + 3, sample.z, sample.w);
@@ -899,7 +899,7 @@
       int stride1)
   {
     int pos = x * 4 + y * stride0;
-    dst0pos = blend_uchar (dst0pos, 1.0, sample.w);
+    dst0pos = blend_uchar (dst0pos, 1.0f, sample.w);
     dst0pos + 1 = blend_uchar (dst0pos + 1, sample.z, sample.w);
     dst0pos + 2 = blend_uchar (dst0pos + 2, sample.y, sample.w);
     dst0pos + 3 = blend_uchar (dst0pos + 3, sample.x, sample.w);
@@ -1322,7 +1322,7 @@
     dst0pos = blend_uchar (dst0pos, sample.y, sample.w);
     dst1pos = blend_uchar (dst1pos, sample.z, sample.w);
     dst2pos = blend_uchar (dst2pos, sample.x, sample.w);
-    dst3pos = blend_uchar (dst3pos, 1.0, sample.w);
+    dst3pos = blend_uchar (dst3pos, 1.0f, sample.w);
   }
 };
 
@@ -1349,7 +1349,7 @@
     dst0pos = blend_uchar (dst0pos, sample.z, sample.w);
     dst0pos + 1 = blend_uchar (dst0pos + 1, sample.y, sample.w);
     dst0pos + 2 = blend_uchar (dst0pos + 2, sample.x, sample.w);
-    dst0pos + 3 = blend_uchar (dst0pos + 3, 1.0, sample.w);
+    dst0pos + 3 = blend_uchar (dst0pos + 3, 1.0f, sample.w);
   }
 };
 
@@ -1376,11 +1376,11 @@
     sample = make_float4 (const_buf.border_x, const_buf.border_y,
        const_buf.border_z, const_buf.border_w);
   } else {
-    float x = (__int2float_rz (x_pos - const_buf.left) + 0.5) / const_buf.view_width;
-    if (x < 0.0 || x > 1.0)
+    float x = (__int2float_rz (x_pos - const_buf.left) + 0.5f) / const_buf.view_width;
+    if (x < 0.0f || x > 1.0f)
       return;
-    float y = (__int2float_rz (y_pos - const_buf.top) + 0.5) / const_buf.view_height;
-    if (y < 0.0 || y > 1.0)
+    float y = (__int2float_rz (y_pos - const_buf.top) + 0.5f) / const_buf.view_height;
+    if (y < 0.0f || y > 1.0f)
       return;
     float2 rotated;
     rotated.x = fmaf (x, const_buf.transform_u0,
@@ -1463,31 +1463,31 @@
 "__device__ inline unsigned char\n"
 "scale_to_2bits (float val)\n"
 "{\n"
-"  return (unsigned short) __float2int_rz (val * 3.0);\n"
+"  return (unsigned short) __float2int_rz (val * 3.0f);\n"
 "}\n"
 "\n"
 "__device__ inline unsigned char\n"
 "scale_to_uchar (float val)\n"
 "{\n"
-"  return (unsigned char) __float2int_rz (val * 255.0);\n"
+"  return (unsigned char) __float2int_rz (val * 255.0f);\n"
 "}\n"
 "\n"
 "__device__ inline unsigned short\n"
 "scale_to_ushort (float val)\n"
 "{\n"
-"  return (unsigned short) __float2int_rz (val * 65535.0);\n"
+"  return (unsigned short) __float2int_rz (val * 65535.0f);\n"
 "}\n"
 "\n"
 "__device__ inline unsigned short\n"
 "scale_to_10bits (float val)\n"
 "{\n"
-"  return (unsigned short) __float2int_rz (val * 1023.0);\n"
+"  return (unsigned short) __float2int_rz (val * 1023.0f);\n"
 "}\n"
 "\n"
 "__device__ inline unsigned short\n"
 "scale_to_12bits (float val)\n"
 "{\n"
-"  return (unsigned short) __float2int_rz (val * 4095.0);\n"
+"  return (unsigned short) __float2int_rz (val * 4095.0f);\n"
 "}\n"
 "\n"
 "__device__ inline unsigned char\n"
@@ -1495,8 +1495,8 @@
 "{\n"
 "  // DstColor' = SrcA * SrcColor + (1 - SrcA) DstColor\n"
 "  float src_val = src * src_alpha;\n"
-"  float dst_val = __int2float_rz (dst) / 255.0 * (1.0 - src_alpha);\n"
-"  return scale_to_uchar(clamp(src_val + dst_val, 0, 1.0));\n"
+"  float dst_val = __int2float_rz (dst) / 255.0f * (1.0f - src_alpha);\n"
+"  return scale_to_uchar(clamp(src_val + dst_val, 0, 1.0f));\n"
 "}\n"
 "\n"
 "__device__ inline unsigned short\n"
@@ -1504,8 +1504,8 @@
 "{\n"
 "  // DstColor' = SrcA * SrcColor + (1 - SrcA) DstColor\n"
 "  float src_val = src * src_alpha;\n"
-"  float dst_val = __int2float_rz (dst) / 65535.0 * (1.0 - src_alpha);\n"
-"  return scale_to_ushort(clamp(src_val + dst_val, 0, 1.0));\n"
+"  float dst_val = __int2float_rz (dst) / 65535.0f * (1.0f - src_alpha);\n"
+"  return scale_to_ushort(clamp(src_val + dst_val, 0, 1.0f));\n"
 "}\n"
 "\n"
 "__device__ inline unsigned short\n"
@@ -1513,8 +1513,8 @@
 "{\n"
 "  // DstColor' = SrcA * SrcColor + (1 - SrcA) DstColor\n"
 "  float src_val = src * src_alpha;\n"
-"  float dst_val = __int2float_rz (dst) / 1023.0 * (1.0 - src_alpha);\n"
-"  return scale_to_10bits(clamp(src_val + dst_val, 0, 1.0));\n"
+"  float dst_val = __int2float_rz (dst) / 1023.0f * (1.0f - src_alpha);\n"
+"  return scale_to_10bits(clamp(src_val + dst_val, 0, 1.0f));\n"
 "}\n"
 "\n"
 "__device__ inline unsigned short\n"
@@ -1522,8 +1522,8 @@
 "{\n"
 "  // DstColor' = SrcA * SrcColor + (1 - SrcA) DstColor\n"
 "  float src_val = src * src_alpha;\n"
-"  float dst_val = __int2float_rz (dst) / 4095.0 * (1.0 - src_alpha);\n"
-"  return scale_to_12bits(clamp(src_val + dst_val, 0, 1.0));\n"
+"  float dst_val = __int2float_rz (dst) / 4095.0f * (1.0f - src_alpha);\n"
+"  return scale_to_12bits(clamp(src_val + dst_val, 0, 1.0f));\n"
 "}\n"
 "\n"
 "struct IConverter\n"
@@ -2155,7 +2155,7 @@
 "    dst0pos = blend_uchar (dst0pos, sample.x, sample.w);\n"
 "    dst0pos + 1 = blend_uchar (dst0pos + 1, sample.y, sample.w);\n"
 "    dst0pos + 2 = blend_uchar (dst0pos + 2, sample.z, sample.w);\n"
-"    dst0pos + 3 = blend_uchar (dst0pos + 3, 1.0, sample.w);\n"
+"    dst0pos + 3 = blend_uchar (dst0pos + 3, 1.0f, sample.w);\n"
 "  }\n"
 "};\n"
 "\n"
@@ -2209,7 +2209,7 @@
 "    dst0pos = blend_uchar (dst0pos, sample.z, sample.w);\n"
 "    dst0pos + 1 = blend_uchar (dst0pos + 1, sample.y, sample.w);\n"
 "    dst0pos + 2 = blend_uchar (dst0pos + 2, sample.x, sample.w);\n"
-"    dst0pos + 3 = blend_uchar (dst0pos + 3, 1.0, sample.w);\n"
+"    dst0pos + 3 = blend_uchar (dst0pos + 3, 1.0f, sample.w);\n"
 "  }\n"
 "};\n"
 "\n"
@@ -2260,7 +2260,7 @@
 "      int stride1)\n"
 "  {\n"
 "    int pos = x * 4 + y * stride0;\n"
-"    dst0pos = blend_uchar (dst0pos, 1.0, sample.w);\n"
+"    dst0pos = blend_uchar (dst0pos, 1.0f, sample.w);\n"
 "    dst0pos + 1 = blend_uchar (dst0pos + 1, sample.x, sample.w);\n"
 "    dst0pos + 2 = blend_uchar (dst0pos + 2, sample.y, sample.w);\n"
 "    dst0pos + 3 = blend_uchar (dst0pos + 3, sample.z, sample.w);\n"
@@ -2287,7 +2287,7 @@
 "      int stride1)\n"
 "  {\n"
 "    int pos = x * 4 + y * stride0;\n"
-"    dst0pos = blend_uchar (dst0pos, 1.0, sample.w);\n"
+"    dst0pos = blend_uchar (dst0pos, 1.0f, sample.w);\n"
 "    dst0pos + 1 = blend_uchar (dst0pos + 1, sample.z, sample.w);\n"
 "    dst0pos + 2 = blend_uchar (dst0pos + 2, sample.y, sample.w);\n"
 "    dst0pos + 3 = blend_uchar (dst0pos + 3, sample.x, sample.w);\n"
@@ -2710,7 +2710,7 @@
 "    dst0pos = blend_uchar (dst0pos, sample.y, sample.w);\n"
 "    dst1pos = blend_uchar (dst1pos, sample.z, sample.w);\n"
 "    dst2pos = blend_uchar (dst2pos, sample.x, sample.w);\n"
-"    dst3pos = blend_uchar (dst3pos, 1.0, sample.w);\n"
+"    dst3pos = blend_uchar (dst3pos, 1.0f, sample.w);\n"
 "  }\n"
 "};\n"
 "\n"
@@ -2737,7 +2737,7 @@
 "    dst0pos = blend_uchar (dst0pos, sample.z, sample.w);\n"
 "    dst0pos + 1 = blend_uchar (dst0pos + 1, sample.y, sample.w);\n"
 "    dst0pos + 2 = blend_uchar (dst0pos + 2, sample.x, sample.w);\n"
-"    dst0pos + 3 = blend_uchar (dst0pos + 3, 1.0, sample.w);\n"
+"    dst0pos + 3 = blend_uchar (dst0pos + 3, 1.0f, sample.w);\n"
 "  }\n"
 "};\n"
 "\n"
@@ -2764,11 +2764,11 @@
 "    sample = make_float4 (const_buf.border_x, const_buf.border_y,\n"
 "       const_buf.border_z, const_buf.border_w);\n"
 "  } else {\n"
-"    float x = (__int2float_rz (x_pos - const_buf.left) + 0.5) / const_buf.view_width;\n"
-"    if (x < 0.0 || x > 1.0)\n"
+"    float x = (__int2float_rz (x_pos - const_buf.left) + 0.5f) / const_buf.view_width;\n"
+"    if (x < 0.0f || x > 1.0f)\n"
 "      return;\n"
-"    float y = (__int2float_rz (y_pos - const_buf.top) + 0.5) / const_buf.view_height;\n"
-"    if (y < 0.0 || y > 1.0)\n"
+"    float y = (__int2float_rz (y_pos - const_buf.top) + 0.5f) / const_buf.view_height;\n"
+"    if (y < 0.0f || y > 1.0f)\n"
 "      return;\n"
 "    float2 rotated;\n"
 "    rotated.x = fmaf (x, const_buf.transform_u0,\n"

_service:download_files:gst-plugins-bad-1.28.2.tar.xz/sys/nvcodec/kernel/gstnvjpegenc.cu -> _service:download_files:gst-plugins-bad-1.28.3.tar.xz/sys/nvcodec/kernel/gstnvjpegenc.cu Changed

_service:download_files:gst-plugins-bad-1.28.2.tar.xz/sys/nvcodec/plugin.c -> _service:download_files:gst-plugins-bad-1.28.3.tar.xz/sys/nvcodec/plugin.c Changed

@@ -521,7 +521,11 @@
       /* Query current LUID - it changes per boot so can't use cached value */
       device_cache.adapter_luid = gst_cuda_context_find_dxgi_adapter_luid (i);
 
-      /* Update encoder class data with current LUID */
+      /* Update decoder/encoder class data with current LUID */
+      for (GList * l = device_cache.decoders; l; l = l->next) {
+        GstNvDecoderClassData *dec_cdata = (GstNvDecoderClassData *) l->data;
+        dec_cdata->adapter_luid = device_cache.adapter_luid;
+      }
       for (GList * l = device_cache.encoders; l; l = l->next) {
         GstNvEncoderClassData *enc_cdata = (GstNvEncoderClassData *) l->data;
         enc_cdata->adapter_luid = device_cache.adapter_luid;
@@ -560,6 +564,7 @@
                 g_strdup (gst_cuda_video_codec_to_string (codec));
             dec_cdata->sink_caps = sink_template;
             dec_cdata->src_caps = src_template;
+            dec_cdata->adapter_luid = device_cache.adapter_luid;
             dec_cdata->cuda_device_id = i;
             device_cache.decoders =
                 g_list_append (device_cache.decoders, dec_cdata);

_service:download_files:gst-plugins-bad-1.28.2.tar.xz/sys/va/gstvabaseenc.c -> _service:download_files:gst-plugins-bad-1.28.3.tar.xz/sys/va/gstvabaseenc.c Changed

_service:download_files:gst-plugins-bad-1.28.2.tar.xz/tests/check/elements/cudaconvert.c -> _service:download_files:gst-plugins-bad-1.28.3.tar.xz/tests/check/elements/cudaconvert.c Changed

_service:download_files:gst-plugins-bad-1.28.2.tar.xz/tests/check/elements/cudafilter.c -> _service:download_files:gst-plugins-bad-1.28.3.tar.xz/tests/check/elements/cudafilter.c Changed

_service:download_files:gst-plugins-bad-1.28.2.tar.xz/tests/check/elements/interlace.c -> _service:download_files:gst-plugins-bad-1.28.3.tar.xz/tests/check/elements/interlace.c Changed

@@ -194,6 +194,45 @@
 
 GST_END_TEST;
 
+GST_START_TEST (test_upstream_not_fixed)
+{
+  GstBuffer *buffer;
+  GstHarness *h;
+
+  h = gst_harness_new_parse ("videorate ! interlace field-pattern=0");
+
+  gst_harness_set_src_caps_str (h,
+      "video/x-raw, format=(string)AYUV64, width=(int)1, height=(int)1, multiview-mode=(string)mono, framerate=(fraction)30/1, pixel-aspect-ratio=(fraction)1/1, interlace-mode=(string)progressive");
+  gst_harness_set_sink_caps_str (h,
+      "video/x-raw,interlace-mode=interleaved,framerate=25/1");
+
+  buffer = gst_harness_create_buffer (h, 4);
+  fail_unless_equals_int (gst_harness_push (h, buffer), GST_FLOW_OK);
+
+  gst_harness_teardown (h);
+}
+
+GST_END_TEST;
+
+GST_START_TEST (test_downstream_any)
+{
+  GstBuffer *buffer;
+  GstHarness *h;
+
+  h = gst_harness_new ("interlace");
+
+  gst_harness_set (h, "interlace", "field-pattern", 0, NULL);
+  gst_harness_set_src_caps_str (h,
+      "video/x-raw, format=(string)AYUV, width=(int)1, height=(int)1, framerate=(fraction)25/1, multiview-mode=(string)mono, interlace-mode=(string)progressive, pixel-aspect-ratio=(fraction)1/1");
+
+  buffer = gst_harness_create_buffer (h, 4);
+  fail_unless_equals_int (gst_harness_push (h, buffer), GST_FLOW_OK);
+
+  gst_harness_teardown (h);
+}
+
+GST_END_TEST;
+
 static Suite *
 interlace_suite (void)
 {
@@ -209,6 +248,8 @@
   tcase_add_test (tc_chain, test_framerate_1_1);
   tcase_add_test (tc_chain, test_framerate_3_2);
   tcase_add_test (tc_chain, test_framerate_empty_not_negotiated);
+  tcase_add_test (tc_chain, test_downstream_any);
+  tcase_add_test (tc_chain, test_upstream_not_fixed);
 
   return s;
 }

_service:download_files:gst-plugins-bad-1.28.2.tar.xz/tests/check/elements/nvdec.c -> _service:download_files:gst-plugins-bad-1.28.3.tar.xz/tests/check/elements/nvdec.c Changed

_service:download_files:gst-plugins-bad-1.28.2.tar.xz/tests/check/elements/nvenc.c -> _service:download_files:gst-plugins-bad-1.28.3.tar.xz/tests/check/elements/nvenc.c Changed

_service:download_files:gst-plugins-bad-1.28.2.tar.xz/tests/check/elements/vkcolorconvert.c -> _service:download_files:gst-plugins-bad-1.28.3.tar.xz/tests/check/elements/vkcolorconvert.c Changed

_service:download_files:gst-plugins-bad-1.28.2.tar.xz/tests/check/elements/vkdeviceprovider.c -> _service:download_files:gst-plugins-bad-1.28.3.tar.xz/tests/check/elements/vkdeviceprovider.c Changed

_service:download_files:gst-plugins-bad-1.28.3.tar.xz/tests/check/elements/vkdownload.c Added

@@ -0,0 +1,287 @@
+/* GStreamer
+ *
+ * unit test for vulkandownload element
+ * Copyright (C) 2026 Piotr Brzeziński <piotr@centricular.com>
+ *
+ * This library is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Library General Public
+ * License as published by the Free Software Foundation; either
+ * version 2 of the License, or (at your option) any later version.
+ *
+ * This library is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * Library General Public License for more details.
+ *
+ * You should have received a copy of the GNU Library General Public
+ * License along with this library; if not, write to the
+ * Free Software Foundation, Inc., 51 Franklin St, Fifth Floor,
+ * Boston, MA 02110-1301, USA.
+ */
+
+#ifdef HAVE_CONFIG_H
+#include "config.h"
+#endif
+
+#include <gst/gst.h>
+#include <gst/check/gstcheck.h>
+#include <gst/check/gstharness.h>
+#include <gst/video/video.h>
+#include <gst/vulkan/vulkan.h>
+
+static const struct
+{
+  guint width;
+  guint height;
+} stride_test_resolutions = {
+  {123, 345},
+  {678, 789},
+  {511, 257},
+  {855, 481},
+};
+
+static gboolean
+cmp_buffers (GstBuffer * buf1, GstBuffer * buf2, const GstVideoInfo * info)
+{
+  GstVideoFrame frame1, frame2;
+  gint compGST_VIDEO_MAX_COMPONENTS, stride1, stride2;
+  guint32 width, height;
+  gboolean ret = FALSE;
+
+  fail_unless (!GST_VIDEO_FORMAT_INFO_IS_COMPLEX (info->finfo));
+  fail_unless (gst_video_frame_map (&frame1, info, buf1, GST_MAP_READ));
+  fail_unless (gst_video_frame_map (&frame2, info, buf2, GST_MAP_READ));
+
+  for (int plane = 0; plane < GST_VIDEO_INFO_N_PLANES (info); plane++) {
+    guint8 *row1, *row2;
+
+    gst_video_format_info_component (info->finfo, plane, comp);
+
+    width = GST_VIDEO_INFO_COMP_WIDTH (info, comp0)
+        * GST_VIDEO_INFO_COMP_PSTRIDE (info, comp0);
+    height = GST_VIDEO_INFO_COMP_HEIGHT (info, comp0);
+
+    stride1 = GST_VIDEO_INFO_PLANE_STRIDE (&frame1.info, plane);
+    stride2 = GST_VIDEO_INFO_PLANE_STRIDE (&frame2.info, plane);
+
+    row1 = frame1.dataplane;
+    row2 = frame2.dataplane;
+
+    for (int i = 0; i < height; i++) {
+      GST_MEMDUMP ("input row:", row1, width);
+      GST_MEMDUMP ("output row:", row2, width);
+
+      if (memcmp (row1, row2, width) != 0)
+        goto bail;
+
+      row1 += stride1;
+      row2 += stride2;
+    }
+  }
+
+  ret = TRUE;
+
+bail:
+  gst_video_frame_unmap (&frame1);
+  gst_video_frame_unmap (&frame2);
+
+  return ret;
+}
+
+static gboolean
+fill_stride_test_image_buffer (GstBuffer * buf, const GstVideoInfo * info)
+{
+  GstVideoFrame frame;
+  gint width, height, stride;
+
+  if (!gst_video_frame_map (&frame, info, buf, GST_MAP_WRITE))
+    return FALSE;
+
+  width = GST_VIDEO_INFO_WIDTH (info);
+  height = GST_VIDEO_INFO_HEIGHT (info);
+  stride = GST_VIDEO_FRAME_PLANE_STRIDE (&frame, 0);
+
+  for (gint y = 0; y < height; y++) {
+    guint8 *row =
+        (guint8 *) GST_VIDEO_FRAME_PLANE_DATA (&frame, 0) + y * stride;
+    const guint8 r = (y * 3) & 0xff;
+    const guint8 g = (y * 7) & 0xff;
+    const guint8 b = (y * 11) & 0xff;
+
+    for (gint x = 0; x < width; x++) {
+      rowx * 4 + 0 = r;
+      rowx * 4 + 1 = g;
+      rowx * 4 + 2 = b;
+      rowx * 4 + 3 = 0xff;
+    }
+  }
+
+  gst_video_frame_unmap (&frame);
+
+  return TRUE;
+}
+
+static GstBuffer *
+create_stride_test_vulkan_image_buffer (GstVulkanDevice * device,
+    GstVideoInfo * info)
+{
+  /* Finds an odd-sized linear image layout where the source image memory
+   * layout differs from the tightly-packed raw output layout.
+   * I originally found this bug on an M4 Pro Mac at 854x480, but odd resolutions
+   * should be more reliable at triggering the problem on different hardware. */
+  for (guint i = 0; i < G_N_ELEMENTS (stride_test_resolutions); i++) {
+    const guint width = stride_test_resolutionsi.width;
+    const guint height = stride_test_resolutionsi.height;
+    GstBuffer *buf;
+    GstMemory *mem;
+    VkImageCreateInfo image_info;
+    GstVulkanImageMemory *img_mem;
+    VkImageSubresource subresource = {
+      .aspectMask = VK_IMAGE_ASPECT_COLOR_BIT,
+      .mipLevel = 0,
+      .arrayLayer = 0,
+    };
+    VkSubresourceLayout layout;
+    VkFormat vk_format;
+    gsize offsetsGST_VIDEO_MAX_PLANES = { 0, };
+    gint stridesGST_VIDEO_MAX_PLANES = { 0, };
+    guint tight_stride;
+
+    fail_unless (gst_video_info_set_format (info,
+            GST_VIDEO_FORMAT_RGBA, width, height));
+    tight_stride = GST_VIDEO_INFO_PLANE_STRIDE (info, 0);
+    vk_format = gst_vulkan_format_from_video_info (info, 0);
+
+    /* *INDENT-OFF* */
+    image_info = (VkImageCreateInfo) {
+      .sType = VK_STRUCTURE_TYPE_IMAGE_CREATE_INFO,
+      .imageType = VK_IMAGE_TYPE_2D,
+      .format = vk_format,
+      .extent = { width, height, 1 },
+      .mipLevels = 1,
+      .arrayLayers = 1,
+      .samples = VK_SAMPLE_COUNT_1_BIT,
+      .tiling = VK_IMAGE_TILING_LINEAR,
+      .usage = VK_IMAGE_USAGE_TRANSFER_SRC_BIT | VK_IMAGE_USAGE_TRANSFER_DST_BIT,
+      .sharingMode = VK_SHARING_MODE_EXCLUSIVE,
+      .initialLayout = VK_IMAGE_LAYOUT_PREINITIALIZED,
+    };
+    /* *INDENT-ON* */
+
+    mem = gst_vulkan_image_memory_alloc_with_image_info (device, &image_info,
+        VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT
+        | VK_MEMORY_PROPERTY_HOST_COHERENT_BIT);
+    if (!mem)
+      continue;
+
+    img_mem = (GstVulkanImageMemory *) mem;
+    vkGetImageSubresourceLayout (device->device, img_mem->image, &subresource,
+        &layout);
+
+    /* We want a padded stride value, that's when vulkandownload corrupted the output previously */
+    if (layout.rowPitch <= tight_stride) {
+      gst_memory_unref (mem);
+      continue;
+    }
+
+    buf = gst_buffer_new ();
+    fail_unless (buf != NULL);
+    gst_buffer_append_memory (buf, mem);
+
+    offsets0 = layout.offset;
+    strides0 = (gint) layout.rowPitch;
+
+    fail_unless (gst_buffer_add_video_meta_full (buf, GST_VIDEO_FRAME_FLAG_NONE,
+            GST_VIDEO_FORMAT_RGBA, width, height, 1, offsets, strides) != NULL);
+    fail_unless (fill_stride_test_image_buffer (buf, info));
+
+    GST_INFO ("Using vkdownload stride test resolution %ux%u", width, height);
+
+    return buf;
+  }
+
+  return NULL;
+}
+
+GST_START_TEST (test_vulkan_download_uses_output_stride)
+{
+  GstVulkanInstance *instance;
+  GstVulkanDevice *device;
+  GstHarness *h;
+  GstContext *context;
+  GstCaps *in_caps, *out_caps;
+  GstVideoInfo info;
+  GstBuffer *inbuf = NULL, *outbuf = NULL;
+
+  /* We need a Vulkan image whose plane layout differs from the tightly packed
+   * raw output buffer so the test catches vkdownload using the source layout
+   * instead of the destination one while setting up VkBufferImageCopy.
+   * This problem was originally spotted on macOS with just vtdec ! vulkandownload. */
+
+  h = gst_harness_new ("vulkandownload");
+  context = gst_element_get_context (h->element,
+      GST_VULKAN_INSTANCE_CONTEXT_TYPE_STR);
+  fail_unless (context != NULL);
+  fail_unless (gst_context_get_vulkan_instance (context, &instance));
+  gst_context_unref (context);
+
+  device = gst_vulkan_device_new_with_index (instance, 0);
+  fail_unless (gst_vulkan_device_open (device, NULL));
+
+  inbuf = create_stride_test_vulkan_image_buffer (device, &info);
+  if (!inbuf) {
+    GST_INFO ("Couldn't create a buffer required for vkdownload stride test");
+    goto cleanup;
+  }
+
+  in_caps = gst_video_info_to_caps (&info);
+  fail_unless (in_caps != NULL);
+  gst_caps_set_features_simple (in_caps,
+      gst_caps_features_new_static_str (GST_CAPS_FEATURE_MEMORY_VULKAN_IMAGE,
+          NULL));
+
+  out_caps = gst_video_info_to_caps (&info);
+  fail_unless (out_caps != NULL);
+
+  gst_harness_set_caps (h, in_caps, out_caps);
+
+  outbuf = gst_harness_push_and_pull (h, gst_buffer_ref (inbuf));
+  fail_unless (outbuf != NULL);
+
+  fail_unless (cmp_buffers (inbuf, outbuf, &info));
+
+  gst_buffer_unref (inbuf);
+  gst_buffer_unref (outbuf);
+
+cleanup:
+  gst_harness_teardown (h);
+  gst_clear_object (&device);
+  gst_clear_object (&instance);
+}
+
+GST_END_TEST;
+
+static Suite *
+vkdownload_suite (void)
+{
+  Suite *s = suite_create ("vkdownload");
+  TCase *tc_basic = tcase_create ("general");
+  GstVulkanInstance *instance;
+  gboolean have_instance;
+
+  suite_add_tcase (s, tc_basic);
+
+  instance = gst_vulkan_instance_new ();
+  have_instance = gst_vulkan_instance_open (instance, NULL);
+  gst_object_unref (instance);
+  if (have_instance)
+    tcase_add_test (tc_basic, test_vulkan_download_uses_output_stride);
+
+  return s;
+}
+
+#ifdef __APPLE__
+GST_CHECK_MAIN_NOFORK (vkdownload);
+#else
+GST_CHECK_MAIN (vkdownload);
+#endif

_service:download_files:gst-plugins-bad-1.28.2.tar.xz/tests/check/elements/vkupload.c -> _service:download_files:gst-plugins-bad-1.28.3.tar.xz/tests/check/elements/vkupload.c Changed

@@ -27,11 +27,15 @@
 #include <gst/gst.h>
 #include <gst/check/gstcheck.h>
 #include <gst/check/gstharness.h>
+#include <gst/video/video.h>
 #include <gst/vulkan/vulkan.h>
-#include <stdio.h>
 
 static const gchar *formats = { "NV12", "RGBA" };
 
+#define STRIDE_TEST_WIDTH 360
+#define STRIDE_TEST_HEIGHT 480
+#define STRIDE_TEST_INPUT_STRIDE 1472
+
 static const struct
 {
   guint width;
@@ -99,6 +103,60 @@
 }
 
 static gboolean
+fill_stride_test_rgba_buffer (GstBuffer * buf)
+{
+  GstMapInfo map;
+  guint x, y;
+
+  if (!gst_buffer_map (buf, &map, GST_MAP_WRITE))
+    return FALSE;
+
+  for (y = 0; y < STRIDE_TEST_HEIGHT; y++) {
+    guint8 *row = map.data + y * STRIDE_TEST_INPUT_STRIDE;
+    guint8 pixel = { (y * 3) & 0xff, (y * 7) & 0xff, (y * 11) & 0xff, 0xff };
+
+    for (x = 0; x < STRIDE_TEST_WIDTH; x++)
+      memcpy (row + x * 4, pixel, sizeof (pixel));
+
+    memset (row + STRIDE_TEST_WIDTH * 4, 0x5a,
+        STRIDE_TEST_INPUT_STRIDE - STRIDE_TEST_WIDTH * 4);
+  }
+
+  gst_buffer_unmap (buf, &map);
+
+  return TRUE;
+}
+
+static GstBuffer *
+create_stride_test_rgba_buffer (void)
+{
+  GstBuffer *buf;
+  gsize offsetsGST_VIDEO_MAX_PLANES = { 0, };
+  gint stridesGST_VIDEO_MAX_PLANES = { 0, };
+
+  buf =
+      gst_buffer_new_allocate (NULL,
+      STRIDE_TEST_INPUT_STRIDE * STRIDE_TEST_HEIGHT, NULL);
+  if (!buf)
+    return NULL;
+
+  if (!fill_stride_test_rgba_buffer (buf)) {
+    gst_buffer_unref (buf);
+    return NULL;
+  }
+
+  strides0 = STRIDE_TEST_INPUT_STRIDE;
+  if (!gst_buffer_add_video_meta_full (buf, GST_VIDEO_FRAME_FLAG_NONE,
+          GST_VIDEO_FORMAT_RGBA, STRIDE_TEST_WIDTH, STRIDE_TEST_HEIGHT, 1,
+          offsets, strides)) {
+    gst_buffer_unref (buf);
+    return NULL;
+  }
+
+  return buf;
+}
+
+static gboolean
 run_test (const gchar * launchline, const gchar * format, guint width,
     guint height, const gchar * sink_caps_str)
 {
@@ -189,6 +247,40 @@
 
 GST_END_TEST;
 
+GST_START_TEST (test_vulkan_upload_image_padded_stride)
+{
+  GstHarness *h;
+  GstCaps *caps;
+  GstVideoInfo info;
+  GstBuffer *inbuf, *outbuf;
+
+  h = gst_harness_new_parse ("vulkanupload ! vulkandownload");
+  fail_unless (h != NULL);
+
+  caps = gst_caps_new_simple ("video/x-raw",
+      "format", G_TYPE_STRING, "RGBA",
+      "width", G_TYPE_INT, STRIDE_TEST_WIDTH,
+      "height", G_TYPE_INT, STRIDE_TEST_HEIGHT, NULL);
+  fail_unless (caps != NULL);
+  fail_unless (gst_video_info_from_caps (&info, caps));
+
+  gst_harness_set_caps (h, caps, gst_caps_ref (caps));
+
+  inbuf = create_stride_test_rgba_buffer ();
+  fail_unless (inbuf != NULL);
+
+  outbuf = gst_harness_push_and_pull (h, gst_buffer_ref (inbuf));
+  fail_unless (outbuf != NULL);
+
+  fail_unless (cmp_buffers (inbuf, outbuf, &info));
+
+  gst_buffer_unref (inbuf);
+  gst_buffer_unref (outbuf);
+  gst_harness_teardown (h);
+}
+
+GST_END_TEST;
+
 static Suite *
 vkupload_suite (void)
 {
@@ -205,9 +297,14 @@
   if (have_instance) {
     tcase_add_test (tc_basic, test_vulkan_upload_buffer);
     tcase_add_test (tc_basic, test_vulkan_upload_image);
+    tcase_add_test (tc_basic, test_vulkan_upload_image_padded_stride);
   }
 
   return s;
 }
 
+#ifdef __APPLE__
+GST_CHECK_MAIN_NOFORK (vkupload);
+#else
 GST_CHECK_MAIN (vkupload);
+#endif

_service:download_files:gst-plugins-bad-1.28.2.tar.xz/tests/check/libs/cudamemory.c -> _service:download_files:gst-plugins-bad-1.28.3.tar.xz/tests/check/libs/cudamemory.c Changed

_service:download_files:gst-plugins-bad-1.28.2.tar.xz/tests/check/libs/vkcommandpool.c -> _service:download_files:gst-plugins-bad-1.28.3.tar.xz/tests/check/libs/vkcommandpool.c Changed

_service:download_files:gst-plugins-bad-1.28.2.tar.xz/tests/check/libs/vkdevice.c -> _service:download_files:gst-plugins-bad-1.28.3.tar.xz/tests/check/libs/vkdevice.c Changed

_service:download_files:gst-plugins-bad-1.28.2.tar.xz/tests/check/libs/vkformat.c -> _service:download_files:gst-plugins-bad-1.28.3.tar.xz/tests/check/libs/vkformat.c Changed

_service:download_files:gst-plugins-bad-1.28.2.tar.xz/tests/check/libs/vkimage.c -> _service:download_files:gst-plugins-bad-1.28.3.tar.xz/tests/check/libs/vkimage.c Changed

_service:download_files:gst-plugins-bad-1.28.2.tar.xz/tests/check/libs/vkimagebufferpool.c -> _service:download_files:gst-plugins-bad-1.28.3.tar.xz/tests/check/libs/vkimagebufferpool.c Changed

_service:download_files:gst-plugins-bad-1.28.2.tar.xz/tests/check/libs/vkinstance.c -> _service:download_files:gst-plugins-bad-1.28.3.tar.xz/tests/check/libs/vkinstance.c Changed

_service:download_files:gst-plugins-bad-1.28.2.tar.xz/tests/check/libs/vkmemory.c -> _service:download_files:gst-plugins-bad-1.28.3.tar.xz/tests/check/libs/vkmemory.c Changed

_service:download_files:gst-plugins-bad-1.28.2.tar.xz/tests/check/libs/vkvideodecode.c -> _service:download_files:gst-plugins-bad-1.28.3.tar.xz/tests/check/libs/vkvideodecode.c Changed

_service:download_files:gst-plugins-bad-1.28.2.tar.xz/tests/check/libs/vkvideoencodeav1.c -> _service:download_files:gst-plugins-bad-1.28.3.tar.xz/tests/check/libs/vkvideoencodeav1.c Changed

_service:download_files:gst-plugins-bad-1.28.2.tar.xz/tests/check/libs/vkvideoencodeh264.c -> _service:download_files:gst-plugins-bad-1.28.3.tar.xz/tests/check/libs/vkvideoencodeh264.c Changed

_service:download_files:gst-plugins-bad-1.28.2.tar.xz/tests/check/libs/vkvideoencodeh265.c -> _service:download_files:gst-plugins-bad-1.28.3.tar.xz/tests/check/libs/vkvideoencodeh265.c Changed

_service:download_files:gst-plugins-bad-1.28.2.tar.xz/tests/check/libs/vkwindow.c -> _service:download_files:gst-plugins-bad-1.28.3.tar.xz/tests/check/libs/vkwindow.c Changed

_service:download_files:gst-plugins-bad-1.28.2.tar.xz/tests/check/meson.build -> _service:download_files:gst-plugins-bad-1.28.3.tar.xz/tests/check/meson.build Changed

_service:download_files:gst-plugins-bad-1.28.3.tar.xz/tests/check/pipelines/vtdec-output-paths.c Added

@@ -0,0 +1,600 @@
+/* GStreamer
+ * Copyright (C) 2026 Dominique Leroux <dominique.p.leroux@gmail.com>
+ *
+ * This library is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Library General Public
+ * License as published by the Free Software Foundation; either
+ * version 2 of the License, or (at your option) any later version.
+ *
+ * This library is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * Library General Public License for more details.
+ *
+ * You should have received a copy of the GNU Library General Public
+ * License along with this library; if not, write to the
+ * Free Software Foundation, Inc., 51 Franklin St, Fifth Floor,
+ * Boston, MA 02110-1301, USA.
+ */
+
+#include <gst/check/gstcheck.h>
+#include <gst/app/gstappsink.h>
+#include <gst/video/video.h>
+#include <TargetConditionals.h>
+
+#if TARGET_OS_OSX
+#include <gst/gstmacos.h>
+#endif
+
+#define VTDEC_COMPARE_FRAMES 8
+
+typedef struct
+{
+  guint buffers;
+  gboolean eos;
+  gboolean error;
+  gboolean timeout;
+  gchar *error_message;
+  GPtrArray *sample_buffers;
+  GstCaps *caps;
+} PipelineResult;
+
+typedef struct
+{
+  PipelineResult *result;
+  GMainLoop *loop;
+  GstElement *pipeline;
+  guint timeout_id;
+  guint max_samples;
+} PipelineContext;
+
+typedef struct
+{
+  gboolean enabled;
+  gboolean had_value;
+  gchar *old_value;
+} EnvOverride;
+
+static void
+on_handoff (GstElement * fakesink, GstBuffer * buffer, GstPad * pad,
+    gpointer user_data)
+{
+  PipelineContext *ctx = user_data;
+
+  (void) fakesink;
+  (void) buffer;
+  (void) pad;
+
+  ctx->result->buffers++;
+}
+
+static GstFlowReturn
+on_new_sample (GstAppSink * appsink, gpointer user_data)
+{
+  PipelineContext *ctx = user_data;
+  GstSample *sample = gst_app_sink_pull_sample (appsink);
+  GstBuffer *buffer;
+  GstCaps *caps;
+  gboolean enough_samples = FALSE;
+
+  if (sample == NULL)
+    return GST_FLOW_ERROR;
+
+  buffer = gst_sample_get_buffer (sample);
+  caps = gst_sample_get_caps (sample);
+
+  if (ctx->result->caps == NULL && caps != NULL)
+    ctx->result->caps = gst_caps_ref (caps);
+  if (buffer != NULL && (ctx->max_samples == 0 ||
+          ctx->result->sample_buffers->len < ctx->max_samples))
+    g_ptr_array_add (ctx->result->sample_buffers, gst_buffer_ref (buffer));
+
+  if (ctx->max_samples > 0 && ctx->result->sample_buffers->len >=
+      ctx->max_samples)
+    enough_samples = TRUE;
+
+  gst_sample_unref (sample);
+
+  if (enough_samples)
+    g_main_loop_quit (ctx->loop);
+
+  return GST_FLOW_OK;
+}
+
+static void
+pipeline_result_clear (PipelineResult * result)
+{
+  g_clear_pointer (&result->error_message, g_free);
+  g_clear_pointer (&result->sample_buffers, g_ptr_array_unref);
+  gst_clear_caps (&result->caps);
+}
+
+static gboolean
+on_bus_message (GstBus * bus, GstMessage * msg, gpointer user_data)
+{
+  PipelineContext *ctx = user_data;
+  GstMessageType msg_type = GST_MESSAGE_TYPE (msg);
+
+  (void) bus;
+
+  if (msg_type == GST_MESSAGE_WARNING) {
+    GError *err = NULL;
+    gchar *debug = NULL;
+
+    gst_message_parse_warning (msg, &err, &debug);
+    if (err != NULL)
+      GST_WARNING ("Pipeline warning: %s", err->message);
+    if (debug != NULL)
+      GST_WARNING ("Pipeline warning details: %s", debug);
+    g_clear_error (&err);
+    g_free (debug);
+  }
+
+  if (msg_type == GST_MESSAGE_ERROR) {
+    GError *err = NULL;
+    gchar *debug = NULL;
+
+    gst_message_parse_error (msg, &err, &debug);
+    if (err && ctx->result->error_message == NULL && err->message)
+      ctx->result->error_message = g_strdup (err->message);
+    if (err != NULL)
+      GST_WARNING ("Pipeline error: %s", err->message);
+    if (debug != NULL)
+      GST_WARNING ("Pipeline error details: %s", debug);
+    g_clear_error (&err);
+    g_free (debug);
+    ctx->result->error = TRUE;
+    g_main_loop_quit (ctx->loop);
+  } else if (msg_type == GST_MESSAGE_EOS) {
+    ctx->result->eos = TRUE;
+    g_main_loop_quit (ctx->loop);
+  }
+
+  return TRUE;
+}
+
+static gboolean
+on_timeout (gpointer user_data)
+{
+  PipelineContext *ctx = user_data;
+
+  ctx->timeout_id = 0;
+  ctx->result->timeout = TRUE;
+  g_main_loop_quit (ctx->loop);
+  return G_SOURCE_REMOVE;
+}
+
+static gboolean
+start_pipeline (gpointer user_data)
+{
+  PipelineContext *ctx = user_data;
+  GstStateChangeReturn ret;
+
+  ret = gst_element_set_state (ctx->pipeline, GST_STATE_PAUSED);
+  GST_LOG ("PAUSED state request returned: %d", ret);
+
+  ret = gst_element_set_state (ctx->pipeline, GST_STATE_PLAYING);
+  GST_LOG ("PLAYING state request returned: %d", ret);
+
+  return G_SOURCE_REMOVE;
+}
+
+static gboolean
+element_available (const gchar * name)
+{
+  GstElementFactory *factory = gst_element_factory_find (name);
+
+  if (factory) {
+    gst_object_unref (factory);
+    return TRUE;
+  }
+
+  return FALSE;
+}
+
+static gboolean
+require_elements_or_skip (const gchar * const *elements, gsize n_elements)
+{
+  gboolean strict = g_getenv ("GST_REQUIRE_TEST_ELEMENTS") != NULL;
+  gsize i;
+
+  for (i = 0; i < n_elements; i++) {
+    if (element_available (elementsi))
+      continue;
+    if (strict)
+      fail_unless (FALSE, "Missing required element: %s", elementsi);
+    GST_INFO ("Skipping test, missing required element: %s", elementsi);
+    return FALSE;
+  }
+
+  return TRUE;
+}
+
+static void
+env_override_enable (EnvOverride * override, const gchar * name,
+    const gchar * value)
+{
+  const gchar *current;
+
+  current = g_getenv (name);
+  if (current != NULL)
+    return;
+
+  override->enabled = TRUE;
+  override->had_value = FALSE;
+  override->old_value = NULL;
+
+  fail_unless (g_setenv (name, value, TRUE));
+}
+
+static void
+env_override_restore (EnvOverride * override, const gchar * name)
+{
+  if (!override->enabled)
+    return;
+
+  if (override->had_value)
+    fail_unless (g_setenv (name, override->old_value, TRUE));
+  else
+    g_unsetenv (name);
+
+  g_clear_pointer (&override->old_value, g_free);
+  override->enabled = FALSE;
+  override->had_value = FALSE;
+}
+
+static PipelineResult
+run_pipeline (const gchar * pipeline_desc, gboolean collect_samples)
+{
+  PipelineResult result = { 0, FALSE, FALSE, FALSE, NULL, NULL, NULL };
+  PipelineContext ctx = { &result, NULL, NULL, 0, 0 };
+  GstElement *pipeline;
+  GstElement *sink;
+  GstBus *bus;
+  guint bus_watch_id;
+  guint timeout_id;
+
+  pipeline = gst_parse_launch (pipeline_desc, NULL);
+  fail_unless (pipeline != NULL);
+
+  if (collect_samples)
+    result.sample_buffers = g_ptr_array_new_with_free_func ((GDestroyNotify)
+        gst_buffer_unref);
+
+  sink = gst_bin_get_by_name (GST_BIN (pipeline), "sink");
+  fail_unless (sink != NULL);
+
+  bus = gst_element_get_bus (pipeline);
+  fail_unless (bus != NULL);
+
+  ctx.loop = g_main_loop_new (NULL, FALSE);
+  ctx.pipeline = pipeline;
+  if (collect_samples)
+    ctx.max_samples = VTDEC_COMPARE_FRAMES;
+
+  if (collect_samples) {
+    g_object_set (sink, "emit-signals", TRUE, NULL);
+    g_signal_connect (sink, "new-sample", G_CALLBACK (on_new_sample), &ctx);
+  } else {
+    g_signal_connect (sink, "handoff", G_CALLBACK (on_handoff), &ctx);
+  }
+
+  bus_watch_id = gst_bus_add_watch (bus, on_bus_message, &ctx);
+  timeout_id = g_timeout_add_seconds (10, on_timeout, &ctx);
+  ctx.timeout_id = timeout_id;
+
+  g_idle_add (start_pipeline, &ctx);
+  g_main_loop_run (ctx.loop);
+
+  gst_element_set_state (pipeline, GST_STATE_NULL);
+  gst_element_get_state (pipeline, NULL, NULL, GST_CLOCK_TIME_NONE);
+
+  if (ctx.timeout_id != 0)
+    g_source_remove (ctx.timeout_id);
+  g_source_remove (bus_watch_id);
+  g_main_loop_unref (ctx.loop);
+  gst_object_unref (sink);
+  gst_object_unref (bus);
+  gst_object_unref (pipeline);
+
+  return result;
+}
+
+static void
+run_vtdec_pipeline_test (const gchar * const *elements, gsize n_elements,
+    const gchar * pipeline_tail, gboolean disable_mvk_argument_buffers)
+{
+  gchar *filepath;
+  gchar *resolved_path;
+  gchar *pipeline_desc;
+  PipelineResult result;
+  EnvOverride env_override = { 0, };
+
+  if (!require_elements_or_skip (elements, n_elements))
+    return;
+
+  filepath = g_build_filename (GST_TEST_FILES_PATH, "test.ts", NULL);
+  if (!g_file_test (filepath, G_FILE_TEST_EXISTS)) {
+    GST_INFO ("Skipping test, missing file: %s", filepath);
+    g_free (filepath);
+    return;
+  }
+
+  resolved_path = g_canonicalize_filename (filepath, NULL);
+  g_free (filepath);
+
+  pipeline_desc = g_strdup_printf ("filesrc location=\"%s\" ! "
+      "tsdemux ! h264parse ! vtdec ! %s", resolved_path, pipeline_tail);
+  g_free (resolved_path);
+
+  if (disable_mvk_argument_buffers) {
+    /* Temporary workaround for MoltenVK issue #2705. Remove this once the
+     * bundled MoltenVK includes the upstream fix. Respect a user-provided
+     * MVK_CONFIG_USE_METAL_ARGUMENT_BUFFERS value so the current MoltenVK
+     * behavior can be checked explicitly. */
+    env_override_enable (&env_override,
+        "MVK_CONFIG_USE_METAL_ARGUMENT_BUFFERS", "0");
+  }
+
+  result = run_pipeline (pipeline_desc, FALSE);
+
+  env_override_restore (&env_override, "MVK_CONFIG_USE_METAL_ARGUMENT_BUFFERS");
+  g_free (pipeline_desc);
+
+  fail_unless (!result.timeout, "Pipeline timed out");
+  fail_unless (!result.error, "Pipeline error: %s",
+      result.error_message ? result.error_message : "unknown");
+  fail_unless (result.eos, "Pipeline EOS missing");
+  fail_unless (result.buffers > 0, "Expected buffers at sink");
+  pipeline_result_clear (&result);
+}
+
+static PipelineResult
+run_vtdec_sample_collection_pipeline (const gchar * pipeline_tail,
+    gboolean disable_mvk_argument_buffers)
+{
+  gchar *filepath;
+  gchar *resolved_path;
+  gchar *pipeline_desc;
+  PipelineResult result;
+  EnvOverride env_override = { 0, };
+
+  filepath = g_build_filename (GST_TEST_FILES_PATH, "test.ts", NULL);
+  fail_unless (g_file_test (filepath, G_FILE_TEST_EXISTS),
+      "Missing test file: %s", filepath);
+
+  resolved_path = g_canonicalize_filename (filepath, NULL);
+  g_free (filepath);
+
+  pipeline_desc = g_strdup_printf ("filesrc location=\"%s\" ! "
+      "tsdemux ! h264parse ! vtdec ! %s", resolved_path, pipeline_tail);
+  g_free (resolved_path);
+
+  if (disable_mvk_argument_buffers) {
+    env_override_enable (&env_override,
+        "MVK_CONFIG_USE_METAL_ARGUMENT_BUFFERS", "0");
+  }
+
+  result = run_pipeline (pipeline_desc, TRUE);
+
+  env_override_restore (&env_override, "MVK_CONFIG_USE_METAL_ARGUMENT_BUFFERS");
+  g_free (pipeline_desc);
+
+  fail_unless (!result.timeout, "Pipeline timed out");
+  fail_unless (!result.error, "Pipeline error: %s",
+      result.error_message ? result.error_message : "unknown");
+  fail_unless (result.sample_buffers->len == VTDEC_COMPARE_FRAMES,
+      "Expected %u samples before EOS, got %u",
+      VTDEC_COMPARE_FRAMES, result.sample_buffers->len);
+  fail_unless (result.caps != NULL, "Expected output caps");
+  fail_unless (result.sample_buffers != NULL && result.sample_buffers->len > 0,
+      "Expected samples at appsink");
+
+  return result;
+}
+
+static void
+compare_video_buffers (GstBuffer * expected, GstBuffer * actual,
+    const GstVideoInfo * info)
+{
+  GstVideoFrame expected_frame;
+  GstVideoFrame actual_frame;
+
+  fail_unless (gst_video_frame_map (&expected_frame, info, expected,
+          GST_MAP_READ));
+  fail_unless (gst_video_frame_map (&actual_frame, info, actual, GST_MAP_READ));
+
+  for (guint plane = 0; plane < GST_VIDEO_INFO_N_PLANES (info); plane++) {
+    gint compGST_VIDEO_MAX_COMPONENTS;
+    const guint8 *expected_row;
+    const guint8 *actual_row;
+    guint row_size;
+    guint height;
+
+    gst_video_format_info_component (info->finfo, plane, comp);
+    row_size = GST_VIDEO_INFO_COMP_WIDTH (info, comp0) *
+        GST_VIDEO_INFO_COMP_PSTRIDE (info, comp0);
+    if (row_size == 0) {
+      row_size = MIN (GST_VIDEO_INFO_COMP_PSTRIDE (&expected_frame.info, plane),
+          GST_VIDEO_INFO_COMP_PSTRIDE (&actual_frame.info, plane));
+    }
+    height = GST_VIDEO_INFO_COMP_HEIGHT (info, comp0);
+
+    expected_row = GST_VIDEO_FRAME_PLANE_DATA (&expected_frame, plane);
+    actual_row = GST_VIDEO_FRAME_PLANE_DATA (&actual_frame, plane);
+
+    for (guint row = 0; row < height; row++) {
+      fail_unless (memcmp (expected_row, actual_row, row_size) == 0,
+          "Frame data differs at plane %u row %u", plane, row);
+
+      expected_row += GST_VIDEO_FRAME_PLANE_STRIDE (&expected_frame, plane);
+      actual_row += GST_VIDEO_FRAME_PLANE_STRIDE (&actual_frame, plane);
+    }
+  }
+
+  gst_video_frame_unmap (&actual_frame);
+  gst_video_frame_unmap (&expected_frame);
+}
+
+static void
+compare_pipeline_results (PipelineResult * expected, PipelineResult * actual)
+{
+  GstVideoInfo info;
+
+  fail_unless (gst_video_info_from_caps (&info, expected->caps));
+  fail_unless (gst_caps_can_intersect (expected->caps, actual->caps),
+      "Output caps differ: expected %" GST_PTR_FORMAT ", actual %"
+      GST_PTR_FORMAT, expected->caps, actual->caps);
+  fail_unless (expected->sample_buffers->len == actual->sample_buffers->len,
+      "Expected %u buffers, got %u", expected->sample_buffers->len,
+      actual->sample_buffers->len);
+
+  for (guint i = 0; i < expected->sample_buffers->len; i++) {
+    GstBuffer *expected_buffer =
+        g_ptr_array_index (expected->sample_buffers, i);
+    GstBuffer *actual_buffer = g_ptr_array_index (actual->sample_buffers, i);
+
+    compare_video_buffers (expected_buffer, actual_buffer, &info);
+  }
+}
+
+GST_START_TEST (test_vtdec_system_memory_output)
+{
+  static const gchar *required = {
+    "filesrc", "tsdemux", "h264parse", "vtdec", "fakesink"
+  };
+
+  run_vtdec_pipeline_test (required, G_N_ELEMENTS (required),
+      "video/x-raw,format=NV12 ! "
+      "fakesink name=sink signal-handoffs=true sync=false", FALSE);
+}
+
+GST_END_TEST;
+
+GST_START_TEST (test_vtdec_vulkan_image_download_matches_system_memory)
+{
+  static const gchar *required = {
+    "filesrc", "tsdemux", "h264parse", "vtdec", "vulkandownload", "appsink"
+  };
+  PipelineResult system_result;
+  PipelineResult vulkan_result;
+
+  if (!require_elements_or_skip (required, G_N_ELEMENTS (required)))
+    return;
+
+  system_result =
+      run_vtdec_sample_collection_pipeline ("video/x-raw,format=NV12 ! "
+      "appsink name=sink sync=false", FALSE);
+  vulkan_result =
+      run_vtdec_sample_collection_pipeline
+      ("video/x-raw(memory:VulkanImage),format=NV12 ! " "vulkandownload ! "
+      "video/x-raw,format=NV12 ! " "appsink name=sink sync=false", TRUE);
+
+  compare_pipeline_results (&system_result, &vulkan_result);
+
+  pipeline_result_clear (&vulkan_result);
+  pipeline_result_clear (&system_result);
+}
+
+GST_END_TEST;
+
+GST_START_TEST (test_vtdec_gl_download_matches_system_memory)
+{
+  static const gchar *required = {
+    "filesrc", "tsdemux", "h264parse", "vtdec", "gldownload", "appsink"
+  };
+  PipelineResult system_result;
+  PipelineResult gl_result;
+
+  if (!require_elements_or_skip (required, G_N_ELEMENTS (required)))
+    return;
+
+  system_result =
+      run_vtdec_sample_collection_pipeline ("video/x-raw,format=NV12 ! "
+      "appsink name=sink sync=false", FALSE);
+  gl_result =
+      run_vtdec_sample_collection_pipeline
+      ("video/x-raw(memory:GLMemory),format=NV12 ! " "gldownload ! "
+      "video/x-raw,format=NV12 ! " "appsink name=sink sync=false", FALSE);
+
+  compare_pipeline_results (&system_result, &gl_result);
+
+  pipeline_result_clear (&gl_result);
+  pipeline_result_clear (&system_result);
+}
+
+GST_END_TEST;
+
+GST_START_TEST (test_vtdec_gl_memory_output)
+{
+  static const gchar *required = {
+    "filesrc", "tsdemux", "h264parse", "vtdec", "glcolorconvert",
+    "gldownload", "fakesink"
+  };
+
+  run_vtdec_pipeline_test (required, G_N_ELEMENTS (required),
+      "video/x-raw(memory:GLMemory),format=NV12 ! "
+      "glcolorconvert ! "
+      "video/x-raw(memory:GLMemory),format=RGBA ! "
+      "gldownload ! "
+      "video/x-raw,format=RGBA ! "
+      "fakesink name=sink signal-handoffs=true sync=false", FALSE);
+}
+
+GST_END_TEST;
+
+GST_START_TEST (test_vtdec_vulkan_image_output)
+{
+  static const gchar *required = {
+    "filesrc", "tsdemux", "h264parse", "vtdec", "vulkancolorconvert",
+    "vulkandownload", "fakesink"
+  };
+
+  run_vtdec_pipeline_test (required, G_N_ELEMENTS (required),
+      "video/x-raw(memory:VulkanImage),format=NV12 ! "
+      "vulkancolorconvert ! "
+      "video/x-raw(memory:VulkanImage),format=BGRA ! "
+      "vulkandownload ! "
+      "video/x-raw,format=BGRA ! "
+      "fakesink name=sink signal-handoffs=true sync=false", TRUE);
+}
+
+GST_END_TEST;
+
+static Suite *
+vtdec_output_paths_suite (void)
+{
+  Suite *s = suite_create ("vtdec-output-paths");
+  TCase *tc_chain = tcase_create ("general");
+
+  suite_add_tcase (s, tc_chain);
+  tcase_add_test (tc_chain, test_vtdec_system_memory_output);
+  tcase_add_test (tc_chain, test_vtdec_gl_memory_output);
+  tcase_add_test (tc_chain, test_vtdec_vulkan_image_output);
+  tcase_add_test (tc_chain, test_vtdec_gl_download_matches_system_memory);
+  tcase_add_test (tc_chain,
+      test_vtdec_vulkan_image_download_matches_system_memory);
+
+  return s;
+}
+
+static int
+run_tests ()
+{
+  Suite *s = vtdec_output_paths_suite ();
+  /* VideoToolbox / GL / Vulkan integration is not fork-safe enough for the
+   * default check mode on Apple platforms. Run in-process like the other
+   * applemedia pipeline tests. */
+  return gst_check_run_suite_nofork (s, "vtdec-output-paths", __FILE__);
+}
+
+int
+main (int argc, char **argv)
+{
+  gst_check_init (&argc, &argv);
+#if TARGET_OS_OSX
+  return gst_macos_main_simple ((GstMainFuncSimple) run_tests, NULL);
+#else
+  return run_tests (argc, argv, NULL);
+#endif
+}

Overview

Request 6374 (superseded)

Request History