Request 6241 (accepted)

Overview

Request 6241 (accepted)

- Update to version 1.9.1:
* General
- Fixed FFV1 pixel format selection when an hardware decoder is used
(#6565)
- Fixed an issue that could happen when chapters titles are not UTF-8
(#6489)
- Fixed gcc14 aarch64 build failures (#6463)
* Subtitles
- Improved support for SRT files with overlapping subtitles (#6155)
* Audio
- Fixed AC3 and EAC3 extradata in MKV (#6582)
* Third-party libraries
- nv-codec-headers: Harden DLL loading so that it only uses system32 for
the search path on Windows (#6548)
- Updated libraries
- libdav1d 1.5.1 (AV1 video decoding)
- HarfBuzz 10.2.0 (subtitles)
- libjpeg-turbo 3.1.0 (preview image compression)
* Windows
- Fix an issue with the autoname function not updating when title is the
only option (#6517)
- Fix an issue where the audio encoder may not display correctly after a
queue has been imported and queue item edited. This may exhibit in other
scenarios as well (#6524)
- Fix an issue with titlebar / taskbar progress erroneously showing with
multi-instance encodes (#6477)
- Fix a crash when importing chapters where there is a chapter count
mis-match (#6514)
- Fixed an issue with autoname pre/postfix option where it would apply
regardless of file path collision.
- Fixed an issue where the crop controls would not enable correctly when
editing jobs (#6614)
- Rebuild Source1 download.tar.bz2

Created by manfred-h 7 months ago
In state accepted
4 package maintainers

Submit handbrake

Submit package home:manfred-h / handbrake to package Multimedia / handbrake

handbrake.changes Changed

@@ -1,4 +1,41 @@
 -------------------------------------------------------------------
+Thu Feb 13 13:24:12 UTC 2025 - Manfred Hollstein <manfred.h@gmx.net>
+
+- Update to version 1.9.1:
+  * General
+    - Fixed FFV1 pixel format selection when an hardware decoder is used
+      (#6565)
+    - Fixed an issue that could happen when chapters titles are not UTF-8
+      (#6489)
+    - Fixed gcc14 aarch64 build failures (#6463)
+  * Subtitles
+    - Improved support for SRT files with overlapping subtitles (#6155)
+  * Audio
+    - Fixed AC3 and EAC3 extradata in MKV (#6582)
+  * Third-party libraries
+    - nv-codec-headers: Harden DLL loading so that it only uses system32 for
+      the search path on Windows (#6548)
+    - Updated libraries
+      - libdav1d 1.5.1 (AV1 video decoding)
+      - HarfBuzz 10.2.0 (subtitles)
+      - libjpeg-turbo 3.1.0 (preview image compression)
+  * Windows
+    - Fix an issue with the autoname function not updating when title is the
+      only option (#6517)
+    - Fix an issue where the audio encoder may not display correctly after a
+      queue has been imported and queue item edited. This may exhibit in other
+      scenarios as well (#6524)
+    - Fix an issue with titlebar / taskbar progress erroneously showing with
+      multi-instance encodes (#6477)
+    - Fix a crash when importing chapters where there is a chapter count
+      mis-match (#6514)
+    - Fixed an issue with autoname pre/postfix option where it would apply
+      regardless of file path collision.
+    - Fixed an issue where the crop controls would not enable correctly when
+      editing jobs (#6614)
+- Rebuild Source1 download.tar.bz2
+
+-------------------------------------------------------------------
 Wed Feb 12 18:55:19 UTC 2025 - Manfred Hollstein <manfred.h@gmx.net>
 
 - Remove the _constraints file; 6G memory are not at all needed!

handbrake.spec Changed

1.9.0.tar.gz/NEWS.markdown -> 1.9.1.tar.gz/NEWS.markdown Changed

@@ -11,6 +11,43 @@
 - For Arm64 (Qualcomm or other)(https://aka.ms/dotnet/8.0/windowsdesktop-runtime-win-arm64.exe)
 
 
+## HandBrake 1.9.1
+
+### All platforms
+
+#### General
+
+- Fixed FFV1 pixel format selection when an hardware decoder is used (#6565)
+- Fixed an issue that could happen when chapters titles are not UTF-8 (#6489)
+- Fixed gcc14 aarch64 build failures (#6463)
+
+#### Subtitles
+
+- Improved support for SRT files with overlapping subtitles (#6155)
+
+#### Audio
+
+- Fixed AC3 and EAC3 extradata in MKV (#6582)
+
+#### Third-party libraries
+
+- nv-codec-headers: Harden DLL loading so that it only uses system32 for the search path on Windows (#6548)
+
+- Updated libraries
+  - libdav1d 1.5.1 (AV1 video decoding)
+  - HarfBuzz 10.2.0 (subtitles)
+  - libjpeg-turbo 3.1.0 (preview image compression)
+  
+### Windows
+
+- Fix an issue with the autoname function not updating when title is the only option (#6517)
+- Fix an issue where the audio encoder may not display correctly after a queue has been imported and queue item edited. This may exhibit in other scenarios as well (#6524)
+- Fix an issue with titlebar / taskbar progress erroneously showing with multi-instance encodes (#6477)
+- Fix a crash when importing chapters where there is a chapter count mis-match (#6514)
+- Fixed an issue with autoname pre/postfix option where it would apply regardless of file path collision.
+- Fixed an issue where the crop controls would not enable correctly when editing jobs (#6614)
+
+
 ## HandBrake 1.9.0
 
 ### All platforms

1.9.0.tar.gz/contrib/harfbuzz/module.defs -> 1.9.1.tar.gz/contrib/harfbuzz/module.defs Changed

1.9.0.tar.gz/contrib/libdav1d/module.defs -> 1.9.1.tar.gz/contrib/libdav1d/module.defs Changed

1.9.0.tar.gz/contrib/libjpeg-turbo/module.defs -> 1.9.1.tar.gz/contrib/libjpeg-turbo/module.defs Changed

1.9.1.tar.gz/contrib/nvenc/A01-dll-harden.patch Added

1.9.0.tar.gz/libhb/muxavformat.c -> 1.9.1.tar.gz/libhb/muxavformat.c Changed

@@ -552,6 +552,10 @@
             track->st->time_base = m->time_base;
         }
 
+        // Some containers don't need metadata for some audio formats,
+        // and for some formats extradata will be generated automatically,
+        // set only what's needed
+        int need_extradata = 0;
         switch (audio->config.out.codec & HB_ACODEC_MASK)
         {
             case HB_ACODEC_DCA:
@@ -576,17 +580,21 @@
                 break;
             case HB_ACODEC_VORBIS:
                 track->st->codecpar->codec_id = AV_CODEC_ID_VORBIS;
+                need_extradata = 1;
                 break;
             case HB_ACODEC_OPUS:
                 track->st->codecpar->codec_id = AV_CODEC_ID_OPUS;
+                need_extradata = 1;
                 break;
             case HB_ACODEC_FFALAC:
             case HB_ACODEC_FFALAC24:
                 track->st->codecpar->codec_id = AV_CODEC_ID_ALAC;
+                need_extradata = 1;
                 break;
             case HB_ACODEC_FFFLAC:
             case HB_ACODEC_FFFLAC24:
                 track->st->codecpar->codec_id = AV_CODEC_ID_FLAC;
+                need_extradata = 1;
                 break;
             case HB_ACODEC_FFAAC:
             case HB_ACODEC_CA_AAC:
@@ -594,6 +602,7 @@
             case HB_ACODEC_FDK_AAC:
             case HB_ACODEC_FDK_HAAC:
                 track->st->codecpar->codec_id = AV_CODEC_ID_AAC;
+                need_extradata = 1;
 
                 // AAC from pass-through source may be ADTS.
                 // Therefore inserting "aac_adtstoasc" bitstream filter is
@@ -623,9 +632,14 @@
                 goto error;
         }
 
-        if (set_extradata(audio->priv.extradata, &track->st->codecpar->extradata, &track->st->codecpar->extradata_size))
+        if (need_extradata)
         {
-            goto error;
+            if (set_extradata(audio->priv.extradata,
+                              &track->st->codecpar->extradata,
+                              &track->st->codecpar->extradata_size))
+            {
+                goto error;
+            }
         }
 
         if (track->bitstream_context != NULL)

1.9.0.tar.gz/libhb/rpu.c -> 1.9.1.tar.gz/libhb/rpu.c Changed

1.9.0.tar.gz/libhb/stream.c -> 1.9.1.tar.gz/libhb/stream.c Changed

@@ -10,6 +10,7 @@
 #include <string.h>
 #include <ctype.h>
 #include <errno.h>
+#include <iconv.h>
 
 #include "handbrake/handbrake.h"
 #include "handbrake/hbffmpeg.h"
@@ -6094,6 +6095,12 @@
     title->container_name = strdup( ic->iformat->name );
     title->data_rate = ic->bit_rate;
 
+    iconv_t iconv_context;
+    iconv_context = iconv_open("utf-8", "utf-8");
+
+    size_t utf8_buf_size = 2048;
+    char *utf8_buf = malloc(utf8_buf_size);
+
     hb_deep_log( 2, "Found ffmpeg %d chapters, container=%s", ic->nb_chapters, ic->iformat->name );
 
     if( ic->nb_chapters != 0 )
@@ -6131,10 +6138,29 @@
                 chapter->seconds = ( seconds % 60 );
 
                 tag = av_dict_get( m->metadata, "title", NULL, 0 );
+
+                // Detect if the chapter title is a valid UTF-8 string
+                char *p, *q;
+                size_t in_size, out_size, retval;
+
+                p = tag->value;
+                q = utf8_buf;
+
+                in_size = strlen(tag->value);
+                out_size = in_size;
+
+                if (utf8_buf_size < in_size)
+                {
+                    utf8_buf = realloc(utf8_buf, in_size);
+                }
+
+                retval = iconv(iconv_context, &p, &in_size, &q, &out_size);
+                int valid = retval != (size_t) -1;
+
                 /* Ignore generic chapter names set by MakeMKV
                  * ("Chapter 00" etc.).
                  * Our default chapter names are better. */
-                if( tag && tag->value && tag->value0 &&
+                if( valid && tag && tag->value && tag->value0 &&
                     ( strncmp( "Chapter ", tag->value, 8 ) ||
                       strlen( tag->value ) > 11 ) )
                 {
@@ -6155,6 +6181,9 @@
             }
     }
 
+    iconv_close(iconv_context);
+    free(utf8_buf);
+
     /*
      * Fill the metadata.
      */

1.9.0.tar.gz/libhb/sync.c -> 1.9.1.tar.gz/libhb/sync.c Changed

1.9.0.tar.gz/libhb/templates/comb_detect_template.c -> 1.9.1.tar.gz/libhb/templates/comb_detect_template.c Changed

@@ -270,7 +270,7 @@
                 mask_vec = vandq_u32(mask_vec, condition);
                 mask_vec = vandq_u32(mask_vec, v_one);
 
-                vst1q_u32(&mask32, mask_vec);
+                vst1q_u32(mask32, mask_vec);
 
                 mask0 = mask320;
                 mask1 = mask321;
@@ -550,7 +550,7 @@
                         mask_vec = vandq_u32(mask_vec, condition);
                         mask_vec = vandq_u32(mask_vec, v_one);
 
-                        vst1q_u32(&mask32, mask_vec);
+                        vst1q_u32(mask32, mask_vec);
 
                         mask0 = mask320;
                         mask1 = mask321;
@@ -568,7 +568,7 @@
                         mask_vec = vandq_u32(mask_vec, condition);
                         mask_vec = vandq_u32(mask_vec, v_one);
 
-                        vst1q_u32(&mask32, mask_vec);
+                        vst1q_u32(mask32, mask_vec);
 
                         mask0 = mask320;
                         mask1 = mask321;
@@ -585,7 +585,7 @@
                         mask_vec = vandq_u32(mask_vec, condition);
                         mask_vec = vandq_u32(mask_vec, v_one);
 
-                        vst1q_u32(&mask32, mask_vec);
+                        vst1q_u32(mask32, mask_vec);
 
                         mask0 = mask320;
                         mask1 = mask321;

1.9.0.tar.gz/libhb/templates/decomb_template.c -> 1.9.1.tar.gz/libhb/templates/decomb_template.c Changed

1.9.0.tar.gz/libhb/work.c -> 1.9.1.tar.gz/libhb/work.c Changed

@@ -1451,6 +1451,43 @@
 #endif
 }
 
+static enum AVPixelFormat match_pix_fmt(enum AVPixelFormat pix_fmt,
+                                        const enum AVPixelFormat *encoder_pix_fmts,
+                                        int keep_chroma,
+                                        int keep_depth)
+{
+    while (*encoder_pix_fmts != AV_PIX_FMT_NONE)
+    {
+        int match = 1;
+
+        const AVPixFmtDescriptor *input_desc = av_pix_fmt_desc_get(pix_fmt);
+        const AVPixFmtDescriptor *pix_fmt_desc = av_pix_fmt_desc_get(*encoder_pix_fmts);
+
+        if (keep_chroma)
+        {
+            match &= pix_fmt_desc->log2_chroma_w >= input_desc->log2_chroma_w &&
+                     pix_fmt_desc->log2_chroma_h >= input_desc->log2_chroma_h;
+        }
+
+        if (keep_depth)
+        {
+            int input_depth = hb_get_bit_depth(pix_fmt);
+            int candidate_depth = hb_get_bit_depth(*encoder_pix_fmts);
+
+            match &= input_depth == candidate_depth;
+        }
+
+        if (match)
+        {
+            return *encoder_pix_fmts;
+        }
+
+        encoder_pix_fmts++;
+    }
+
+    return AV_PIX_FMT_NONE;
+}
+
 static void sanitize_filter_list_post(hb_job_t *job)
 {
 #ifdef __APPLE__
@@ -1465,23 +1502,20 @@
     {
         // Some encoders require a specific input pixel format
         // that could be different from the current pipeline format.
-        const int *encoder_pix_fmts = hb_video_encoder_get_pix_fmts(job->vcodec, job->encoder_profile);
-        int encoder_pix_fmt = *encoder_pix_fmts;
+        const enum AVPixelFormat *encoder_pix_fmts = hb_video_encoder_get_pix_fmts(job->vcodec,job->encoder_profile);
 
         // Prefer a pixel format with the
-        // same chroma subsampling
-        while (*encoder_pix_fmts != AV_PIX_FMT_NONE)
+        // same chroma subsampling and depth
+        enum AVPixelFormat encoder_pix_fmt = match_pix_fmt(job->input_pix_fmt, encoder_pix_fmts, 1, 1);
+
+        if (encoder_pix_fmt == AV_PIX_FMT_NONE)
         {
-            const AVPixFmtDescriptor *input_desc = av_pix_fmt_desc_get(job->input_pix_fmt);
-            const AVPixFmtDescriptor *pix_fmt_desc = av_pix_fmt_desc_get(*encoder_pix_fmts);
+            encoder_pix_fmt = match_pix_fmt(job->input_pix_fmt, encoder_pix_fmts, 1, 0);
+        }
 
-            if (pix_fmt_desc->log2_chroma_w >= input_desc->log2_chroma_w &&
-                pix_fmt_desc->log2_chroma_h >= input_desc->log2_chroma_h)
-            {
-                encoder_pix_fmt = *encoder_pix_fmts;
-                break;
-            }
-            encoder_pix_fmts++;
+        if (encoder_pix_fmt == AV_PIX_FMT_NONE)
+        {
+            encoder_pix_fmt = match_pix_fmt(job->input_pix_fmt, encoder_pix_fmts, 0, 0);
         }
 
         hb_filter_object_t *filter = hb_filter_init(HB_FILTER_FORMAT);

1.9.0.tar.gz/macosx/HBTitleSelectionController.m -> 1.9.1.tar.gz/macosx/HBTitleSelectionController.m Changed

1.9.0.tar.gz/win/CS/HandBrake.App.Core/HandBrake.App.Core.csproj -> 1.9.1.tar.gz/win/CS/HandBrake.App.Core/HandBrake.App.Core.csproj Changed

1.9.0.tar.gz/win/CS/HandBrake.Interop/HandBrake.Interop.csproj -> 1.9.1.tar.gz/win/CS/HandBrake.Interop/HandBrake.Interop.csproj Changed

1.9.0.tar.gz/win/CS/HandBrake.Interop/Interop/Interfaces/Model/Encoders/HBAudioEncoder.cs -> 1.9.1.tar.gz/win/CS/HandBrake.Interop/Interop/Interfaces/Model/Encoders/HBAudioEncoder.cs Changed

1.9.0.tar.gz/win/CS/HandBrake.Nsis.Installer/Installer64.nsi -> 1.9.1.tar.gz/win/CS/HandBrake.Nsis.Installer/Installer64.nsi Changed

1.9.0.tar.gz/win/CS/HandBrake.Worker/HandBrake.Worker.csproj -> 1.9.1.tar.gz/win/CS/HandBrake.Worker/HandBrake.Worker.csproj Changed

1.9.0.tar.gz/win/CS/HandBrakeWPF/HandBrakeWPF.csproj -> 1.9.1.tar.gz/win/CS/HandBrakeWPF/HandBrakeWPF.csproj Changed

1.9.0.tar.gz/win/CS/HandBrakeWPF/Helpers/AutoNameHelper.cs -> 1.9.1.tar.gz/win/CS/HandBrakeWPF/Helpers/AutoNameHelper.cs Changed

@@ -282,14 +282,17 @@
 
             if (behaviour != AutonameFileCollisionBehaviour.AppendNumber)
             {
-                autoNamePath = Path.Combine(Path.GetDirectoryName(autoNamePath), prefix + filenameWithoutExt + postfix + extension);
-
-                int counter = 0;
-                while (File.Exists(autoNamePath))
+                if (File.Exists(autoNamePath))
                 {
-                    counter = counter + 1;
-                    string appendedNumber = string.Format("({0})", counter);
-                    autoNamePath = Path.Combine(Path.GetDirectoryName(autoNamePath), prefix + filenameWithoutExt + postfix + appendedNumber + extension);
+                    autoNamePath = Path.Combine(Path.GetDirectoryName(autoNamePath), prefix + filenameWithoutExt + postfix + extension);
+
+                    int counter = 0;
+                    while (File.Exists(autoNamePath))
+                    {
+                        counter = counter + 1;
+                        string appendedNumber = string.Format("({0})", counter);
+                        autoNamePath = Path.Combine(Path.GetDirectoryName(autoNamePath), prefix + filenameWithoutExt + postfix + appendedNumber + extension);
+                    }
                 }
             }
             else

1.9.0.tar.gz/win/CS/HandBrakeWPF/Model/ChangedOption.cs -> 1.9.1.tar.gz/win/CS/HandBrakeWPF/Model/ChangedOption.cs Changed

1.9.0.tar.gz/win/CS/HandBrakeWPF/Services/SystemService.cs -> 1.9.1.tar.gz/win/CS/HandBrakeWPF/Services/SystemService.cs Changed

1.9.0.tar.gz/win/CS/HandBrakeWPF/ViewModels/ChaptersViewModel.cs -> 1.9.1.tar.gz/win/CS/HandBrakeWPF/ViewModels/ChaptersViewModel.cs Changed

@@ -380,16 +380,18 @@
                 List<TimeSpan> diffs = new List<TimeSpan>();
                 foreach (KeyValuePair<int, Tuple<string, TimeSpan>> import in importedChapters)
                 {
-                    ChapterMarker sourceMarker = this.Chaptersimport.Key - 1;
-                    TimeSpan source = sourceMarker.Duration;
+                    int key = import.Key - 1;
 
-                    TimeSpan diff = source - import.Value.Item2;
-                    diffs.Add(diff);
+                    if (key <= (this.Chapters.Count -1))
+                    {
+                        ChapterMarker sourceMarker = this.Chapterskey;
+                        TimeSpan source = sourceMarker.Duration;
 
+                        TimeSpan diff = source - import.Value.Item2;
+                        diffs.Add(diff);
+                    }
                 }
 
-
-               // var diffs = importedChapters.Zip(this.Chapters, (import, source) => source.Duration - import.Value.Item2);
                 if (diffs.Count(diff => Math.Abs(diff.TotalSeconds) > 15) > 2)
                 {
                     if (this.errorService.ShowMessageBox(

1.9.0.tar.gz/win/CS/HandBrakeWPF/ViewModels/MainViewModel.cs -> 1.9.1.tar.gz/win/CS/HandBrakeWPF/ViewModels/MainViewModel.cs Changed

@@ -2206,7 +2206,7 @@
 
             bool is_execute = false;
             
-            if ((autonameFormat.Contains(Constants.Source) || autonameFormat.Contains(Constants.SourcePath) || autonameFormat.Contains(Constants.SourceFolderName)) && option == ChangedOption.Source)
+            if ((autonameFormat.Contains(Constants.Source) || autonameFormat.Contains(Constants.SourcePath) || autonameFormat.Contains(Constants.SourceFolderName) || autonameFormat.Contains(Constants.Title)) && option == ChangedOption.Source)
             {
                 is_execute = true;
             }
@@ -2512,11 +2512,15 @@
                         this.windowsTaskbar.SetNoProgress();
                         this.ProgramStatusLabel = string.Format(Resources.Main_QueueMultiJobStatus, this.queueProcessor.CompletedCount, Environment.NewLine, queueJobStatuses.Count, this.queueProcessor.Count);
 
+                        this.WindowTitle = Resources.HandBrake_Title; // Percentage is not available when multiple jobs are running. 
+                        this.windowsTaskbar.SetTaskBarProgress(0);
+
                         this.notifyIconService.SetTooltip(string.Format(Resources.TaskTrayStatusManyTitle, Resources.HandBrake_Title, queueJobStatuses.Count));
                         this.IsMultiProcess = true;
                         this.NotifyOfPropertyChange(() => this.IsMultiProcess);
                     }
-                });
+                }
+                );
         }
 
         private void UserSettingServiceSettingChanged(object sender, SettingChangedEventArgs e)

1.9.0.tar.gz/win/CS/HandBrakeWPF/ViewModels/PictureSettingsViewModel.cs -> 1.9.1.tar.gz/win/CS/HandBrakeWPF/ViewModels/PictureSettingsViewModel.cs Changed

1.9.0.tar.gz/win/CS/HandBrakeWPF/app.manifest -> 1.9.1.tar.gz/win/CS/HandBrakeWPF/app.manifest Changed

1.9.0.tar.gz/win/CS/HandBrakeWPF/packages.lock.json -> 1.9.1.tar.gz/win/CS/HandBrakeWPF/packages.lock.json Changed

download.tar.bz2/dav1d-1.5.0.tar.bz2 Deleted

download.tar.bz2/dav1d-1.5.1.tar.bz2 Added

version.txt Changed

Build Results
RPM Lint

Refresh

Comments for request 6241 0

Request History

manfred-h created request 7 months ago

malcolmlewis accepted request 7 months ago

Looks OK to me,....