Request 4499 (accepted)

Overview

Request 4499 (accepted)

- Added missing zlib dependency
- Spec cleanup

Created by Aloysius almost 5 years ago
In state accepted
Package maintainers: manfred-h and microchip8

Submit MakeMKV

Submit package home:Aloysius:branches:Multimedia / MakeMKV to package Multimedia / MakeMKV

makemkv.changes Changed

makemkv.spec Changed

@@ -1,6 +1,7 @@
 #
 # spec file for package makemkv
 #
+# Copyright (c) 2019 Packman Team <packman@links2linux.de>
 # Copyright (c) 2014 SUSE LINUX Products GmbH, Nuernberg, Germany.
 #
 # All modifications and additions to the file contributed by third parties
@@ -12,7 +13,7 @@
 # license that conforms to the Open Source Definition (Version 1.9)
 # published by the Open Source Initiative.
 
-# Please submit bugfixes or comments via http://bugs.opensuse.org/
+# Please submit bugfixes or comments via https://bugs.links2linux.org/
 #
 
 
@@ -32,7 +33,7 @@
 Release:        0
 License:        see eula_en_linux.txt
 Group:          Productivity/Multimedia/Video/Editors and Convertors
-Url:            http://www.makemkv.com
+URL:            http://www.makemkv.com
 Source0:        %{name}-oss-%{version}.tar.xz
 Source1:        %{name}-bin-%{version}.tar.xz
 BuildRoot:      %{_tmppath}/%{name}-%{version}-%{release}-root
@@ -53,6 +54,7 @@
 %endif
 BuildRequires:  pkgconfig(libavcodec) = 57.107.100
 BuildRequires:  pkgconfig(libavutil) = 55.78.100
+BuildRequires:  pkgconfig(zlib)
 BuildRequires:  update-desktop-files
 ExclusiveArch:  i586 x86_64
 
@@ -117,20 +119,20 @@
 
 %build
 %configure
-%{__make} %{?_smp_mflags}
+make %{?_smp_mflags}
 
 %install
 %make_install
 %suse_update_desktop_file -c makemkv makemkv "makemkv" makemkv makemkv.png AudioVideo AudioVideoEditing
 tar xaf %{SOURCE1}
 %ifarch x86_64
-  %{__install} -m 755 %{name}-bin-%{version}/bin/amd64/makemkvcon %{buildroot}%{_bindir}/
+  install -m 755 %{name}-bin-%{version}/bin/amd64/makemkvcon %{buildroot}%{_bindir}/
 %else
-  %{__install} -m 755 %{name}-bin-%{version}/bin/i386/makemkvcon %{buildroot}%{_bindir}/
+  install -m 755 %{name}-bin-%{version}/bin/i386/makemkvcon %{buildroot}%{_bindir}/
 %endif
 
 mkdir -p -m 755 %{buildroot}%{_datadir}/MakeMKV
-%{__install} -m 644 %{name}-bin-%{version}/src/share/* %{buildroot}%{_datadir}/MakeMKV/
+install -m 644 %{name}-bin-%{version}/src/share/* %{buildroot}%{_datadir}/MakeMKV/
 
 
 %post -n %{libnamedriveio} -p /sbin/ldconfig
@@ -144,7 +146,6 @@
 
 
 %files
-%defattr(-,root,root)
 %doc %{name}-bin-%{version}/src/eula_en_linux.txt
 %{_bindir}/makemkv
 %{_bindir}/makemkvcon
@@ -153,15 +154,12 @@
 %{_datadir}/applications/makemkv.desktop
 
 %files -n %{libnamedriveio}
-%defattr(-,root,root)
 %{_libdir}/%{libdriveio}.so.%{majordriveio}*
 
 %files -n %{libnamemakemkve}
-%defattr(-,root,root)
 %{_libdir}/%{libmakemkv}.so.%{majormakemkv}*
 
 %files -n %{libnamemmbd}
-%defattr(-,root,root)
 %{_libdir}/%{libmmbd}.so.%{majormmbd}*

Build Results
RPM Lint

Refresh

Comments for request 4499 0

Request History

Aloysius created request almost 5 years ago

- Added missing zlib dependency
- Spec cleanup

olh accepted request almost 5 years ago