Request 4376 (accepted)

This request supersedes: request 4368 (Show diff)

Overview

Request 4376 (accepted)

New stable release, gst-bad is patched for this now.

Created by zaitor over 5 years ago
In state accepted
Package maintainer: marguerite
Supersedes 4368

Submit fdk-aac

Submit package home:zaitor:branches:Essentials / fdk-aac to package Essentials / fdk-aac

fdk-aac.changes Changed

fdk-aac.spec Changed

@@ -15,19 +15,22 @@
 # Please submit bugfixes or comments via http://bugs.opensuse.org/
 #
 
+%define so_ver 2
+# Remember to bump so_ver in baselibs.conf too!
 
 Name:           fdk-aac
-Version:        0.1.6
+Version:        2.0.0
 Release:        0
 Summary:        A standalone library of the Fraunhofer FDK AAC code from Android
 License:        SUSE-NonFree
 Group:          System/Libraries
 URL:            https://github.com/mstorsjo/fdk-aac
-Source0:        https://github.com/mstorsjo/fdk-aac/archive/v%{version}.tar.gz
+Source0:        https://github.com/mstorsjo/fdk-aac/archive/v%{version}.tar.gz#/%{name}-%{version}.tar.gz
 Source1:        baselibs.conf
+
 BuildRequires:  gcc-c++
 BuildRequires:  libtool
-BuildRequires:  pkgconfig
+BuildRequires:  pkg-config
 
 %description
 A standalone library of the Fraunhofer FDK AAC code from Android
@@ -35,11 +38,11 @@
 For further information, read:
 wiki.hydrogenaud.io/Fraunhofer_FDK_AAC
 
-%package -n libfdk-aac1
+%package -n libfdk-aac%{so_ver}
 Summary:        A standalone library of the Fraunhofer FDK AAC code from Android
 Group:          System/Libraries
 
-%description -n libfdk-aac1
+%description -n libfdk-aac%{so_ver}
 A standalone library of the Fraunhofer FDK AAC code from Android
 
 For further information, read:
@@ -48,17 +51,16 @@
 %package devel
 Summary:        Development headers for Fraunhofer FDK AAC
 Group:          Development/Libraries/C and C++
-Requires:       libfdk-aac1 = %{version}
+Requires:       libfdk-aac%{so_ver} = %{version}
 
 %description devel
 This package provides development headers for Fraunhofer FDK AAC code
 
 %prep
-%setup -q
-FAKE_BUILDDATE=$(LC_ALL=C date -u -r %{_sourcedir}/%{name}.changes '+%%b %%e %%Y')
-sed -i "s/__DATE__/\"$FAKE_BUILDDATE\"/g" lib*/src/{*.cpp,version}
-FAKE_BUILDTIME=$(LC_ALL=C date -u -r %{_sourcedir}/%{name}.changes '+%%H:%%M:%%S')
-sed -i "s/__TIME__/\"$FAKE_BUILDTIME\"/g" lib*/src/{*.cpp,version}
+%autosetup -p1
+# Remove DATE/TIME, make build more reproducible
+sed -i "s/__DATE__/\"\"/g" lib*/src/{*.cpp,*version.h}
+sed -i "s/__TIME__/\"\"/g" lib*/src/{*.cpp,*version.h}
 
 %build
 NOCONFIGURE=1 ./autogen.sh
@@ -69,10 +71,10 @@
 %make_install
 find %{buildroot} -type f -name "*.la" -delete -print
 
-%post -n libfdk-aac1  -p /sbin/ldconfig
-%postun -n libfdk-aac1 -p /sbin/ldconfig
+%post -n libfdk-aac%{so_ver}  -p /sbin/ldconfig
+%postun -n libfdk-aac%{so_ver} -p /sbin/ldconfig
 
-%files -n libfdk-aac1
+%files -n libfdk-aac%{so_ver}
 %doc ChangeLog NOTICE
 %{_libdir}/libfdk-aac.so.*

baselibs.conf Changed

fdk-aac-2.0.0.tar.gz Added

v0.1.6.tar.gz Deleted

Build Results
RPM Lint

Refresh

Comments for request 4376 0
Comments for request 4368 2

zaitor wrote over 5 years ago

Do not ack this until a patched gstreamer-plugins-bad lands (already acked into SLED 15.0 Updates, so it should not be that long until it lands in Leap too.

zaitor wrote over 5 years ago

Patched gst-bad now in place :-) Please feel free to ack

Request History

zaitor created request over 5 years ago

New stable release, gst-bad is patched for this now.

malcolmlewis accepted request over 5 years ago

Hi, looks all good to me, thanks :)