Request 2307 (accepted)

Overview

Request 2307 (accepted)

- add fix-internal-plugins-load.patch
- build as RelWithDebInfo -- generate debuginfo

Created by jirislaby over 8 years ago
In state accepted
Package maintainers: detrei and enzokiel

Submit avidemux

Submit package home:jirislaby:...hes:Multimedia / avidemux to package Multimedia / avidemux

avidemux.changes Changed

avidemux.spec Changed

fix-internal-plugins-load.patch Added

@@ -0,0 +1,40 @@
+From: Jiri Slaby <jslaby@suse.cz>
+Subject: Fix internal plugins load
+
+When one selects an internal plugin like YV12 or MPEG-2 requant,
+avidemux crashes when trying to configure the plugin. It is because
+only part of the structure is initialized and ->configure hook is
+random bytes.
+
+Initialize the stored structure properly, similar to avidemux 2.6.10.
+This was completely rewritten there though.
+
+Signed-off-by: Jiri Slaby <jslaby@suse.cz>
+---
+ avidemux/ADM_encoder/ADM_pluginLoad.cpp |   15 ++-------------
+ 1 file changed, 2 insertions(+), 13 deletions(-)
+
+--- a/avidemux/ADM_encoder/ADM_pluginLoad.cpp
++++ b/avidemux/ADM_encoder/ADM_pluginLoad.cpp
+@@ -277,19 +277,8 @@ int loadVideoEncoderPlugins(int uiType,
+ 		{			
+ 			if (string(internalVideoCodecInfo[i]->tagName) == itRankedPlugin->id)
+ 			{
+-				COMPRES_PARAMS param;
+-				CODEC_INFO info;
+-
+-				param.codec = internalVideoCodec[i]->codec;
+-				param.extra_param = internalVideoCodec[i]->extra_param;
+-				param.extraSettings = internalVideoCodec[i]->extraSettings;
+-				param.extraSettingsLen = internalVideoCodec[i]->extraSettingsLen;
+-
+-				info.menuName = internalVideoCodecInfo[i]->menuName;
+-				info.tagName = internalVideoCodecInfo[i]->tagName;
+-
+-				AllVideoCodec.push_back(param);
+-				AllVideoCodecInfo.push_back(info);
++				AllVideoCodec.push_back(*internalVideoCodec[i]);
++				AllVideoCodecInfo.push_back(*internalVideoCodecInfo[i]);
+ 				found = true;
+ 
+ 				if (itRankedPlugin->isDefault)

Build Results
RPM Lint

Refresh

Comments for request 2307 0

Request History

jirislaby created request over 8 years ago

- add fix-internal-plugins-load.patch
- build as RelWithDebInfo -- generate debuginfo

olh accepted request over 8 years ago