jobermayr wrote almost 11 years ago

+# PATCH-FIX-UPSTREAM (see: https://en.opensuse.org/openSUSE:Packaging_Patches_guidelines) +Patch0: incorrect-fsf-address.patch

If not, please do it and provide a link ...

awissu wrote almost 11 years ago

http://www.gnu.org/licenses/old-licenses/gpl-2.0.en.html#SEC1

---

jobermayr wrote almost 11 years ago

I mean whether you forwarded your patches to ecasound developers.

awissu wrote almost 11 years ago

No.

olh wrote almost 11 years ago

IMO is not required to patch out odd FSF addresses, even if rpmlint complains about it.

Not sure why the %doc %mandir was removed. The "find |xargs rm" can be done with "find -print -delete". The Summary changes are unclear, any benefit in using %name? The compression was changed from .bz2 to .gz. Just do 'gunzip -vf *.gz; xz -vf9 *.tar' and use xz instead.

awissu wrote almost 11 years ago

Not sure why the %doc %mandir was removed. The man pages are marked as %doc automatically.

The "find |xargs rm" can be done with "find -print -delete". I will won't do it.

The compression was changed from .bz2 to .gz. Just do 'gunzip -vf *.gz; xz -vf9 *.tar' and use xz instead. The compression was changed in upstream project

---

olh wrote almost 11 years ago

Upstream always had .gz (unless they just recompressed their files and preserved the timestamps). Just the previous submit changed .gz to .bz2.