Overview
qmmp-plugin-pack.changes
Added
qmmp-plugin-pack.spec
Added
jobermayr wrote about 12 years ago
+%if 0%{?suse_version} == 1310 +BuildRequires: pkgconfig(libmpg123) +%endif
Why not for all?
+%dir %{_libdir}/qmmp/ +%dir %{_libdir}/qmmp/Input/
Multiple use of that can messup RPM installation and should be provided by %package -n libqmmp%{soname}-plugins
-> BuildRequires: libqmmp0-plugins
The better thing would be to move directories from -plugins to qmmp package.
olh wrote about 12 years ago
Please clearify what harm owning a directory does. In fact there is zero harm in just owning the directory itself by multiple packages. Looks like there is some misinformation floating around that just a single rpm should own a directory, even if multiple packages own directory entries within that directory.
The libmpg123 part deserves a comment from the submitter, it looks wrong to me.
jobermayr wrote about 12 years ago
If I remember right I get/got from time to time update/removal issues due to directories owned by multiple packages. Better safe than sorry.
olh wrote about 12 years ago
Such issues appear if one pkg1 owns just /dir/file and pkg2 owns /dir and /dir/file. If pkg2 gets removed before pkg1 then a stale /dir is left behind. Similar issues happen if /dir gets renamed to /some/dir in both pkgs, then /dir will remain depending on the order.
quarck wrote about 12 years ago
I do not understand what you want from me. It my first package ) I just got spec from pclinuxos and changed it to build in PMBS. There is no so much info where describes process of building package. I made this +%if 0%{?suse_version} == 1310 because package will not build for Factory And +%dir %{_libdir}/qmmp/ and so on because I got error "RPM cannot own directory". So where I should insert this lines %package -n libqmmp%{soname}-plugins; BuildRequires: libqmmp0-plugins?
olh wrote about 12 years ago
LGTM. But what is the reason for the libmpg123 part? What package provides it, and why does it exist only for 13.1? Shouldnt it be something like >= 1310 if the pkg providing libmpg123 is indeed a new pkg?
quarck wrote about 12 years ago
I tried >= 1310 and package didn't build for Factory, look at my home project.
olh wrote about 12 years ago
I see, home:quarck links to OBS instead of just Essentials (or Multimedia) Please adjust 'osc meta prj -e' and replace the openSUSE.org.* paths with Essentials Then remove the conditionals from the specfile.
Request History
quarck created request about 12 years ago
Set of extra plugins for qmmp
olh accepted request about 12 years ago
LGTM.
Please add also %dir _libdir/qmmp, %dir _libdir/qmmp/{Ui,Input) to the filelist, so that the package owns the directory it populates.