Projects
Essentials
A_tw-ffmpeg-7
ffmpeg-7-CVE-2026-38350_part02_c44d237.patch
Sign Up
Log In
Username
Password
Overview
Repositories
Revisions
Requests
Users
Attributes
Meta
File ffmpeg-7-CVE-2026-38350_part02_c44d237.patch of Package A_tw-ffmpeg-7
From c44d237d8069a7be8679b27106372f2ba8c0a51b Mon Sep 17 00:00:00 2001 From: Michael Niedermayer <michael@niedermayer.cc> Date: Wed, 30 Jul 2025 12:35:59 +0200 Subject: [PATCH] swscale/output: Fix integer overflow with lum/chr/alpha filter Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> --- libswscale/output.c | 94 ++++++++++++++++++++++----------------------- 1 file changed, 47 insertions(+), 47 deletions(-) diff --git a/libswscale/output.c b/libswscale/output.c --- a/libswscale/output.c +++ b/libswscale/output.c @@ -442,8 +442,8 @@ int v = chrDither[(i + 3) & 7] << 12; int j; for (j=0; j<chrFilterSize; j++) { - u += chrUSrc[j][i] * chrFilter[j]; - v += chrVSrc[j][i] * chrFilter[j]; + u += (unsigned)(chrUSrc[j][i] * chrFilter[j]); + v += (unsigned)(chrVSrc[j][i] * chrFilter[j]); } dest[2*i]= av_clip_uint8(u>>19); @@ -455,8 +455,8 @@ int v = chrDither[(i + 3) & 7] << 12; int j; for (j=0; j<chrFilterSize; j++) { - u += chrUSrc[j][i] * chrFilter[j]; - v += chrVSrc[j][i] * chrFilter[j]; + u += (unsigned)(chrUSrc[j][i] * chrFilter[j]); + v += (unsigned)(chrVSrc[j][i] * chrFilter[j]); } dest[2*i]= av_clip_uint8(v>>19); @@ -519,8 +519,8 @@ int v = 1 << (shift - 1); for (j = 0; j < chrFilterSize; j++) { - u += chrUSrc[j][i] * chrFilter[j]; - v += chrVSrc[j][i] * chrFilter[j]; + u += (unsigned)(chrUSrc[j][i] * chrFilter[j]); + v += (unsigned)(chrVSrc[j][i] * chrFilter[j]); } output_pixel(&dest[2*i] , u); @@ -617,8 +617,8 @@ int Y2 = 1 << 18; for (j = 0; j < lumFilterSize; j++) { - Y1 += lumSrc[j][i] * lumFilter[j]; - Y2 += lumSrc[j][i+1] * lumFilter[j]; + Y1 += (unsigned)(lumSrc[j][i] * lumFilter[j]); + Y2 += (unsigned)(lumSrc[j][i+1] * lumFilter[j]); } Y1 >>= 19; Y2 >>= 19; @@ -835,12 +835,12 @@ int V = 1 << 18; for (j = 0; j < lumFilterSize; j++) { - Y1 += lumSrc[j][i * 2] * lumFilter[j]; - Y2 += lumSrc[j][i * 2 + 1] * lumFilter[j]; + Y1 += (unsigned)(lumSrc[j][i * 2] * lumFilter[j]); + Y2 += (unsigned)(lumSrc[j][i * 2 + 1] * lumFilter[j]); } for (j = 0; j < chrFilterSize; j++) { - U += chrUSrc[j][i] * chrFilter[j]; - V += chrVSrc[j][i] * chrFilter[j]; + U += (unsigned)(chrUSrc[j][i] * chrFilter[j]); + V += (unsigned)(chrVSrc[j][i] * chrFilter[j]); } Y1 >>= 19; Y2 >>= 19; @@ -1735,12 +1735,12 @@ const void *r, *g, *b; for (j = 0; j < lumFilterSize; j++) { - Y1 += lumSrc[j][i * 2] * lumFilter[j]; - Y2 += lumSrc[j][i * 2 + 1] * lumFilter[j]; + Y1 += (unsigned)(lumSrc[j][i * 2] * lumFilter[j]); + Y2 += (unsigned)(lumSrc[j][i * 2 + 1] * lumFilter[j]); } for (j = 0; j < chrFilterSize; j++) { - U += chrUSrc[j][i] * chrFilter[j]; - V += chrVSrc[j][i] * chrFilter[j]; + U += (unsigned)(chrUSrc[j][i] * chrFilter[j]); + V += (unsigned)(chrVSrc[j][i] * chrFilter[j]); } Y1 >>= 19; Y2 >>= 19; @@ -1750,8 +1750,8 @@ A1 = 1 << 18; A2 = 1 << 18; for (j = 0; j < lumFilterSize; j++) { - A1 += alpSrc[j][i * 2 ] * lumFilter[j]; - A2 += alpSrc[j][i * 2 + 1] * lumFilter[j]; + A1 += (unsigned)(alpSrc[j][i * 2 ] * lumFilter[j]); + A2 += (unsigned)(alpSrc[j][i * 2 + 1] * lumFilter[j]); } A1 >>= 19; A2 >>= 19; @@ -2097,11 +2097,11 @@ int V = (1<<9)-(128 << 19); for (j = 0; j < lumFilterSize; j++) { - Y += lumSrc[j][i] * lumFilter[j]; + Y += (unsigned)(lumSrc[j][i] * lumFilter[j]); } for (j = 0; j < chrFilterSize; j++) { - U += chrUSrc[j][i] * chrFilter[j]; - V += chrVSrc[j][i] * chrFilter[j]; + U += (unsigned)(chrUSrc[j][i] * chrFilter[j]); + V += (unsigned)(chrVSrc[j][i] * chrFilter[j]); } Y >>= 10; U >>= 10; @@ -2109,7 +2109,7 @@ if (hasAlpha) { A = 1 << 18; for (j = 0; j < lumFilterSize; j++) { - A += alpSrc[j][i] * lumFilter[j]; + A += (unsigned)(alpSrc[j][i] * lumFilter[j]); } A >>= 19; if (A & 0x100) @@ -2272,11 +2272,11 @@ int R, G, B; for (j = 0; j < lumFilterSize; j++) - Y += lumSrc[j][i] * lumFilter[j]; + Y += (unsigned)(lumSrc[j][i] * lumFilter[j]); for (j = 0; j < chrFilterSize; j++) { - U += chrUSrc[j][i] * chrFilter[j]; - V += chrVSrc[j][i] * chrFilter[j]; + U += (unsigned)(chrUSrc[j][i] * chrFilter[j]); + V += (unsigned)(chrVSrc[j][i] * chrFilter[j]); } Y >>= 10; @@ -2287,7 +2287,7 @@ A = 1 << 18; for (j = 0; j < lumFilterSize; j++) - A += alpSrc[j][i] * lumFilter[j]; + A += (unsigned)(alpSrc[j][i] * lumFilter[j]); if (A & 0xF8000000) A = av_clip_uintp2(A, 27); @@ -2551,7 +2551,7 @@ int Y = 1 << 18, A = 1 << 18; for (j = 0; j < lumFilterSize; j++) - Y += lumSrc[j][i] * lumFilter[j]; + Y += (unsigned)(lumSrc[j][i] * lumFilter[j]); Y >>= 19; if (Y & 0x100) @@ -2559,7 +2559,7 @@ if (hasAlpha) { for (j = 0; j < lumFilterSize; j++) - A += alpSrc[j][i] * lumFilter[j]; + A += (unsigned)(alpSrc[j][i] * lumFilter[j]); A >>= 19; @@ -2634,11 +2634,11 @@ int j; for (j = 0; j < lumFilterSize; j++) - Y += lumSrc[j][i] * lumFilter[j]; + Y += (unsigned)(lumSrc[j][i] * lumFilter[j]); for (j = 0; j < chrFilterSize; j++) { - U += chrUSrc[j][i] * chrFilter[j]; - V += chrVSrc[j][i] * chrFilter[j]; + U += (unsigned)(chrUSrc[j][i] * chrFilter[j]); + V += (unsigned)(chrVSrc[j][i] * chrFilter[j]); } Y = av_clip_uintp2(Y >> 17, 10); @@ -2662,11 +2662,11 @@ int j; for (j = 0; j < lumFilterSize; j++) - Y += lumSrc[j][i] * lumFilter[j]; + Y += (unsigned)(lumSrc[j][i] * lumFilter[j]); for (j = 0; j < chrFilterSize; j++) { - U += chrUSrc[j][i] * chrFilter[j]; - V += chrVSrc[j][i] * chrFilter[j]; + U += (unsigned)(chrUSrc[j][i] * chrFilter[j]); + V += (unsigned)(chrVSrc[j][i] * chrFilter[j]); } AV_WL16(dest + 8 * i + 2, av_clip_uintp2(Y >> 15, 12) << 4); @@ -2691,13 +2691,13 @@ int V = 1 << 18, A = 255; for (j = 0; j < lumFilterSize; j++) - Y += lumSrc[j][i] * lumFilter[j]; + Y += (unsigned)(lumSrc[j][i] * lumFilter[j]); for (j = 0; j < chrFilterSize; j++) - U += chrUSrc[j][i] * chrFilter[j]; + U += (unsigned)(chrUSrc[j][i] * chrFilter[j]); for (j = 0; j < chrFilterSize; j++) - V += chrVSrc[j][i] * chrFilter[j]; + V += (unsigned)(chrVSrc[j][i] * chrFilter[j]); Y >>= 19; U >>= 19; @@ -2714,7 +2714,7 @@ A = 1 << 18; for (j = 0; j < lumFilterSize; j++) - A += alpSrc[j][i] * lumFilter[j]; + A += (unsigned)(alpSrc[j][i] * lumFilter[j]); A >>= 19; @@ -2750,13 +2750,13 @@ int U = 1 << (shift - 1), V = 1 << (shift - 1); \ \ for (j = 0; j < lumFilterSize; j++) { \ - Y1 += lumSrc[j][i * 2] * lumFilter[j]; \ - Y2 += lumSrc[j][i * 2 + 1] * lumFilter[j]; \ + Y1 += (unsigned)(lumSrc[j][i * 2] * lumFilter[j]); \ + Y2 += (unsigned)(lumSrc[j][i * 2 + 1] * lumFilter[j]); \ } \ \ for (j = 0; j < chrFilterSize; j++) { \ - U += chrUSrc[j][i] * chrFilter[j]; \ - V += chrVSrc[j][i] * chrFilter[j]; \ + U += (unsigned)(chrUSrc[j][i] * chrFilter[j]); \ + V += (unsigned)(chrVSrc[j][i] * chrFilter[j]); \ } \ \ output_pixel(dest + 8 * i + 0, Y1, bits); \
Locations
Projects
Search
Status Monitor
Help
Open Build Service
OBS Manuals
API Documentation
OBS Portal
Reporting a Bug
Contact
Mailing List
Forums
Chat (IRC)
Twitter
Open Build Service (OBS)
is an
openSUSE project
.