Packman Build Service PMBS

_service:obs_scm:vlc-beta-20251016.b8805d176.obscpio/configure.ac -> _service:obs_scm:vlc-beta-20251016.3097b1873.obscpio/configure.ac Changed

_service:obs_scm:vlc-beta-20251016.b8805d176.obscpio/contrib/src/main.mak -> _service:obs_scm:vlc-beta-20251016.3097b1873.obscpio/contrib/src/main.mak Changed

@@ -105,13 +105,6 @@
 endif
 endif
 
-# -fno-stack-check is a workaround for a possible
-# bug in Xcode 11 or macOS 10.15+
-ifdef HAVE_DARWIN_OS
-EXTRA_CFLAGS += -fno-stack-check
-XCODE_FLAGS += OTHER_CFLAGS=-fno-stack-check
-endif
-
 ifdef HAVE_MACOSX
 EXTRA_CXXFLAGS += -stdlib=libc++
 ifeq ($(ARCH),aarch64)
@@ -161,8 +154,21 @@
 HAVE_CLANG := 1
 CLANG_VERSION := $(shell $(CC) --version | head -1 | grep -o '0-9\+\.' | head -1 | cut -d '.' -f 1)
 clang_at_least = $(shell  $(CLANG_VERSION) -ge $(1)  && echo true)
+clang_at_most  = $(shell  $(CLANG_VERSION) -le $(1)  && echo true)
+clang_major_is = $(shell  $(CLANG_VERSION) -eq $(1)  && echo true)
 else
 clang_at_least = $(shell echo false)
+clang_at_most  = $(shell echo false)
+clang_major_is = $(shell echo false)
+endif
+
+# -fno-stack-check is a workaround for a possible
+# bug in Xcode 11 or macOS 10.15+
+ifdef HAVE_DARWIN_OS
+ifeq ($(call clang_major_is, 11), true)
+EXTRA_CFLAGS += -fno-stack-check
+XCODE_FLAGS += OTHER_CFLAGS=-fno-stack-check
+endif
 endif
 
 cppcheck = $(shell printf '$(2)' | $(CC) $(CFLAGS) -E -dM - 2>/dev/null | grep -E $(1))

_service:obs_scm:vlc-beta-20251016.b8805d176.obscpio/modules/gui/qt/dialogs/dialogs_provider.cpp -> _service:obs_scm:vlc-beta-20251016.3097b1873.obscpio/modules/gui/qt/dialogs/dialogs_provider.cpp Changed

_service:obs_scm:vlc-beta-20251016.b8805d176.obscpio/modules/gui/qt/dialogs/epg/EPGItem.cpp -> _service:obs_scm:vlc-beta-20251016.3097b1873.obscpio/modules/gui/qt/dialogs/epg/EPGItem.cpp Changed

_service:obs_scm:vlc-beta-20251016.b8805d176.obscpio/modules/gui/qt/dialogs/help/help.cpp -> _service:obs_scm:vlc-beta-20251016.3097b1873.obscpio/modules/gui/qt/dialogs/help/help.cpp Changed

_service:obs_scm:vlc-beta-20251016.b8805d176.obscpio/modules/gui/qt/dialogs/open/open_panels.cpp -> _service:obs_scm:vlc-beta-20251016.3097b1873.obscpio/modules/gui/qt/dialogs/open/open_panels.cpp Changed

_service:obs_scm:vlc-beta-20251016.b8805d176.obscpio/modules/gui/qt/dialogs/plugins/plugins.cpp -> _service:obs_scm:vlc-beta-20251016.3097b1873.obscpio/modules/gui/qt/dialogs/plugins/plugins.cpp Changed

_service:obs_scm:vlc-beta-20251016.b8805d176.obscpio/modules/gui/qt/dialogs/preferences/preferences_widgets.cpp -> _service:obs_scm:vlc-beta-20251016.3097b1873.obscpio/modules/gui/qt/dialogs/preferences/preferences_widgets.cpp Changed

@@ -410,7 +410,7 @@
                   QFileDialog::ShowDirsOnly | QFileDialog::DontResolveSymlinks );
 
     if( dir.isNull() ) return;
-    text->setText( toNativeSepNoSlash( dir ) );
+    text->setText( toNativeSepNoSlash( std::move(dir) ) );
 }
 
 /********* String / Font **********/
@@ -1665,7 +1665,7 @@
     }
 }
 
-void KeySelectorControl::reassign_key( KeyTableItem *item, QString key,
+void KeySelectorControl::reassign_key( KeyTableItem *item, const QString &key,
                                        enum KeySelectorControl::ColumnIndex column )
 {
     for (QTreeWidgetItemIterator iter(table); *iter; ++iter)
@@ -1739,12 +1739,12 @@
     setFont( KeySelectorControl::ACTION_COL,  font );
 }
 
-bool KeyTableItem::contains_key( QString key, enum KeySelectorControl::ColumnIndex column )
+bool KeyTableItem::contains_key( const QString &key, enum KeySelectorControl::ColumnIndex column )
 {
     return get_keys( column ).split( "\t" ).contains( key );
 }
 
-void KeyTableItem::remove_key( QString key, enum KeySelectorControl::ColumnIndex column )
+void KeyTableItem::remove_key( const QString &key, enum KeySelectorControl::ColumnIndex column )
 {
     QStringList keys_list = get_keys( column ).split( "\t" );
     if( keys_list.removeAll( key ) )

_service:obs_scm:vlc-beta-20251016.b8805d176.obscpio/modules/gui/qt/dialogs/preferences/preferences_widgets.hpp -> _service:obs_scm:vlc-beta-20251016.3097b1873.obscpio/modules/gui/qt/dialogs/preferences/preferences_widgets.hpp Changed

_service:obs_scm:vlc-beta-20251016.b8805d176.obscpio/modules/gui/qt/medialibrary/medialib.cpp -> _service:obs_scm:vlc-beta-20251016.3097b1873.obscpio/modules/gui/qt/medialibrary/medialib.cpp Changed

_service:obs_scm:vlc-beta-20251016.b8805d176.obscpio/modules/gui/qt/medialibrary/mlbookmarkmodel.cpp -> _service:obs_scm:vlc-beta-20251016.3097b1873.obscpio/modules/gui/qt/medialibrary/mlbookmarkmodel.cpp Changed

_service:obs_scm:vlc-beta-20251016.b8805d176.obscpio/modules/gui/qt/medialibrary/mlbookmarkmodel.hpp -> _service:obs_scm:vlc-beta-20251016.3097b1873.obscpio/modules/gui/qt/medialibrary/mlbookmarkmodel.hpp Changed

_service:obs_scm:vlc-beta-20251016.b8805d176.obscpio/modules/gui/qt/medialibrary/mlcustomcover.cpp -> _service:obs_scm:vlc-beta-20251016.3097b1873.obscpio/modules/gui/qt/medialibrary/mlcustomcover.cpp Changed

_service:obs_scm:vlc-beta-20251016.b8805d176.obscpio/modules/gui/qt/medialibrary/mlmediastore.hpp -> _service:obs_scm:vlc-beta-20251016.3097b1873.obscpio/modules/gui/qt/medialibrary/mlmediastore.hpp Changed

_service:obs_scm:vlc-beta-20251016.b8805d176.obscpio/modules/gui/qt/medialibrary/mlvideo.cpp -> _service:obs_scm:vlc-beta-20251016.3097b1873.obscpio/modules/gui/qt/medialibrary/mlvideo.cpp Changed

_service:obs_scm:vlc-beta-20251016.b8805d176.obscpio/modules/gui/qt/player/player_controller.cpp -> _service:obs_scm:vlc-beta-20251016.3097b1873.obscpio/modules/gui/qt/player/player_controller.cpp Changed

_service:obs_scm:vlc-beta-20251016.b8805d176.obscpio/modules/gui/qt/playlist/media.hpp -> _service:obs_scm:vlc-beta-20251016.3097b1873.obscpio/modules/gui/qt/playlist/media.hpp Changed

_service:obs_scm:vlc-beta-20251016.b8805d176.obscpio/modules/gui/qt/playlist/playlist_controller.hpp -> _service:obs_scm:vlc-beta-20251016.3097b1873.obscpio/modules/gui/qt/playlist/playlist_controller.hpp Changed

_service:obs_scm:vlc-beta-20251016.b8805d176.obscpio/modules/gui/qt/playlist/playlist_model.cpp -> _service:obs_scm:vlc-beta-20251016.3097b1873.obscpio/modules/gui/qt/playlist/playlist_model.cpp Changed

@@ -65,7 +65,7 @@
     that->callAsync(=() {
         if (that->m_playlist != playlist)
             return;
-        that->onItemsReset(newContent);
+        that->onItemsReset(std::move(newContent));
     });
 }
 
@@ -79,7 +79,7 @@
     that->callAsync(=() {
         if (that->m_playlist != playlist)
             return;
-        that->onItemsAdded(added, index);
+        that->onItemsAdded(std::move(added), index);
     });
 }
 
@@ -171,7 +171,7 @@
     }
 }
 
-void PlaylistListModelPrivate::onItemsReset(const QVector<PlaylistItem>& newContent)
+void PlaylistListModelPrivate::onItemsReset(const QVector<PlaylistItem>&& newContent)
 {
     Q_Q(PlaylistListModel);
     q->beginResetModel();
@@ -190,7 +190,7 @@
     emit q->countChanged(m_items.size());
 }
 
-void PlaylistListModelPrivate::onItemsAdded(const QVector<PlaylistItem>& added, size_t index)
+void PlaylistListModelPrivate::onItemsAdded(const QVector<PlaylistItem>&& added, size_t index)
 {
     Q_Q(PlaylistListModel);
     int count = added.size();

_service:obs_scm:vlc-beta-20251016.b8805d176.obscpio/modules/gui/qt/playlist/playlist_model_p.hpp -> _service:obs_scm:vlc-beta-20251016.3097b1873.obscpio/modules/gui/qt/playlist/playlist_model_p.hpp Changed

_service:obs_scm:vlc-beta-20251016.b8805d176.obscpio/modules/gui/qt/style/gtkthemeprovider/gtk_util.cpp -> _service:obs_scm:vlc-beta-20251016.3097b1873.obscpio/modules/gui/qt/style/gtkthemeprovider/gtk_util.cpp Changed

@@ -116,7 +116,7 @@
         gtk_style_context_set_parent(child_context, context);
 
         gtk_widget_path_unref(path);
-        return GtkCssContext(child_context);
+        return GtkCssContext(std::move(child_context));
     }
 }
 
@@ -342,7 +342,7 @@
                 break;
             }
             case CSS_CLASS:
-                classes.push_back(token);
+                classes.push_back(std::move(token));
                 break;
             case CSS_PSEUDOCLASS: {
                 GtkStateFlags state_flag = GTK_STATE_FLAG_NORMAL;
@@ -392,7 +392,7 @@
 
     float scale = std::round(GetDeviceScaleFactor());
 
-    return AppendCssNodeToStyleContextImpl(context, gtype, name, object_name,
+    return AppendCssNodeToStyleContextImpl(std::move(context), gtype, name, object_name,
                                            classes, state, scale);
 }
 
@@ -432,7 +432,7 @@
                       "}");
     MySize size(24, 24);
     CairoSurface surface(size);
-    RenderBackground(size, surface.cairo(), context);
+    RenderBackground(size, surface.cairo(), std::move(context));
     return surface.GetAveragePixelValue(false);
 }
 
@@ -467,7 +467,7 @@
 
 void ApplyCssToContext(GtkCssContext context, const std::string& css) {
     auto provider = GetCssProvider(css);
-    ApplyCssProviderToContext(context, provider);
+    ApplyCssProviderToContext(std::move(context), provider);
 }
 
 void RenderBackground(const MySize& size,
@@ -504,7 +504,7 @@
 
 GdkRGBA GetSelectionBgColor(const std::string& css_selector) {
     auto context = GetStyleContextFromCss(css_selector);
-    return GetBgColorFromStyleContext(context);
+    return GetBgColorFromStyleContext(std::move(context));
 }

_service:obs_scm:vlc-beta-20251016.b8805d176.obscpio/modules/gui/qt/style/gtkthemeprovider/gtkthemeprovider.cpp -> _service:obs_scm:vlc-beta-20251016.3097b1873.obscpio/modules/gui/qt/style/gtkthemeprovider/gtkthemeprovider.cpp Changed

@@ -66,7 +66,7 @@
 static void setGtkColorSet(vlc_qt_theme_provider_t* obj,
                            vlc_qt_theme_color_set set, vlc_qt_theme_color_section section,
                            vlc_qt_theme_color_name name,
-                           std::function<GdkRGBA (std::string)> getter, std::string selector)
+                           std::function<GdkRGBA (std::string)> getter, const std::string &selector)
 {
     setGtkColor(obj, set, section, name, VQTC_STATE_NORMAL, getter(selector));
     setGtkColor(obj, set, section, name, VQTC_STATE_DISABLED, getter(selector + ":disabled"));
@@ -77,32 +77,32 @@
 
 static void setGtkColorSetBg(vlc_qt_theme_provider_t* obj,
                            vlc_qt_theme_color_set set,  vlc_qt_theme_color_name name,
-                               std::string selector)
+                             const std::string &selector)
 {
-    setGtkColorSet(obj, set, VQTC_SECTION_BG, name, GetBgColor, selector);
+    setGtkColorSet(obj, set, VQTC_SECTION_BG, name, GetBgColor, std::move(selector));
 }
 
 static void setGtkColorSetFg(vlc_qt_theme_provider_t* obj,
                            vlc_qt_theme_color_set set,  vlc_qt_theme_color_name name,
-                               std::string selector)
+                             const std::string &selector)
 {
-    setGtkColorSet(obj, set, VQTC_SECTION_FG, name, GetFgColor, selector);
+    setGtkColorSet(obj, set, VQTC_SECTION_FG, name, GetFgColor, std::move(selector));
 }
 
 static void setGtkColorSetFgFromBg(vlc_qt_theme_provider_t* obj,
                            vlc_qt_theme_color_set set,  vlc_qt_theme_color_name name,
-                               std::string selector)
+                                   const std::string &selector)
 {
-    setGtkColorSet(obj, set, VQTC_SECTION_FG, name, GetBgColor, selector);
+    setGtkColorSet(obj, set, VQTC_SECTION_FG, name, GetBgColor, std::move(selector));
 }
 
 
-static void setGtkColorSetBorder(vlc_qt_theme_provider_t* obj, vlc_qt_theme_color_set set, std::string selector)
+static void setGtkColorSetBorder(vlc_qt_theme_provider_t* obj, vlc_qt_theme_color_set set, const std::string &selector)
 {
-    setGtkColorSet(obj, set, VQTC_SECTION_DECORATION, VQTC_NAME_BORDER, GetBorderColor, selector);
+    setGtkColorSet(obj, set, VQTC_SECTION_DECORATION, VQTC_NAME_BORDER, GetBorderColor, std::move(selector));
 }
 
-static void setGtkColorSetHighlight(vlc_qt_theme_provider_t* obj, vlc_qt_theme_color_set set, std::string selector)
+static void setGtkColorSetHighlight(vlc_qt_theme_provider_t* obj, vlc_qt_theme_color_set set, const std::string &selector)
 {
     auto setFgBg = obj, set, &selector(vlc_qt_theme_color_state state, std::string stateStr)
     {

_service:obs_scm:vlc-beta-20251016.b8805d176.obscpio/modules/gui/qt/util/base_model.cpp -> _service:obs_scm:vlc-beta-20251016.3097b1873.obscpio/modules/gui/qt/util/base_model.cpp Changed

_service:obs_scm:vlc-beta-20251016.b8805d176.obscpio/modules/gui/qt/util/color_svg_image_provider.cpp -> _service:obs_scm:vlc-beta-20251016.3097b1873.obscpio/modules/gui/qt/util/color_svg_image_provider.cpp Changed

_service:obs_scm:vlc-beta-20251016.b8805d176.obscpio/modules/gui/qt/util/color_svg_image_provider.hpp -> _service:obs_scm:vlc-beta-20251016.3097b1873.obscpio/modules/gui/qt/util/color_svg_image_provider.hpp Changed

_service:obs_scm:vlc-beta-20251016.b8805d176.obscpio/modules/gui/qt/util/qt_dirs.hpp -> _service:obs_scm:vlc-beta-20251016.3097b1873.obscpio/modules/gui/qt/util/qt_dirs.hpp Changed

_service:obs_scm:vlc-beta-20251016.b8805d176.obscpio/modules/gui/qt/util/variables.cpp -> _service:obs_scm:vlc-beta-20251016.3097b1873.obscpio/modules/gui/qt/util/variables.cpp Changed

_service:obs_scm:vlc-beta-20251016.b8805d176.obscpio/modules/gui/qt/util/variables.hpp -> _service:obs_scm:vlc-beta-20251016.3097b1873.obscpio/modules/gui/qt/util/variables.hpp Changed

@@ -114,7 +114,7 @@
 
 public:
     template<typename T>
-    QVLCVariable(T* object, QString property, QObject* parent)
+    QVLCVariable(T* object, const QString &property, QObject* parent)
         : QObject(parent)
         , m_object(new VLCObjectHolderImpl<T>(nullptr))
         , m_property(property)
@@ -193,7 +193,7 @@
         if (m_object->get() != object)
             return;
         if (m_value != value) {
-            m_value = value;
+            m_value = std::move(value);
             Derived* derived = static_cast<Derived*>(this);
             emit derived->valueChanged( m_value );
         }
@@ -225,7 +225,7 @@
     Q_PROPERTY(bool value READ getValue WRITE setValue NOTIFY valueChanged FINAL)
 
     template<typename T>
-    QVLCBool(T* object, QString property, QObject* parent = nullptr)
+    QVLCBool(T* object, const QString &property, QObject* parent = nullptr)
         : QVLCVariable<QVLCBool, bool>(object, property, parent)
     {
         resetObject<T>(object);
@@ -251,7 +251,7 @@
     Q_PROPERTY(QString value READ getValue WRITE setValue NOTIFY valueChanged FINAL)
 
     template<typename T>
-    QVLCString(T* object, QString property, QObject* parent = nullptr)
+    QVLCString(T* object, const QString &property, QObject* parent = nullptr)
         : QVLCVariable<QVLCString, QString>(object, property, parent)
     {
         resetObject<T>(object);
@@ -263,7 +263,7 @@
     }
 
 public slots:
-    void setValue(QString value);
+    void setValue(const QString &value);
 
 signals:
     void valueChanged( QString );
@@ -277,7 +277,7 @@
     Q_PROPERTY(float value READ getValue WRITE setValue NOTIFY valueChanged FINAL)
 
     template<typename T>
-    QVLCFloat(T* object, QString property, QObject* parent = nullptr)
+    QVLCFloat(T* object, const QString &property, QObject* parent = nullptr)
         : QVLCVariable<QVLCFloat, float>(object, property, parent)
     {
         resetObject<T>(object);
@@ -304,7 +304,7 @@
     Q_PROPERTY(int64_t value READ getValue WRITE setValue NOTIFY valueChanged FINAL)
 
     template<typename T>
-    QVLCInteger(T* object, QString property, QObject* parent = nullptr)
+    QVLCInteger(T* object, const QString &property, QObject* parent = nullptr)
         : QVLCVariable<QVLCInteger, int64_t>(object, property, parent)
     {
         resetObject<T>(object);

_service:obs_scm:vlc-beta-20251016.b8805d176.obscpio/modules/gui/qt/widgets/native/customwidgets.cpp -> _service:obs_scm:vlc-beta-20251016.3097b1873.obscpio/modules/gui/qt/widgets/native/customwidgets.cpp Changed

_service:obs_scm:vlc-beta.obsinfo Changed

Changes of Revision 145