Packman Build Service PMBS

pipewire-aptx.changes Changed

pipewire-aptx.spec Changed

_service Changed

_service:download_url:pipewire-1.4.1.tar.bz2/NEWS -> _service:download_url:pipewire-1.4.2.tar.bz2/NEWS Changed

@@ -1,3 +1,37 @@
+# PipeWire 1.4.2 (2025-04-14)
+
+This is a bugfix release that is API and ABI compatible with
+previous 1.x releases.
+
+## Highlights
+  - Do extra checks for MIDI to avoid 100% CPU usage on older kernels.
+  - Fix some potential crashes in POD builder.
+  - pw-cat streaming improvements on stdout/stdin.
+  - Small fixes and improvements.
+
+
+## PipeWire
+  - Make the service files depend on DBus to avoid startup races.
+
+## SPA
+  - Do extra checks for MIDI to avoid 100% CPU usage on older kernels.
+  - Use Header metadata by default in videoadapter.
+  - Handle set_format result from v4l2 better.
+  - Handle crash when POD builder overflows in the filter.
+  - Work around a libebur128 bug. (#4646)
+
+## Tools
+  - pw-cat prefers AU format when streaming on stdout/stdin. (#4629)
+  - Improve pw-cat verbose sndfile format debug.
+  - Add the missing --channel-map long option to pw-loopback.
+
+## GStreamer
+  - Fix a leak in the deviceprovider. (#4616)
+  - Fix negotiation and make renegotiation better.
+
+
+Older versions:
+
 # PipeWire 1.4.1 (2025-03-14)
 
 This is a quick bugfix release that is API and ABI compatible with
@@ -35,9 +69,6 @@
 ## Bluetooth
   - Fix a crash with an incomming call.
 
-
-Older versions:
-
 # PipeWire 1.4.0 (2025-03-06)
 
 This is the 1.4 release that is API and ABI compatible with previous

_service:download_url:pipewire-1.4.1.tar.bz2/doc/dox/programs/pw-link.1.md -> _service:download_url:pipewire-1.4.2.tar.bz2/doc/dox/programs/pw-link.1.md Changed

_service:download_url:pipewire-1.4.1.tar.bz2/meson.build -> _service:download_url:pipewire-1.4.2.tar.bz2/meson.build Changed

_service:download_url:pipewire-1.4.1.tar.bz2/spa/include/spa/pod/filter.h -> _service:download_url:pipewire-1.4.2.tar.bz2/spa/include/spa/pod/filter.h Changed

_service:download_url:pipewire-1.4.1.tar.bz2/spa/plugins/alsa/alsa-seq.c -> _service:download_url:pipewire-1.4.2.tar.bz2/spa/plugins/alsa/alsa-seq.c Changed

_service:download_url:pipewire-1.4.1.tar.bz2/spa/plugins/audioconvert/audioadapter.c -> _service:download_url:pipewire-1.4.2.tar.bz2/spa/plugins/audioconvert/audioadapter.c Changed

_service:download_url:pipewire-1.4.1.tar.bz2/spa/plugins/audioconvert/audioconvert.c -> _service:download_url:pipewire-1.4.2.tar.bz2/spa/plugins/audioconvert/audioconvert.c Changed

_service:download_url:pipewire-1.4.1.tar.bz2/spa/plugins/filter-graph/ebur128_plugin.c -> _service:download_url:pipewire-1.4.2.tar.bz2/spa/plugins/filter-graph/ebur128_plugin.c Changed

_service:download_url:pipewire-1.4.1.tar.bz2/spa/plugins/v4l2/v4l2-source.c -> _service:download_url:pipewire-1.4.2.tar.bz2/spa/plugins/v4l2/v4l2-source.c Changed

_service:download_url:pipewire-1.4.1.tar.bz2/spa/plugins/videoconvert/videoadapter.c -> _service:download_url:pipewire-1.4.2.tar.bz2/spa/plugins/videoconvert/videoadapter.c Changed

_service:download_url:pipewire-1.4.1.tar.bz2/src/daemon/systemd/user/meson.build -> _service:download_url:pipewire-1.4.2.tar.bz2/src/daemon/systemd/user/meson.build Changed

_service:download_url:pipewire-1.4.1.tar.bz2/src/daemon/systemd/user/pipewire.service.in -> _service:download_url:pipewire-1.4.2.tar.bz2/src/daemon/systemd/user/pipewire.service.in Changed

_service:download_url:pipewire-1.4.1.tar.bz2/src/gst/gstpipewiredeviceprovider.c -> _service:download_url:pipewire-1.4.2.tar.bz2/src/gst/gstpipewiredeviceprovider.c Changed

_service:download_url:pipewire-1.4.1.tar.bz2/src/gst/gstpipewireformat.c -> _service:download_url:pipewire-1.4.2.tar.bz2/src/gst/gstpipewireformat.c Changed

@@ -1065,8 +1065,19 @@
     {
       if (n_items < 3)
         return;
-      gst_caps_set_simple (res, width, GST_TYPE_INT_RANGE, rect1.width, rect2.width,
-                                height, GST_TYPE_INT_RANGE, rect1.height, rect2.height, NULL);
+
+      if (rect1.width == rect2.width &&
+          rect1.height == rect2.height) {
+        gst_caps_set_simple (res,
+            width, G_TYPE_INT, rect1.width,
+            height, G_TYPE_INT, rect1.height,
+            NULL);
+      } else {
+        gst_caps_set_simple (res,
+            width, GST_TYPE_INT_RANGE, rect1.width, rect2.width,
+            height, GST_TYPE_INT_RANGE, rect1.height, rect2.height,
+            NULL);
+      }
       break;
     }
     case SPA_CHOICE_Enum:
@@ -1117,8 +1128,17 @@
     {
       if (n_items < 3)
         return;
-      gst_caps_set_simple (res, key, GST_TYPE_FRACTION_RANGE, fract1.num, fract1.denom,
-                                                              fract2.num, fract2.denom, NULL);
+
+      if (fract1.num == fract2.num &&
+          fract1.denom == fract2.denom) {
+        gst_caps_set_simple (res, key, GST_TYPE_FRACTION,
+            fract1.num, fract1.denom, NULL);
+      } else {
+        gst_caps_set_simple (res, key, GST_TYPE_FRACTION_RANGE,
+            fract1.num, fract1.denom,
+            fract2.num, fract2.denom,
+            NULL);
+      }
       break;
     }
     case SPA_CHOICE_Enum:

_service:download_url:pipewire-1.4.1.tar.bz2/src/gst/gstpipewiresink.c -> _service:download_url:pipewire-1.4.2.tar.bz2/src/gst/gstpipewiresink.c Changed

@@ -305,6 +305,7 @@
   struct spa_pod_builder b = { NULL };
   uint8_t buffer1024;
   struct spa_pod_frame f;
+  guint n_params = 0;
 
   config = gst_buffer_pool_get_config (GST_BUFFER_POOL (pool));
   gst_buffer_pool_config_get_params (config, &caps, &size, &min_buffers, &max_buffers);
@@ -325,20 +326,22 @@
                                                 (1<<SPA_DATA_MemFd) |
                                                 (1<<SPA_DATA_MemPtr)),
       0);
-  port_params0 = spa_pod_builder_pop (&b, &f);
+  port_paramsn_params++ = spa_pod_builder_pop (&b, &f);
 
-  port_params1 = spa_pod_builder_add_object (&b,
+  port_paramsn_params++ = spa_pod_builder_add_object (&b,
       SPA_TYPE_OBJECT_ParamMeta, SPA_PARAM_Meta,
       SPA_PARAM_META_type, SPA_POD_Id(SPA_META_Header),
       SPA_PARAM_META_size, SPA_POD_Int(sizeof (struct spa_meta_header)));
 
-  port_params2 = spa_pod_builder_add_object (&b,
-      SPA_TYPE_OBJECT_ParamMeta, SPA_PARAM_Meta,
-      SPA_PARAM_META_type, SPA_POD_Id(SPA_META_VideoCrop),
-      SPA_PARAM_META_size, SPA_POD_Int(sizeof (struct spa_meta_region)));
+  if (sink->is_video) {
+    port_paramsn_params++ = spa_pod_builder_add_object (&b,
+        SPA_TYPE_OBJECT_ParamMeta, SPA_PARAM_Meta,
+        SPA_PARAM_META_type, SPA_POD_Id(SPA_META_VideoCrop),
+        SPA_PARAM_META_size, SPA_POD_Int(sizeof (struct spa_meta_region)));
+  }
 
   pw_thread_loop_lock (sink->stream->core->loop);
-  pw_stream_update_params (sink->stream->pwstream, port_params, 3);
+  pw_stream_update_params (sink->stream->pwstream, port_params, n_params);
   pw_thread_loop_unlock (sink->stream->core->loop);
 }

_service:download_url:pipewire-1.4.1.tar.bz2/src/gst/gstpipewiresrc.c -> _service:download_url:pipewire-1.4.2.tar.bz2/src/gst/gstpipewiresrc.c Changed

@@ -1091,14 +1091,34 @@
   }
 
   pw_peer_caps = gst_caps_from_format (param);
+
   if (pw_peer_caps && pwsrc->possible_caps) {
+    GST_DEBUG_OBJECT (pwsrc, "peer caps %" GST_PTR_FORMAT, pw_peer_caps);
+    GST_DEBUG_OBJECT (pwsrc, "possible caps %" GST_PTR_FORMAT, pwsrc->possible_caps);
+
     pwsrc->caps = gst_caps_intersect_full (pw_peer_caps,
                                            pwsrc->possible_caps,
                                            GST_CAPS_INTERSECT_FIRST);
+
+  /*
+   * We expect pw_peer_caps to be fixed caps as we receive that from
+   * PipeWire. See pw_context_find_format() and SPA_PARAM_Format.
+   * possible_caps can be non-fixated caps based on what is downstream
+   * in the pipeline.
+   *
+   * The intersection result above might give us non-fixated caps. A
+   * possible scenario for this is the below pipeline.
+   * pipewiresrc ! audioconvert ! audio/x-raw,rate=44100,channels=2 ! ..
+   *
+   * So we fixate the caps explicitly here.
+   */
+    pwsrc->caps = gst_caps_fixate (pwsrc->caps);
     gst_caps_maybe_fixate_dma_format (pwsrc->caps);
   }
 
-  if (pwsrc->caps && gst_caps_is_fixed (pwsrc->caps)) {
+  if (pwsrc->caps) {
+    g_return_if_fail (gst_caps_is_fixed (pwsrc->caps));
+
     pwsrc->negotiated = TRUE;
 
     structure = gst_caps_get_structure (pwsrc->caps, 0);
@@ -1127,14 +1147,15 @@
 #ifdef HAVE_GSTREAMER_DMA_DRM
       }
 #endif
+    } else {
+      /* Don't provide bufferpool for audio if not requested by the
+       * application/user */
+      if (pwsrc->use_bufferpool != USE_BUFFERPOOL_YES)
+        pwsrc->use_bufferpool = USE_BUFFERPOOL_NO;
     }
   } else {
     pwsrc->negotiated = FALSE;
     pwsrc->is_video = FALSE;
-
-    /* Don't provide bufferpool for audio if not requested by the application/user */
-    if (pwsrc->use_bufferpool != USE_BUFFERPOOL_YES)
-      pwsrc->use_bufferpool = USE_BUFFERPOOL_NO;
   }
 
   if (pwsrc->caps) {
@@ -1158,7 +1179,7 @@
                                                             pwsrc->min_buffers,
                                                             pwsrc->max_buffers),
         SPA_PARAM_BUFFERS_blocks,  SPA_POD_CHOICE_RANGE_Int(0, 1, INT32_MAX),
-        SPA_PARAM_BUFFERS_size,    SPA_POD_CHOICE_RANGE_Int(0, 0, INT32_MAX),
+        SPA_PARAM_BUFFERS_size,    SPA_POD_CHOICE_RANGE_Int(0, 1, INT32_MAX),
         SPA_PARAM_BUFFERS_stride,  SPA_POD_CHOICE_RANGE_Int(0, 0, INT32_MAX),
         SPA_PARAM_BUFFERS_dataType, SPA_POD_CHOICE_FLAGS_Int(buffertypes));

_service:download_url:pipewire-1.4.1.tar.bz2/src/modules/module-raop-sink.c -> _service:download_url:pipewire-1.4.2.tar.bz2/src/modules/module-raop-sink.c Changed

_service:download_url:pipewire-1.4.1.tar.bz2/src/pipewire/impl-link.c -> _service:download_url:pipewire-1.4.2.tar.bz2/src/pipewire/impl-link.c Changed

_service:download_url:pipewire-1.4.1.tar.bz2/src/tools/pw-cat.c -> _service:download_url:pipewire-1.4.2.tar.bz2/src/tools/pw-cat.c Changed

@@ -1343,7 +1343,7 @@
 		}
 	}
 	if (format == -1)
-		format = SF_FORMAT_WAV;
+		format = spa_streq(filename, "-") ? SF_FORMAT_AU : SF_FORMAT_WAV;
 	if (format == SF_FORMAT_WAV && info->channels > 2)
 		format = SF_FORMAT_WAVEX;
 
@@ -1436,6 +1436,21 @@
 }
 #endif
 
+static const char *endianness_to_name(int format)
+{
+	switch (format & SF_FORMAT_ENDMASK) {
+	case SF_ENDIAN_FILE:
+		return "Default Endian";
+	case SF_ENDIAN_LITTLE:
+		return "Little Endian";
+	case SF_ENDIAN_BIG:
+		return "Big Endian";
+	case SF_ENDIAN_CPU:
+		return "CPU Endian";
+	}
+	return "unknown";
+}
+
 static int setup_sndfile(struct data *data)
 {
 	const struct format_info *fi = NULL;
@@ -1473,9 +1488,21 @@
 		return -EIO;
 	}
 
-	if (data->verbose)
-		fprintf(stderr, "sndfile: opened file \"%s\" format %08x channels:%d rate:%d\n",
-				data->filename, info.format, info.channels, info.samplerate);
+	if (data->verbose) {
+		SF_FORMAT_INFO ti, sti;
+		spa_zero(ti);
+		ti.format = info.format & SF_FORMAT_TYPEMASK;
+		if (sf_command(NULL, SFC_GET_FORMAT_INFO, &ti, sizeof(ti)) != 0)
+			ti.name = "unknown";
+		spa_zero(sti);
+		sti.format = info.format & SF_FORMAT_SUBMASK;
+		if (sf_command(NULL, SFC_GET_FORMAT_INFO, &sti, sizeof(sti)) != 0)
+			sti.name = "unknown";
+
+		fprintf(stderr, "sndfile: opened file \"%s\" format \"%s %s %s\" channels:%d rate:%d\n",
+				data->filename, endianness_to_name(info.format),
+				ti.name, sti.name, info.channels, info.samplerate);
+	}
 	if (data->channels > 0 && info.channels != (int)data->channels) {
 		fprintf(stderr, "sndfile: given channels (%u) don't match file channels (%d)\n",
 				data->channels, info.channels);
@@ -1511,7 +1538,6 @@
 		/* try native format first, else decode to float */
 		if ((fi = format_info_by_sf_format(info.format)) == NULL)
 			fi = format_info_by_sf_format(SF_FORMAT_FLOAT);
-
 	}
 	if (fi == NULL)
 		return -EIO;

_service:download_url:pipewire-1.4.1.tar.bz2/src/tools/pw-loopback.c -> _service:download_url:pipewire-1.4.2.tar.bz2/src/tools/pw-loopback.c Changed

Changes of Revision 53