Packman Build Service PMBS

gstreamer-plugins-bad-codecs.changes Changed

gstreamer-plugins-bad-codecs.spec Changed

_service Changed

_service:download_url:gst-plugins-bad-1.24.11.tar.xz/ChangeLog -> _service:download_url:gst-plugins-bad-1.24.12.tar.xz/ChangeLog Changed

@@ -1,3 +1,188 @@
+=== release 1.24.12 ===
+
+2025-01-29 20:12:29 +0000  Tim-Philipp Müller <tim@centricular.com>
+
+	* NEWS:
+	* RELEASE:
+	* gst-plugins-bad.doap:
+	* meson.build:
+	  Release 1.24.12
+
+2024-12-30 21:59:03 +0100  Samuel Thibault <samuel.thibault@ens-lyon.org>
+
+	* ext/gtk/meson.build:
+	* tests/examples/gtk/meson.build:
+	* tests/examples/waylandsink/meson.build:
+	  meson: Fix build with gtk3 but not wayland
+	  Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8260>
+
+2025-01-20 18:19:18 +0100  Andoni Morales Alastruey <ylatuya@gmail.com>
+
+	* sys/applemedia/vtdec.c:
+	  vtdec: fix seeks hangs due to a race condition draining
+	  If the drain function of the decoder triggered by FLUSH_START
+	  is run while the output loop is running, once the output loop
+	  finished vtdec->downstream_ret will be GST_FLOW_FLUSHING instead
+	  of GST_FLOW_OK, which must not be treated as an error since
+	  the queue is cleaned correctly as well.
+	  Fix #4179
+	  Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8361>
+
+2025-01-23 13:20:50 +0100  Guillaume Desmottes <guillaume.desmottes@onestream.live>
+
+	* ext/wpe/gstwpevideosrc.cpp:
+	  wpe: remove glFlush() when filling buffer
+	  According to https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/4162#note_2739338
+	  it was introduced as workaround for tearing issues.
+	  I do not experience any tearing without flushing on both nvidia and AMD
+	  GPU, so I suppose it's no longer needed.
+	  Slightly improve CPU usage according to my tests.
+	  Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8355>
+
+2025-01-20 18:37:23 +0200  Sebastian Dröge <sebastian@centricular.com>
+
+	* gst/mpegtsdemux/mpegtspacketizer.c:
+	  tsdemux: Fix backwards PTS wraparound detection with ignore-pcr=true
+	  Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8332>
+
+2025-01-10 14:15:21 +0200  Sebastian Dröge <sebastian@centricular.com>
+
+	* sys/decklink/gstdecklinkvideosink.cpp:
+	  decklinkvideosink: Fix handling of caps framerate in auto mode
+	  Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8306>
+
+2025-01-09 00:42:48 +0100  Carlos Bentzen <cadubentzen@igalia.com>
+
+	* ext/webrtc/gstwebrtcbin.c:
+	* tests/check/elements/webrtcbin.c:
+	  webrtc: fix duplicate payload types with RTX and multiple video codecs
+	  Before this patch, there could be duplicate payload types in offers that
+	  have, within a media section, multiple codecs and RTX enabled:
+	  ```
+	  m=video 9 UDP/TLS/RTP/SAVPF 96 97 97 <-- HAS DUPLICATES
+	  a=sendrecv
+	  a=rtpmap:96 VP8/90000
+	  a=rtcp-fb:96 nack
+	  a=rtcp-fb:96 nack pli
+	  a=rtcp-fb:96 ccm fir
+	  a=rtcp-fb:96 transport-cc
+	  a=rtpmap:97 H264/90000
+	  a=rtcp-fb:97 nack
+	  a=rtcp-fb:97 nack pli
+	  a=rtcp-fb:97 ccm fir
+	  a=rtcp-fb:97 transport-cc
+	  a=rtpmap:97 rtx/90000  <--------- PT IS DUPLICATE
+	  a=fmtp:97 apt=96
+	  ```
+	  Fix this by populating the media_mapping array with all media formats
+	  rather than only the first one. The added test case reproduces the issue,
+	  which fails without this patch.
+	  Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8294>
+
+2025-01-09 11:39:11 +0100  Edward Hervey <edward@centricular.com>
+
+	* sys/wasapi/gstwasapisink.c:
+	  wasapi: Use signed value for can_frames
+	  The can retrieval function can return negative values (which will be properly handled)
+	  Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8293>
+
+2025-01-09 10:08:23 +0100  Edward Hervey <edward@centricular.com>
+
+	* sys/amfcodec/gstamfav1enc.cpp:
+	* sys/amfcodec/gstamfh264enc.cpp:
+	* sys/amfcodec/gstamfh265enc.cpp:
+	  amfcodec: Add missing break statement
+	  Setting frame-sad would also set ltr
+	  Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8293>
+
+2025-01-06 09:57:33 +0100  Edward Hervey <edward@centricular.com>
+
+	* gst-libs/gst/codecparsers/gsth265bitwriter.c:
+	  h265bitwriter: Don't use type too small
+	  The computed `coef_val` could exceed the maximum range of a gint8. Use a bigger
+	  one, the checks after will ensure it's properly cropped/padded
+	  Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8293>
+
+2025-01-05 12:08:24 +0100  Edward Hervey <edward@centricular.com>
+
+	* gst-libs/gst/mpegts/gstmpegtssection.c:
+	  mpegts: Add missing break
+	  Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8293>
+
+2025-01-05 11:46:21 +0100  Edward Hervey <edward@centricular.com>
+
+	* gst-libs/gst/mse/gstmsemediatype.c:
+	  msemediabuffer: Fix ASCII character detection
+	  Use glib function. The previous check was checking whether a signed int was
+	  lower than its limit (which ... is always TRUE).
+	  Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8293>
+
+2025-01-05 11:43:49 +0100  Edward Hervey <edward@centricular.com>
+
+	* gst-libs/gst/mse/gstsourcebuffer.c:
+	  msesourcebuffer: Fix unsigned value handling
+	  Use the explicit valid clocktime handler instead
+	  Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8293>
+
+2025-01-05 11:41:44 +0100  Edward Hervey <edward@centricular.com>
+
+	* gst/rist/gstristsink.c:
+	  ristsink: Add missing break
+	  Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8293>
+
+2025-01-07 12:56:13 +0200  Sebastian Dröge <sebastian@centricular.com>
+
+	* sys/decklink/gstdecklinkaudiosink.cpp:
+	  decklinkaudiosink: Don't crash if started without corresponding video sink
+	  Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8291>
+
+2025-01-09 16:13:44 -0500  Monty C <montyc1999@gmail.com>
+
+	* sys/d3d12/hlsl/VSMain_color.hlsl:
+	* sys/d3d12/hlsl/VSMain_coord.hlsl:
+	* sys/d3d12/hlsl/VSMain_pos.hlsl:
+	  d3d12: Fix shaders failing to compile with newer dxc versions
+	  Newer dxc versions enable HLSL 2021 by default, which disallows implicit casting of structs.
+	  Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8274>
+
+2025-01-09 17:23:41 +0000  Colin Kinloch <colin.kinloch@collabora.com>
+
+	* gst-libs/gst/wayland/gstwldisplay.c:
+	  wayland: Print table split when DMABuf format changes
+	  The `zwp_linux_dmabuf_v1` doesn't specify an order for modifier events
+	  to be sent.
+	  In my case the linear format was sent last resulting in the first item
+	  in each row being the previous format.
+	  Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8277>
+
+2024-12-25 15:04:03 +0100  Philippe Normand <philn@igalia.com>
+
+	* ext/wpe/gstwpethreadedview.cpp:
+	* ext/wpe/gstwpethreadedview.h:
+	* ext/wpe/gstwpevideosrc.cpp:
+	  wpevideosrc: Clear cached SHM buffers after caps re-negotiation
+	  Otherwise buffers not corresponding to the negotiated caps might be pushed
+	  downstream.
+	  Fixes #4094
+	  Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8266>
+
+2024-12-27 13:28:18 +0100  Philippe Normand <philn@igalia.com>
+
+	* ext/wpe/gstwpevideosrc.cpp:
+	  wpevideosrc: Post progress messages on the bus
+	  Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8265>
+
+2024-12-25 14:42:16 +0100  Philippe Normand <philn@igalia.com>
+
+	* ext/wpe/gstwpevideosrc.cpp:
+	  wpevideosrc: Handle latency queries
+	  Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8265>
+
+2025-01-06 20:11:58 +0000  Tim-Philipp Müller <tim@centricular.com>
+
+	* meson.build:
+	  Back to development after 1.24.11
+
 === release 1.24.11 ===
 
 2025-01-06 19:48:08 +0000  Tim-Philipp Müller <tim@centricular.com>

_service:download_url:gst-plugins-bad-1.24.11.tar.xz/NEWS -> _service:download_url:gst-plugins-bad-1.24.12.tar.xz/NEWS Changed

@@ -1276,7 +1276,7 @@
 -   There are known issues with FFmpeg version 6.0.0 due to opaque passing being broken in that version. This affects at least
     avdec_h264, but may affect other decoders as well. Versions before 6.0.0, and 6.0.1 or higher are not affected.
 
--   gst-libav currently doesn’t build against the latest FFmpeg 7.0 release. This is being worked on and tracked in this “libav:
+-   gst-libav < 1.24.6 didn’t build against the latest FFmpeg 7.0 release. This has been worked on and tracked in this “libav:
     Fix compatibility with ffmpeg 7” Merge Request.
 
 ## Statistics
@@ -3030,6 +3030,147 @@
 -   List of Merge Requests applied in 1.24.11
 -   List of Issues fixed in 1.24.11
 
+1.24.12
+
+The twelfth 1.24 bug-fix release (1.24.12) was released on 29 January 2025.
+
+This release only contains bugfixes and it should be safe to update from 1.24.x.
+
+Highlighted bugfixes in 1.24.12
+
+-   d3d12: Fix shaders failing to compile with newer dxc versions
+-   decklinkvideosink: Fix handling of caps framerate in auto mode; also a decklinkaudiosink fix
+-   devicemonitor: Fix potential crash macOS when a device is unplugged
+-   gst-libav: Fix crash in audio encoders like avenc_ac3 if input data has insufficient alignment
+-   gst-libav: Fix build against FFmpeg 4.2 as in Ubuntu 20.04
+-   gst-editing-services: Fix Python library name fetching on Windows
+-   netclientclock: Don’t store failed internal clocks in the cache, so applications can re-try later
+-   oggdemux: Seeking and duration handling fixes
+-   osxaudiosrc: Fixes for failing init/no output on recent iOS versions
+-   qtdemux: Use mvhd transform matrix and support for flipping
+-   rtpvp9pay: Fix profile parsing
+-   splitmuxsrc: Fix use with decodebin3 which would occasionally fail with an assertion when seeking
+-   tsdemux: Fix backwards PTS wraparound detection with ignore-pcr=true
+-   video-overlay-composition: Declare the video/size/orientation tags for the meta and implement scale transformations
+-   vtdec: Fix seeks occasionally hanging on macOS due to a race condition when draining
+-   webrtc: Fix duplicate payload types with RTX and multiple video codecs
+-   win32-pluginloader: Make sure not to create any windows when inspecting plugins
+-   wpe: Various fixes for re-negotiation, latency reporting, progress messages on startup
+-   x264enc: Add missing data to AvcDecoderConfigurationRecord in codec_data for high profile variants
+-   cerbero: Support using ccache with cmake if enabled
+-   Various bug fixes, build fixes, memory leak fixes, and other stability and reliability improvements
+
+gstreamer
+
+-   device: Fix racy nullptr deref on macOS when a device is unplugged
+-   iterator: Added error handling to filtered iterators
+-   netclientclock: Don’t ever store failed internal clocks in the cache
+-   netclock-replay: use gst_c_args when building, fixing build failure on Solaris
+-   pluginloader-win32: create no window
+-   pluginloader-win32: fix use after free in find_helper_bin_location
+-   sparsefile: ensure error is set when read_buffer() returns 0
+-   basetransform: fix incorrect logging inside gst_base_transform_query_caps
+
+gst-plugins-base
+
+-   oggdemux: fixes seeking in some cases by not overwriting a valid duration with CLOCK_TIME_NONE
+-   video-overlay-composition: Declare the video/size/orientation tags for the meta & implement scale transformation
+-   Various fixes found from adding extra warning flags
+
+gst-plugins-good
+
+-   osxaudiosrc: Fixes for failing init/no output on recent iOS versions
+-   qtdemux: Use mvhd transform matrix and support for flipping
+-   qtmux: fix critical warnings on negotiation error
+-   rtpvp9pay: fix profile parsing
+-   splitmuxsrc: Ensure only a single stream-start event is pushed
+-   splitmuxsrc: decodebin3 Fails with assertion in mq_slot_handle_stream_start when seeking
+-   Various fixes found from adding extra warning flags
+
+gst-plugins-bad
+
+-   decklinkvideosink: Fix handling of caps framerate in auto mode
+-   decklinkaudiosink: Don’t crash if started without corresponding video sink
+-   d3d12: Fix shaders failing to compile with newer dxc versions
+-   tsdemux: Fix backwards PTS wraparound detection with ignore-pcr=true
+-   vtdec: fix seeks hangs due to a race condition draining
+-   vtdec: seeks freeze the pipeline
+-   wayland: Print table split when DMABuf format changes
+-   webrtc: fix duplicate payload types with RTX and multiple video codecs
+-   wpevideosrc: Clear cached SHM buffers after caps re-negotiation
+-   wpe: Report latency and start-up progress messages
+-   wpe: remove glFlush() when filling buffer
+-   Fix build with gtk3 but not wayland
+-   Various fixes found from adding extra warning flags
+
+gst-plugins-ugly
+
+-   x264enc: add missing data to AvcDecoderConfigurationRecord, and switch to GstByteWriter
+
+GStreamer Rust plugins
+
+-   No changes
+
+gst-libav
+
+-   avaudenc: fix crash in avenc_ac3 if input buffers are insufficiently aligned
+-   avcodecmap: Only use new channel positions when compiling against new enough ffmpeg
+-   gst-libav: 1.24.11: Fails to build with minimum supported ffmpeg version
+
+gst-rtsp-server
+
+-   No changes
+
+gstreamer-vaapi
+
+-   No changes
+
+gstreamer-sharp
+
+-   No changes
+
+gst-omx
+
+-   No changes
+
+gst-python
+
+-   No changes
+
+gst-editing-services
+
+-   ges: Fix Python library name fetching on Windows
+
+gst-devtools, gst-validate + gst-integration-testsuites
+
+-   No changes
+
+gst-examples
+
+-   No changes
+
+Development build environment
+
+-   No changes
+
+Cerbero build tool and packaging changes in 1.24.12
+
+-   cmake: Support using ccache if enabled
+
+Contributors to 1.24.12
+
+Adrian Perez de Castro, Alan Coopersmith, Alexander Slobodeniuk, Andoni Morales Alastruey, Andrew Yooeun Chun, Brad Hards,
+Carlos Bentzen, Colin Kinloch, Edward Hervey, François Laignel, Guillaume Desmottes, Jochen Henneberg, Jordan Yelloz, L. E.
+Segovia, Monty C, Nirbheek Chauhan, Philippe Normand, Piotr Brzeziński, Rares Branici, Samuel Thibault, Sebastian Dröge, Silvio
+Lazzeretti, Tim-Philipp Müller, Tomas Granath, Will Miller,
+
+… and many others who have contributed bug reports, translations, sent suggestions or helped testing. Thank you all!
+
+List of merge requests and issues fixed in 1.24.12
+
+-   List of Merge Requests applied in 1.24.12
+-   List of Issues fixed in 1.24.12
+
 Schedule for 1.26
 
 Our next major feature release will be 1.26, and 1.25 will be the unstable development version leading up to the stable 1.26

_service:download_url:gst-plugins-bad-1.24.11.tar.xz/RELEASE -> _service:download_url:gst-plugins-bad-1.24.12.tar.xz/RELEASE Changed

_service:download_url:gst-plugins-bad-1.24.11.tar.xz/ext/gtk/meson.build -> _service:download_url:gst-plugins-bad-1.24.12.tar.xz/ext/gtk/meson.build Changed

_service:download_url:gst-plugins-bad-1.24.11.tar.xz/ext/webrtc/gstwebrtcbin.c -> _service:download_url:gst-plugins-bad-1.24.12.tar.xz/ext/webrtc/gstwebrtcbin.c Changed

_service:download_url:gst-plugins-bad-1.24.11.tar.xz/ext/wpe/gstwpethreadedview.cpp -> _service:download_url:gst-plugins-bad-1.24.12.tar.xz/ext/wpe/gstwpethreadedview.cpp Changed

@@ -711,6 +711,37 @@
     });
 }
 
+void GstWPEThreadedView::clearBuffers()
+{
+  bool dispatchFrameComplete = false;
+  {
+    GMutexHolder lock(images_mutex);
+
+    if (shm.pending) {
+      auto meta = gst_buffer_get_video_meta(shm.pending);
+      if (static_cast<int>(meta->width) != wpe.width || static_cast<int>(meta->height) != wpe.height) {
+        gst_clear_buffer(&shm.pending);
+        dispatchFrameComplete = true;
+      }
+    }
+
+    if (shm.committed) {
+      auto meta = gst_buffer_get_video_meta(shm.committed);
+      if (static_cast<int>(meta->width) != wpe.width || static_cast<int>(meta->height) != wpe.height) {
+        gst_clear_buffer(&shm.committed);
+        dispatchFrameComplete = true;
+      }
+    }
+  }
+
+  if (dispatchFrameComplete) {
+    frameComplete();
+    // Wait until the next SHM buffer has been received.
+    threading.ready = false;
+    waitLoadCompletion();
+  }
+}
+
 void GstWPEThreadedView::frameComplete()
 {
     GST_TRACE("frame complete");

_service:download_url:gst-plugins-bad-1.24.11.tar.xz/ext/wpe/gstwpethreadedview.h -> _service:download_url:gst-plugins-bad-1.24.12.tar.xz/ext/wpe/gstwpethreadedview.h Changed

_service:download_url:gst-plugins-bad-1.24.11.tar.xz/ext/wpe/gstwpevideosrc.cpp -> _service:download_url:gst-plugins-bad-1.24.12.tar.xz/ext/wpe/gstwpevideosrc.cpp Changed

@@ -174,6 +174,17 @@
     GST_PAD_ALWAYS,
     GST_STATIC_CAPS (WPE_VIDEO_SRC_CAPS));
 
+#define GST_ELEMENT_PROGRESS(el, type, code, text)                             \
+  G_STMT_START {                                                               \
+    gchar *__txt = _gst_element_error_printf text;                             \
+    gst_element_post_message (                                                 \
+        GST_ELEMENT_CAST (el),                                                 \
+        gst_message_new_progress (GST_OBJECT_CAST (el),                        \
+                                  GST_PROGRESS_TYPE_##type, code, __txt));     \
+    g_free (__txt);                                                            \
+  }                                                                            \
+  G_STMT_END
+
 static GstFlowReturn
 gst_wpe_video_src_create (GstBaseSrc * bsrc, guint64 offset, guint length,
     GstBuffer ** buf)
@@ -270,7 +281,6 @@
   gl->BindTexture (GL_TEXTURE_2D, tex_id);
   gl->EGLImageTargetTexture2D (GL_TEXTURE_2D,
       gst_egl_image_get_image (locked_image));
-  gl->Flush ();
   WPE_UNLOCK (src);
   return TRUE;
 }
@@ -284,6 +294,7 @@
   gboolean created_view = FALSE;
   GBytes *bytes;
 
+  GST_ELEMENT_PROGRESS (src, START, "open", ("Starting up"));
   GST_INFO_OBJECT (src, "Starting up");
   WPE_LOCK (src);
 
@@ -298,26 +309,37 @@
   auto & thread = GstWPEContextThread::singleton ();
 
   if (!src->view) {
-    src->view = thread.createWPEView (src, context, display,
+    GST_ELEMENT_PROGRESS (src, CONTINUE, "open", ("Creating WPE WebView"));
+    src->view =
+        thread.createWPEView (src, context, display,
         GST_VIDEO_INFO_WIDTH (&base_src->out_info),
         GST_VIDEO_INFO_HEIGHT (&base_src->out_info));
     created_view = TRUE;
     GST_DEBUG_OBJECT (src, "created view %p", src->view);
+    GST_ELEMENT_PROGRESS (src, CONTINUE, "open", ("WPE WebView is ready"));
   }
 
   if (!src->view) {
     WPE_UNLOCK (src);
+    GST_ELEMENT_PROGRESS (src, ERROR, "open",
+        ("WPEBackend-FDO EGL display initialisation failed"));
     GST_ELEMENT_ERROR (src, RESOURCE, FAILED,
         ("WPEBackend-FDO EGL display initialisation failed"), (NULL));
     return FALSE;
   }
 
+  if (!created_view) {
+    GST_INFO_OBJECT (src, "Re-starting after re-negotiation, clearing cached SHM buffers");
+    src->view->clearBuffers ();
+  }
+
   GST_OBJECT_LOCK (src);
   bytes = src->bytes;
   src->bytes = NULL;
   GST_OBJECT_UNLOCK (src);
 
   if (bytes != NULL) {
+    GST_ELEMENT_PROGRESS (src, CONTINUE, "open", ("Loading HTML data"));
     src->view->loadData (bytes);
     g_bytes_unref (bytes);
   }
@@ -326,6 +348,7 @@
     src->n_frames = 0;
   }
   WPE_UNLOCK (src);
+  GST_ELEMENT_PROGRESS (src, COMPLETE, "open", ("Ready to produce buffers"));
   return TRUE;
 }
 
@@ -797,6 +820,42 @@
   return ret;
 }
 
+static gboolean
+gst_wpe_video_src_query (GstBaseSrc * base_src, GstQuery * query)
+{
+  GstWpeVideoSrc *src = GST_WPE_VIDEO_SRC (base_src);
+  GstGLBaseSrc *gl_src = GST_GL_BASE_SRC (base_src);
+  gboolean ret = FALSE;
+
+  switch (GST_QUERY_TYPE (query)) {
+    case GST_QUERY_LATENCY:{
+      GST_OBJECT_LOCK (src);
+      if (gl_src->out_info.fps_n > 0) {
+        GstClockTime latency;
+
+        latency = gst_util_uint64_scale (GST_SECOND, gl_src->out_info.fps_d,
+            gl_src->out_info.fps_n);
+        GST_OBJECT_UNLOCK (src);
+        gst_query_set_latency (query,
+            gst_base_src_is_live (GST_BASE_SRC_CAST (src)), latency,
+            GST_CLOCK_TIME_NONE);
+        GST_DEBUG_OBJECT (src, "Reporting latency of %" GST_TIME_FORMAT,
+            GST_TIME_ARGS (latency));
+        ret = TRUE;
+      } else {
+        GST_OBJECT_UNLOCK (src);
+      }
+
+      break;
+    }
+    default:
+      ret = GST_CALL_PARENT_WITH_DEFAULT (GST_BASE_SRC_CLASS, query,
+          (base_src, query), FALSE);
+      break;
+  }
+  return ret;
+}
+
 static void
 gst_wpe_video_src_init (GstWpeVideoSrc * src)
 {
@@ -859,6 +918,7 @@
       GST_DEBUG_FUNCPTR (gst_wpe_video_src_decide_allocation);
   base_src_class->stop = GST_DEBUG_FUNCPTR (gst_wpe_video_src_stop);
   base_src_class->event = GST_DEBUG_FUNCPTR (gst_wpe_video_src_event);
+  base_src_class->query = GST_DEBUG_FUNCPTR (gst_wpe_video_src_query);
 
   gl_base_src_class->supported_gl_api =
       static_cast < GstGLAPI >

_service:download_url:gst-plugins-bad-1.24.11.tar.xz/gst-libs/gst/codecparsers/gsth265bitwriter.c -> _service:download_url:gst-plugins-bad-1.24.12.tar.xz/gst-libs/gst/codecparsers/gsth265bitwriter.c Changed

_service:download_url:gst-plugins-bad-1.24.11.tar.xz/gst-libs/gst/mpegts/gstmpegtssection.c -> _service:download_url:gst-plugins-bad-1.24.12.tar.xz/gst-libs/gst/mpegts/gstmpegtssection.c Changed

_service:download_url:gst-plugins-bad-1.24.11.tar.xz/gst-libs/gst/mse/gstmsemediatype.c -> _service:download_url:gst-plugins-bad-1.24.12.tar.xz/gst-libs/gst/mse/gstmsemediatype.c Changed

_service:download_url:gst-plugins-bad-1.24.11.tar.xz/gst-libs/gst/mse/gstsourcebuffer.c -> _service:download_url:gst-plugins-bad-1.24.12.tar.xz/gst-libs/gst/mse/gstsourcebuffer.c Changed

_service:download_url:gst-plugins-bad-1.24.11.tar.xz/gst-libs/gst/wayland/gstwldisplay.c -> _service:download_url:gst-plugins-bad-1.24.12.tar.xz/gst-libs/gst/wayland/gstwldisplay.c Changed

_service:download_url:gst-plugins-bad-1.24.11.tar.xz/gst-plugins-bad.doap -> _service:download_url:gst-plugins-bad-1.24.12.tar.xz/gst-plugins-bad.doap Changed

_service:download_url:gst-plugins-bad-1.24.11.tar.xz/gst/mpegtsdemux/mpegtspacketizer.c -> _service:download_url:gst-plugins-bad-1.24.12.tar.xz/gst/mpegtsdemux/mpegtspacketizer.c Changed

_service:download_url:gst-plugins-bad-1.24.11.tar.xz/gst/rist/gstristsink.c -> _service:download_url:gst-plugins-bad-1.24.12.tar.xz/gst/rist/gstristsink.c Changed

_service:download_url:gst-plugins-bad-1.24.11.tar.xz/meson.build -> _service:download_url:gst-plugins-bad-1.24.12.tar.xz/meson.build Changed

_service:download_url:gst-plugins-bad-1.24.11.tar.xz/po/gst-plugins-bad-1.0.pot -> _service:download_url:gst-plugins-bad-1.24.12.tar.xz/po/gst-plugins-bad-1.0.pot Changed

_service:download_url:gst-plugins-bad-1.24.11.tar.xz/po/gst-plugins-bad.pot -> _service:download_url:gst-plugins-bad-1.24.12.tar.xz/po/gst-plugins-bad.pot Changed

_service:download_url:gst-plugins-bad-1.24.11.tar.xz/sys/amfcodec/gstamfav1enc.cpp -> _service:download_url:gst-plugins-bad-1.24.12.tar.xz/sys/amfcodec/gstamfav1enc.cpp Changed

_service:download_url:gst-plugins-bad-1.24.11.tar.xz/sys/amfcodec/gstamfh264enc.cpp -> _service:download_url:gst-plugins-bad-1.24.12.tar.xz/sys/amfcodec/gstamfh264enc.cpp Changed

_service:download_url:gst-plugins-bad-1.24.11.tar.xz/sys/amfcodec/gstamfh265enc.cpp -> _service:download_url:gst-plugins-bad-1.24.12.tar.xz/sys/amfcodec/gstamfh265enc.cpp Changed

_service:download_url:gst-plugins-bad-1.24.11.tar.xz/sys/applemedia/vtdec.c -> _service:download_url:gst-plugins-bad-1.24.12.tar.xz/sys/applemedia/vtdec.c Changed

@@ -303,7 +303,6 @@
   GstVideoCodecFrame *frame;
   GstFlowReturn ret = GST_FLOW_OK;
   GstVideoDecoder *decoder = GST_VIDEO_DECODER (vtdec);
-  gboolean is_flushing;
 
   g_mutex_lock (&vtdec->queue_mutex);
   while (gst_queue_array_is_empty (vtdec->reorder_queue)
@@ -321,6 +320,8 @@
    * that we push in PTS order, or if we're draining/flushing */
   while ((gst_queue_array_get_length (vtdec->reorder_queue) >=
           vtdec->dbp_size) || vtdec->is_flushing || vtdec->is_draining) {
+    gboolean is_flushing;
+
     frame = gst_queue_array_pop_head (vtdec->reorder_queue);
     is_flushing = vtdec->is_flushing;
     g_cond_signal (&vtdec->queue_cond);
@@ -358,7 +359,6 @@
 
   g_mutex_unlock (&vtdec->queue_mutex);
   GST_VIDEO_DECODER_STREAM_LOCK (vtdec);
-  vtdec->downstream_ret = ret;
 
   /* We need to empty the queue immediately so that session_output_callback() 
    * can push out the current buffer, otherwise it can deadlock */
@@ -370,10 +370,14 @@
       gst_video_decoder_release_frame (decoder, frame);
     }
 
+    if (vtdec->is_flushing && ret == GST_FLOW_FLUSHING) {
+      ret = GST_FLOW_OK;
+    }
     g_cond_signal (&vtdec->queue_cond);
     g_mutex_unlock (&vtdec->queue_mutex);
   }
 
+  vtdec->downstream_ret = ret;
   GST_VIDEO_DECODER_STREAM_UNLOCK (vtdec);
 
   if (ret != GST_FLOW_OK) {

_service:download_url:gst-plugins-bad-1.24.11.tar.xz/sys/d3d12/hlsl/VSMain_color.hlsl -> _service:download_url:gst-plugins-bad-1.24.12.tar.xz/sys/d3d12/hlsl/VSMain_color.hlsl Changed

_service:download_url:gst-plugins-bad-1.24.11.tar.xz/sys/d3d12/hlsl/VSMain_coord.hlsl -> _service:download_url:gst-plugins-bad-1.24.12.tar.xz/sys/d3d12/hlsl/VSMain_coord.hlsl Changed

_service:download_url:gst-plugins-bad-1.24.11.tar.xz/sys/d3d12/hlsl/VSMain_pos.hlsl -> _service:download_url:gst-plugins-bad-1.24.12.tar.xz/sys/d3d12/hlsl/VSMain_pos.hlsl Changed

_service:download_url:gst-plugins-bad-1.24.11.tar.xz/sys/decklink/gstdecklinkaudiosink.cpp -> _service:download_url:gst-plugins-bad-1.24.12.tar.xz/sys/decklink/gstdecklinkaudiosink.cpp Changed

_service:download_url:gst-plugins-bad-1.24.11.tar.xz/sys/decklink/gstdecklinkvideosink.cpp -> _service:download_url:gst-plugins-bad-1.24.12.tar.xz/sys/decklink/gstdecklinkvideosink.cpp Changed

@@ -921,7 +921,17 @@
 
   if (self->mode == GST_DECKLINK_MODE_AUTO) {
     BMDPixelFormat f;
-    mode = gst_decklink_find_mode_and_format_for_caps (caps, &f);
+    GstCaps *tmp = gst_caps_copy (caps);
+    guint i, n = gst_caps_get_size (tmp);
+
+    for (i = 0; i < n; i++) {
+      GstStructure *s = gst_caps_get_structure (tmp, 0);
+      gst_structure_remove_field (s, "framerate");
+    }
+
+    mode = gst_decklink_find_mode_and_format_for_caps (tmp, &f);
+    gst_caps_unref (tmp);
+
     if (mode == NULL) {
       GST_WARNING_OBJECT (self,
           "Failed to find compatible mode for caps  %" GST_PTR_FORMAT, caps);
@@ -1025,7 +1035,10 @@
   /* For output we support any framerate and only really care about timestamps */
   gst_caps_map_in_place (mode_caps, reset_framerate, NULL);
 
+  GST_DEBUG_OBJECT (self, "Mode caps %" GST_PTR_FORMAT, mode_caps);
+
   if (filter) {
+    GST_DEBUG_OBJECT (self, "Filter caps %" GST_PTR_FORMAT, filter);
     caps =
         gst_caps_intersect_full (filter, mode_caps, GST_CAPS_INTERSECT_FIRST);
     gst_caps_unref (mode_caps);
@@ -1033,6 +1046,8 @@
     caps = mode_caps;
   }
 
+  GST_DEBUG_OBJECT (self, "Returning caps %" GST_PTR_FORMAT, caps);
+
   return caps;
 }
 
@@ -1577,9 +1592,12 @@
   timestamp = GST_BUFFER_TIMESTAMP (buffer);
   duration = GST_BUFFER_DURATION (buffer);
   if (duration == GST_CLOCK_TIME_NONE) {
-    duration =
-        gst_util_uint64_scale_int (GST_SECOND, self->info.fps_d,
-        self->info.fps_n);
+    if (self->info.fps_n == 0)
+      duration = 0;
+    else
+      duration =
+          gst_util_uint64_scale_int (GST_SECOND, self->info.fps_d,
+          self->info.fps_n);
   }
   running_time =
       gst_segment_to_running_time (&GST_BASE_SINK_CAST (self)->segment,

_service:download_url:gst-plugins-bad-1.24.11.tar.xz/sys/wasapi/gstwasapisink.c -> _service:download_url:gst-plugins-bad-1.24.12.tar.xz/sys/wasapi/gstwasapisink.c Changed

_service:download_url:gst-plugins-bad-1.24.11.tar.xz/tests/check/elements/webrtcbin.c -> _service:download_url:gst-plugins-bad-1.24.12.tar.xz/tests/check/elements/webrtcbin.c Changed

@@ -5964,6 +5964,49 @@
 
 GST_END_TEST;
 
+GST_START_TEST (test_video_rtx_no_duplicate_payloads)
+{
+  struct test_webrtc *t = test_webrtc_new ();
+  GstWebRTCRTPTransceiverDirection direction;
+  GstWebRTCRTPTransceiver *trans;
+  GstCaps *caps;
+
+  VAL_SDP_INIT (no_duplicate_payloads, on_sdp_media_no_duplicate_payloads,
+      NULL, NULL);
+  guint media_format_count = { 3 };
+  VAL_SDP_INIT (media_formats, on_sdp_media_count_formats,
+      media_format_count, &no_duplicate_payloads);
+  VAL_SDP_INIT (count, _count_num_sdp_media, GUINT_TO_POINTER (1),
+      &media_formats);
+  const gchar *expected_offer_setup = { "actpass", };
+  VAL_SDP_INIT (offer_setup, on_sdp_media_setup, expected_offer_setup, &count);
+  const gchar *expected_offer_direction = { "sendrecv", };
+  VAL_SDP_INIT (offer, on_sdp_media_direction, expected_offer_direction,
+      &offer_setup);
+
+  t->on_negotiation_needed = NULL;
+  t->on_ice_candidate = NULL;
+  t->on_pad_added = _pad_added_fakesink;
+
+  /* Setup sendrecv transceiver with VP8 and H264.
+   * The RTX's payload type shouldn't be 96 or 97 since those are already taken. */
+  caps = gst_caps_from_string (VP8_RTP_CAPS (96) ";" H264_RTP_CAPS (97));
+  direction = GST_WEBRTC_RTP_TRANSCEIVER_DIRECTION_SENDRECV;
+  g_signal_emit_by_name (t->webrtc1, "add-transceiver", direction, caps,
+      &trans);
+  gst_caps_unref (caps);
+  fail_unless (trans != NULL);
+  g_object_set (trans, "do-nack", TRUE, NULL);
+  gst_object_unref (trans);
+
+  /* We don't really care about the answer in this test */
+  test_validate_sdp (t, &offer, NULL);
+
+  test_webrtc_free (t);
+}
+
+GST_END_TEST;
+
 static Suite *
 webrtcbin_suite (void)
 {
@@ -6053,6 +6096,7 @@
           "All datachannel tests are disabled. sctpenc %p, sctpdec %p", sctpenc,
           sctpdec);
     }
+    tcase_add_test (tc, test_video_rtx_no_duplicate_payloads);
   } else {
     GST_WARNING ("Some required elements were not found. "
         "All media tests are disabled. nicesrc %p, nicesink %p, "

_service:download_url:gst-plugins-bad-1.24.11.tar.xz/tests/examples/gtk/meson.build -> _service:download_url:gst-plugins-bad-1.24.12.tar.xz/tests/examples/gtk/meson.build Changed

_service:download_url:gst-plugins-bad-1.24.11.tar.xz/tests/examples/waylandsink/meson.build -> _service:download_url:gst-plugins-bad-1.24.12.tar.xz/tests/examples/waylandsink/meson.build Changed

@@ -1,22 +1,24 @@
+if not use_wayland
+  subdir_done()
+endif
+
 gtk_dep = dependency('gtk+-3.0', required : get_option('examples'))
 gtk_wayland_dep = dependency('gtk+-wayland-3.0', required : get_option('examples'))
 
-if use_wayland
-  if gtk_dep.found() and gtk_wayland_dep.found()
-    executable('waylandsink',
-      'main.c',
-      extra_files: 'window.ui',
-      install: false,
-      include_directories : configinc,
-      dependencies : gtk_dep, gtk_wayland_dep, gst_dep, gstwayland_dep,
-      c_args : gst_plugins_bad_args + '-DGST_USE_UNSTABLE_API',
-    )
-  endif
-  executable('wayland_threads',
-    'wayland-threads.c',
+if gtk_dep.found() and gtk_wayland_dep.found()
+  executable('waylandsink',
+    'main.c',
+    extra_files: 'window.ui',
     install: false,
     include_directories : configinc,
-    dependencies : gst_dep, gstwayland_dep, wl_client_dep,
+    dependencies : gtk_dep, gtk_wayland_dep, gst_dep, gstwayland_dep,
     c_args : gst_plugins_bad_args + '-DGST_USE_UNSTABLE_API',
   )
 endif
+executable('wayland_threads',
+  'wayland-threads.c',
+  install: false,
+  include_directories : configinc,
+  dependencies : gst_dep, gstwayland_dep, wl_client_dep,
+  c_args : gst_plugins_bad_args + '-DGST_USE_UNSTABLE_API',
+)

Changes of Revision 31